From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2050.outbound.protection.outlook.com [40.107.241.50]) by sourceware.org (Postfix) with ESMTPS id 5753D3858D28 for ; Mon, 17 Jul 2023 12:57:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5753D3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sJbdhj68v5G6CDt+Af8F3ZuTSXYXt3CDxavvgXOTnf8=; b=vDg9rST32uxi9IT5+x0KovaRSGwHxJE/dA2x6oMoQzR0TOoQjgtZ4c43fp7l99JdCtvLptUtrKNXr1q2d+880IorNgwq/ZhX7VvPhU7CEw0JI5QUHZFVhEOdysewb3SKD6/H4PhOE9a/P1Gxq95CvjpRBzHSNL2slfthfDr3HrE= Received: from AS9PR05CA0042.eurprd05.prod.outlook.com (2603:10a6:20b:489::12) by PAXPR08MB6590.eurprd08.prod.outlook.com (2603:10a6:102:152::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.31; Mon, 17 Jul 2023 12:57:35 +0000 Received: from AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:489:cafe::9c) by AS9PR05CA0042.outlook.office365.com (2603:10a6:20b:489::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.32 via Frontend Transport; Mon, 17 Jul 2023 12:57:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT026.mail.protection.outlook.com (100.127.140.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.33 via Frontend Transport; Mon, 17 Jul 2023 12:57:34 +0000 Received: ("Tessian outbound 95df046a2e2c:v145"); Mon, 17 Jul 2023 12:57:34 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f43002211d63bce0 X-CR-MTA-TID: 64aa7808 Received: from f80303ffc87d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5734BFA6-58C8-4FE7-8F81-2A8E96BBEF01.1; Mon, 17 Jul 2023 12:57:28 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f80303ffc87d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 17 Jul 2023 12:57:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aVgppJBTue6nJfFugYbplGaJFpbx9fn0aFyI+5wh3ypaWIixZbGuXJnXZyZ3q9fi1jTFWPdyWGKFyQFmgen05xkPSEA7eW2yfU/6YuSg6olpb6iu9fr9/mKFTvDyhvXjI1qZKsBCSSrcVNmF3b/1j59WJtUo1F3bh543G1McnCX8OT5tt5Ho19BiVkrX3CuiAEIP5yo7egWfkNVtzNAxyMQNHk5Mpn7gmnmX5iTRm9N1Wrx77RR4a8QFmUQKIE6lbqz5DFWemml1Zv595qv0eWkOIpwGEY/KDSC+iViBjcDyIaXW4cS53EjIFzFSEok/+ofa1DpE/Tpv+jIfUdzyUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sJbdhj68v5G6CDt+Af8F3ZuTSXYXt3CDxavvgXOTnf8=; b=YrHIAsKoSl2FPewJ1vUC3cRJUKBHqvIgeHf6H3Ep6kfMBIKAe4ZxN/srh0sJWZPSAjTXyLjrZyGA9RF7bkh1t3YisJ+ylpYzLEs6WGWLZlKveINEUWvsTxybT+8eZh88Ct4jGfA5KJ+4Nsdhz8hbPJOagY12o+n8d8ANx1YMcKvzN0HJlazUTmRmtj7Y0UxrFqpaX92IoSk9SyhDRAPy7dQIqeLtiUgpwnUfvSsLjiq1kYj79ACdNQRLUgSERG/dz3dnB4glR6pdwIgQauoRH1hmvcrYjcVMUFoYZwEnt2CcZibhpVZ+XENdE875A2ZJa24VCL0D98JDXLKUEr7kRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sJbdhj68v5G6CDt+Af8F3ZuTSXYXt3CDxavvgXOTnf8=; b=vDg9rST32uxi9IT5+x0KovaRSGwHxJE/dA2x6oMoQzR0TOoQjgtZ4c43fp7l99JdCtvLptUtrKNXr1q2d+880IorNgwq/ZhX7VvPhU7CEw0JI5QUHZFVhEOdysewb3SKD6/H4PhOE9a/P1Gxq95CvjpRBzHSNL2slfthfDr3HrE= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by DU0PR08MB9655.eurprd08.prod.outlook.com (2603:10a6:10:447::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.31; Mon, 17 Jul 2023 12:57:26 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::c00a:ca00:3485:6734]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::c00a:ca00:3485:6734%5]) with mapi id 15.20.6588.031; Mon, 17 Jul 2023 12:57:25 +0000 From: Wilco Dijkstra To: "lancasterharp@gmail.com" CC: 'GNU C Library' Subject: Re: Fix %Z parsing in strptime [BZ #16088] Thread-Topic: Fix %Z parsing in strptime [BZ #16088] Thread-Index: AQHZuKzRUaJGs5NLd0+/P/cUwmQjbA== Date: Mon, 17 Jul 2023 12:57:25 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|DU0PR08MB9655:EE_|AM7EUR03FT026:EE_|PAXPR08MB6590:EE_ X-MS-Office365-Filtering-Correlation-Id: b4160e5f-1a86-4188-1a19-08db86c5641c x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: psUw6qqjPVL+KwEJ5r6l1qoJcc3K/KEGCtbkpLZ2LZ/23CgBaZ3ilYIfRy6VRdchdaNXoNrd5teUxvsEP5e7Pg9SqECU5oep5NMbbDWpRG18wORt6M1/l0ArMC+FpyF8bpe81aDN0EKWUdOCp9NUox6k4LP+xg9uZDBF5FsZB66IeAy3Mlfo7cNE4bHbjJ/SVddQtUsS8YvkEltvJj4F39uAteWlwIzikOnJ+11xlhBL6zvv5C8UFfRdE+CAmnAvyQpNJXQ0AYM/T4HCsCiYuM4IPwDvkQjKcR2dSoU22PksEb2kkQIBoRnuQFt8dzue3Nl6lCLAhHwLpQoD1zjH82ehBslAolrybNZzXih3OwJrzySNDQ+pshEFBLGqWXqjDg1HnzxzHjxXzMaQ6kulrz1dEX/fxESeZCO61XMWuKS4CNmPu2jDjxeaTZay/FF6PT35cMqZFbU8gAO/2b41wZXpw6VC1cOGMViLGNllc74KHbl54kCoOWghoA6joKX+Q36tEJnhhk39NwhkHsuFdCwf+zz0XvRISpVkNikN2qHaDfT95gYEf3wkfj8qyzhUlmhGFnzC7YE0eE3h3omohMdZlurzx7ocrzNZWdKeduGY6ySCDEws0DboNTVk+uM+ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8982.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(366004)(136003)(346002)(376002)(451199021)(478600001)(71200400001)(7696005)(91956017)(6506007)(186003)(26005)(316002)(9686003)(76116006)(2906002)(4744005)(41300700001)(64756008)(52536014)(4326008)(6916009)(66946007)(66476007)(66446008)(5660300002)(8936002)(8676002)(66556008)(122000001)(38100700002)(86362001)(38070700005)(55016003)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9655 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 44713576-f6f1-4fe5-c5f3-08db86c55e9e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PeC1EBSNuBZ05wW7njO2vMRKDLKTVW1ISaX6hXVQUUVDdYYKBymn+yPWpQFfoMrUc+HUuMEw57u0W/eyoZAeGdOLE+d2FbW5WqRS9Z4G4STZ8wsO18MElFxuYI2+8L/kpXcWaOj9EZWjqBEgn8pHtGSn3fqUQ4tv2YIx98yznIb1AoilCR36SeP0fvAqg0nhKE1FjUPvQwvqUBtWZ346wpvIRrYrL0D7Fc//U8H7X32osnjArnNuDfKsBAi6XdayinMFf8NRQwqmNDWviLlYjq5XHEwXt0HdCBARlUsKuLrLpX13aHyVsbSHAk7xS8j1ecDble/otmGaXENxYerp+ZXFb3Z4Bi36mvUguXZ+Cm3nKkbRruwVKJCaMiOEwr2Ol96mV89yjpcxFfBByIZ86NFnzKMrqNgnK1Nnu2bpEzsAQ8pBfJjlMxAdcJLo/VkvmJk5aHDZnQDe5PYc8R98O8KZ+F+4ER6jFmkE814VRd/ZLahvaLNUjdnMa5RgNYEy6s5UdGd14TsBZhHATBpZg62u4q0kdNhfvHqxXaPcrHsr+VEejHNsVOYO0bQf0mt25qd4P8/NjCjfqNHWzy7pox6oh5LmZT+5CebVSPjt6rotz9FmqGnuYyHldWK7cpjmGkzl/NzcFR3xmY4ZUMZVFWDKS+krL1pxpZWNDOKvQ47VniJ6AM3SIWcr0pm0eGqQvsszJP7LcWS3KE7L3uNZZ0BurPIz3C8mKVeYFN3qf1pvjvKm4XwtqQFHsV3UvY6R X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(136003)(346002)(39860400002)(451199021)(82310400008)(36840700001)(46966006)(40470700004)(55016003)(40480700001)(40460700003)(356005)(81166007)(82740400003)(7696005)(70206006)(41300700001)(478600001)(6862004)(8676002)(52536014)(8936002)(5660300002)(316002)(70586007)(4326008)(336012)(186003)(36860700001)(6506007)(26005)(9686003)(47076005)(86362001)(33656002)(4744005)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 12:57:34.8831 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b4160e5f-1a86-4188-1a19-08db86c5641c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6590 X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Stanley,=0A= =0A= > + /* we recognize the format [-+a-zA-Z0-9]{3,} */=0A= =0A= Is that really the correct format? Eg. should it be able to parse UTC offse= ts like UTC+04:30?=0A= =0A= > while (ISSPACE (*rp))=0A= > rp++;=0A= >- while (!ISSPACE (*rp) && *rp !=3D '\0')=0A= >+ =0A= >+ const char* stop_rp =3D rp + 3;=0A= >+ while (((*rp >=3D 'A' && *rp <=3D 'Z') || (*rp >=3D 'a' && *rp <=3D 'z= ') || (*rp >=3D '0' && *rp <=3D '9')) && (rp < stop_rp) && *rp !=3D '\0')= =0A= =0A= This is basically isalnum() but not allowing '+' or '-'. And if timezone of= fsets are allowed,=0A= we'd also need ':'. And rather than allowing any sequence of these characte= rs, would it=0A= not be better to scan just for isalpha() first, and only if you see '+' or = '-' check the UTC=0A= offset syntax?=0A= =0A= Cheers,=0A= Wilco=