From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2078.outbound.protection.outlook.com [40.107.15.78]) by sourceware.org (Postfix) with ESMTPS id 8F05E385559F for ; Fri, 17 Mar 2023 18:22:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F05E385559F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SC2Em53OdxVFwRW5VuxFurQTdVig217rtES5evDR+O0=; b=cGFfmFc8xWyZG1k/c26fNSWRBz5q6fP4hr7WbhMc7dkNNgpiB+Tb1dvLcTsCQseKx+plQwKdDyYcbow6Pp+PnmkgTfPTZzCsMnmXEM4RtmLfdntZPICGnIP9aHsrg2n3fzW2d+E2vl0M3mf4AZhW5leo/Ox/hSlbCGyehQrK9FM= Received: from DUZPR01CA0226.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b4::13) by DB4PR08MB9287.eurprd08.prod.outlook.com (2603:10a6:10:3f5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.35; Fri, 17 Mar 2023 18:22:50 +0000 Received: from DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b4:cafe::70) by DUZPR01CA0226.outlook.office365.com (2603:10a6:10:4b4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.35 via Frontend Transport; Fri, 17 Mar 2023 18:22:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT035.mail.protection.outlook.com (100.127.142.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.10 via Frontend Transport; Fri, 17 Mar 2023 18:22:50 +0000 Received: ("Tessian outbound fcd8b5fba459:v135"); Fri, 17 Mar 2023 18:22:50 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1ac05c28afb65838 X-CR-MTA-TID: 64aa7808 Received: from f6e3a8ed351e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E6DF2D65-6124-4729-9412-1CF834566670.1; Fri, 17 Mar 2023 18:22:43 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f6e3a8ed351e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 17 Mar 2023 18:22:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=caziGvms1fiKR2Is0cOAc+25TOfvY2e88/Xc4PauYSVDFF1h57vQj1gw2Bp6Z4EzYAf45XleOkC8sTLOYyParBKGzlk/szRywjgx4TwJdcRUVey7Ot5pZscgohpVpeM/44SugOm4iO3tjdF/I5Y6usjRquiWBGkZTTr8KpuFMXNQQH/wzgLrLCgc49bPbhZaZD74qpGX9t8EtF0B1OQUZ+A3pKstpLGm174o5KYbKWEzx9/iclVfiVlAaQw/WTRxtL0H0Ftg7ZN3bY5yqVUVOICL2ETGU3yqMaxEI71Y/3b9fbM5yUdUM6oOwZ6N7miTCf4Qc9uteebzxGmK0s6+Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SC2Em53OdxVFwRW5VuxFurQTdVig217rtES5evDR+O0=; b=cmCAuvVpx7hdT7GIkIl5yBa2XrdsvG59WIUMXxyYV1Eg0+CGTxZ60j2eH9gpcQalwJHgIdBLI+GmYzZHmFDeyD9qS1+kX1Er11oM6iGkZ9p5HHWZo25Xlu48SA3XXkrwkMelTHoFft5TGT8QELyqDmeWDu9Ze0knNwI1e0Qs7ZwjesWrAA3PYQZ0U3xt1XQi7kOS8GTuCFp1/meEfQcmmL4+a8AaAgmydVLhqLZFTs6q3GxqwopULzNQ36r5FIxT24SgQRjGhfH+Sl+6iGTanYtGmm7AxQcDkvvYNq72jJJ6Ap2oAMuMfapoqizXpDSKIDsljnyxVzwZYa5G2SuzuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SC2Em53OdxVFwRW5VuxFurQTdVig217rtES5evDR+O0=; b=cGFfmFc8xWyZG1k/c26fNSWRBz5q6fP4hr7WbhMc7dkNNgpiB+Tb1dvLcTsCQseKx+plQwKdDyYcbow6Pp+PnmkgTfPTZzCsMnmXEM4RtmLfdntZPICGnIP9aHsrg2n3fzW2d+E2vl0M3mf4AZhW5leo/Ox/hSlbCGyehQrK9FM= Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by PAXPR08MB6397.eurprd08.prod.outlook.com (2603:10a6:102:12f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.35; Fri, 17 Mar 2023 18:22:40 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573%7]) with mapi id 15.20.6178.030; Fri, 17 Mar 2023 18:22:40 +0000 From: Wilco Dijkstra To: "H.J. Lu" CC: Adhemerval Zanella Netto , "libc-alpha@sourceware.org" , kirill Subject: Re: [PATCH v2 3/5] math: Improve fmod Thread-Topic: [PATCH v2 3/5] math: Improve fmod Thread-Index: AQHZV4EMzhGqWZw8wU+m559tgWlHQ678ldYAgADiRgCAAAgvoIAAX3kAgAEj0yOAACKfgIAAIU5y Date: Fri, 17 Mar 2023 18:22:40 +0000 Message-ID: References: <20230315205910.4120377-1-adhemerval.zanella@linaro.org> <20230315205910.4120377-4-adhemerval.zanella@linaro.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|PAXPR08MB6397:EE_|DBAEUR03FT035:EE_|DB4PR08MB9287:EE_ X-MS-Office365-Filtering-Correlation-Id: 43622afd-2dd7-448a-522b-08db27149da8 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +R5njomxbe+SK4Rj0cWEK5J/V08GsSJLsHIc3Epnga6PkTFD3mO9er2wsbdC+H6U6ViTjqcd+MUvcInQL5JoKiSwYo+OSbkn486LukK7UK3DwrUmv9FDSHNvnpdpMzAhJ34UyJKfkWIHMUcrMhkDNMPsBp47Hw11PS9fbeVDut49+wHm/O5RnEcnp6PCjEwbNk6NNGriOFQ4v1HmuvxBSRCwnRm8qoIJEx3XLOHDazfP+juj4Gc0/DPIwcslN3dovd4qOlBxSXKhb4YLorIyL0q97NnlY4ojfgLsh7zkilcrZQ/b4zYrH2DHjlSJmjvtz0HjVBjcu2xISQmeHIIM/WUQEcXkDereYJrA4jWObk+dRjf7tyrG/PRfBLJvvA4ffO5Jqb7k2r6iVOkqOcgAdVHtMfD9jJposD39em3G9J6CCZ2UtA5f11tdmGi5jIMar/4k1d93oi+/HqgSDJDQJMxJLKjHaIJuGKGSUzZJVhZfEtomm0sRbrwO86tmbSkLKkc/1lSxYJDsqOex0S78+EQDn32nmDOUByZxEXB7PAgJqhbgd/thqHqp/Lr4+5Zb9DBc7q5yVvyQRT8MhCl8/xVLDUh3haOTrtG47tzDoYkL9DvfawTvnesmQyQT1UUNuDDF90hByKgRSrAae+TF17XDA8SEi/a4LfbXNBhWuPgS8yD1JIygPfEuwZ3yw7sFQ+CenEnXz8kpHNhX+OTjjw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAWPR08MB8982.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(39850400004)(366004)(346002)(376002)(136003)(451199018)(91956017)(8676002)(6916009)(52536014)(38070700005)(76116006)(316002)(8936002)(66446008)(64756008)(66476007)(4326008)(66946007)(66556008)(38100700002)(86362001)(6506007)(26005)(33656002)(2906002)(186003)(7696005)(4744005)(41300700001)(71200400001)(5660300002)(122000001)(478600001)(83380400001)(54906003)(55016003)(9686003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6397 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e3ce44b4-1be4-41ef-3c1b-08db271497c6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0mW7Iz8RBj+15A8MrCTB+2QOcZkK6OYj6KT+JFhVpTsYiKzUkJpr5ZlWF9IsttQZmI6IHS3p9S3CZr0WlVHZwWDyFyQrAjjc0ndEQgvYQ4v3/Lu1TqQJKuwF3/rBmOZRZG1KfcguvdoFyDWMOMVytV0z/dISVw8i7AcNVhWM2teIWg+AaT5xHhrs+DUDAh/u6w5NSCBQgFe4Bcq96dLfRguMk6ZezJNlnpdmpcnPOgsh2MxEx7A9XG8hZ/qTViSFM0ubK69tWrliBgJx1PzZ90bnXdPpX3pnQbus0RP982EMwd6Oz/Y26jsNKv5G7O4cX1fIfagS7foBG7inyJdMy4pFi7y/JhBprX1ygktxYoTJM3rZG24O7lneBbkgEQfMDGsFNsloDTDx1wzePGxEUXx5uwqT+1TcLDCU49OKsZtwsy8+EJkcEpjqJ33ERYCwdo92vptEGvlMUJjI26ttCjY1qA3+BkHmbCQfScVEXBPx6zaMp7BW2jWP3K+hPPUMPqoM8tPrcZE8SsUTwJu3D5fnRAYUpcfxK1B4/ZZwb5ZMjZXDdFQzDZMMI5A67ttd8KtXVfRGjaDAE0UPOZwZO8R7CRrsi8xqoatD309b3rohU/TlUSxufuqjTbK6hQ2UlYPlrTksaIIW2kzpTfFjPC/ncndweolkZ32ZDNiEr5T9Jq9BgMB1+GPXstwUK1Hm5s4LMAULUouzOg/qDdUU5w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(39850400004)(376002)(346002)(451199018)(46966006)(40470700004)(36840700001)(186003)(9686003)(6862004)(82740400003)(40460700003)(81166007)(316002)(5660300002)(83380400001)(356005)(36860700001)(478600001)(54906003)(8676002)(70586007)(4744005)(41300700001)(4326008)(2906002)(70206006)(33656002)(8936002)(52536014)(40480700001)(55016003)(6506007)(107886003)(336012)(26005)(47076005)(7696005)(82310400005)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 18:22:50.0940 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 43622afd-2dd7-448a-522b-08db27149da8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9287 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi HJ,=0A= =0A= >> Also I think your results for generic above use the wrapper, so we'd sti= ll get the=0A= >> > 20% speedup which should make things closer.=0A= >=0A= >=0A= > The current __ieee754_fmod doesn't set errno nor does x87 __ieee754_fmod.= =0A= > A wrapper will avoid setting errno.=0A= =0A= The new generic fmod removes the wrapper since it sets errno when needed -= =0A= ie. the wrapper is unnecessary overhead. We must keep using the wrapper in= =0A= implementations that don't set errno of course.=0A= =0A= Applications never call __ieee754_fmod, so the right comparison is between= =0A= the generic fmod without the wrapper and the x87 fmod with the wrapper.=0A= =0A= Cheers,=0A= Wilco=