From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18510 invoked by alias); 9 Oct 2014 00:57:56 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 18500 invoked by uid 89); 9 Oct 2014 00:57:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Date: Thu, 09 Oct 2014 00:57:00 -0000 From: "Joseph S. Myers" To: Carlos O'Donell CC: Subject: Re: soft-fp: Add FP_DENORM_ZERO In-Reply-To: <5435D91B.90603@redhat.com> Message-ID: References: <5435D91B.90603@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2014-10/txt/msg00269.txt.bz2 On Wed, 8 Oct 2014, Carlos O'Donell wrote: > > diff --git a/soft-fp/soft-fp.h b/soft-fp/soft-fp.h > > index 86bc7fa..05fcca0 100644 > > --- a/soft-fp/soft-fp.h > > +++ b/soft-fp/soft-fp.h > > @@ -161,6 +161,11 @@ > > # define FP_HANDLE_EXCEPTIONS do {} while (0) > > #endif > > > > +/* Whether to flush subnormal inputs to zero with the same sign. */ > > +#ifndef FP_DENORM_ZERO > > +# define FP_DENORM_ZERO 0 > > +#endif > > OK, but... > > For the record this is an instance of the "centralized defaults" pattern > which we try to avoid in glibc. What if the target accidentally defines: I am unconvinced this can readily be avoided in the soft-fp code without a lot of duplication of common definitions in different sfp-machine.h files (of which there are a lot, when you consider those in libgcc and the Linux kernel as well as glibc). -- Joseph S. Myers joseph@codesourcery.com