From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20780 invoked by alias); 27 Oct 2014 18:07:36 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 20766 invoked by uid 89); 27 Oct 2014 18:07:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Date: Mon, 27 Oct 2014 18:07:00 -0000 From: "Joseph S. Myers" To: Andrew Pinski CC: Subject: Re: [PATCH 29/29] [AARCH64] Make lp64 and ilp32 directories. In-Reply-To: <1414396793-9005-30-git-send-email-apinski@cavium.com> Message-ID: References: <1414396793-9005-1-git-send-email-apinski@cavium.com> <1414396793-9005-30-git-send-email-apinski@cavium.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2014-10/txt/msg00640.txt.bz2 On Mon, 27 Oct 2014, Andrew Pinski wrote: > The patch makes the ilp32 and lp64 have their own directory under aarch64. > Since ILP32 uses most of the same system calls as LP64 and has a 64bit > off_t, we need make the functions that end in 64 the same as the ones without. > We also need not to special case ioctl or use the already provided mmap.c file. I'd expect you to need to move the ABI test baselines to the lp64 directory, and to add new baselines for ILP32 in the corresponding directory, but I don't see that in this patch series. What do your glibc test results look like? (I don't know if c++-types.data needs to move and have an ILP32 version as well, but I'd guess at least some affected types are different and so it does.) -- Joseph S. Myers joseph@codesourcery.com