From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by sourceware.org (Postfix) with ESMTPS id 9CD473858414 for ; Thu, 11 May 2023 07:15:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9CD473858414 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QOR1DKCufb4ajqUn3VmLoYefyTLawNTEfK8WqNO6TMDIaVKQVY17ViqKGaWRVAWQrIsMKfUxd9Myq2N3OZUutCjAVbkKhORodIWQS3QZGpFPQxc8iBCdi6jPAvKRGJuM3uRmp5aD2o32Jwbxd9Lo+DpqALZQyJJ4nWknuX+ymnMluAaj2XWvPu9bzdC1TOTHO/O46G2TCnYWsyPWZoblaD3CDLRcwtkuATvJM1+CLnNWiBFmJQikQwZWFTdZ0mUk75u1q6LiaiBmOcthQ0sh9eNgkCNWbgCwH7uQm4Bec+8ILUPxOgyzmHjY56A4o55gLlpmN4dGUGNo5ATT6P4McA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G5/q8p5AbE6vW9NUs3w+ks9s+WCascxt3ZUAAZEj1cY=; b=gOQy+pIHXfuLYrZQnYwTHyu4xoDlwD3BlARRka6EJWg74sW0AwaqCsCj0wxcmFMFRZ+xC0OKe0P0bgK8zhBgcX7JvXK6swLDii9QewonEMfTJrAK9fCUAf9LDOBJi/Po6P68jEAFSPSaLZMPZRjvWVzhZYfJ+Wl0wEI0lQXtHdhCjcV/3MqUvNFpK+b84AoYLrX5gDo/OMOfiOZsKSk+POIDWUWmQFn3SQ3jNBpVaROKBLVef5D6zgnWveFjatCwN5ip3hLR3Fn26AZGLRbJaCclNu9XYRQNftmwulLPQMTNlBXJAKqkTEns2hWuR8EPH00qAMts3gAQJX5KLxDFbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G5/q8p5AbE6vW9NUs3w+ks9s+WCascxt3ZUAAZEj1cY=; b=0CEcUW7p3rEH150xyr7jZF+GLF4yi0W+Uyr1ygrYov2hj5y0VNpwuaTheGqVJdWEysLQUBVVrym0h4HcyAWEDtSzZhHwgnHajQNhFCcm4aa7lrmCnDSVfB9/JAxtBOcNfwIducjBbH49zrfIpG6Ha7AFEfgrrpsVneI1g0A0B4A= Received: from SJ0PR12MB5633.namprd12.prod.outlook.com (2603:10b6:a03:428::8) by PH7PR12MB7965.namprd12.prod.outlook.com (2603:10b6:510:270::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.20; Thu, 11 May 2023 07:15:01 +0000 Received: from SJ0PR12MB5633.namprd12.prod.outlook.com ([fe80::e034:3643:c1a4:202c]) by SJ0PR12MB5633.namprd12.prod.outlook.com ([fe80::e034:3643:c1a4:202c%6]) with mapi id 15.20.6387.021; Thu, 11 May 2023 07:15:01 +0000 From: "Karumanchi, Sajan" To: Florian Weimer CC: "libc-alpha@sourceware.org" , "carlos@redhat.com" , "Mallappa, Premachandra" Subject: RE: [PATCH v1] x86: Cache computation for AMD architecture. Thread-Topic: [PATCH v1] x86: Cache computation for AMD architecture. Thread-Index: AQHZKxAH7aSc5axd0UaSzjANEuACy69RSMiOgAQRHeA= Date: Thu, 11 May 2023 07:15:01 +0000 Message-ID: References: <87edrubqvs.fsf@oldenburg.str.redhat.com> <87a5yepxbe.fsf@oldenburg.str.redhat.com> In-Reply-To: <87a5yepxbe.fsf@oldenburg.str.redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=e979f726-6c79-4170-bc23-87b391c1b4d0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-11T07:12:56Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR12MB5633:EE_|PH7PR12MB7965:EE_ x-ms-office365-filtering-correlation-id: f08aa2f8-c705-4574-4eb5-08db51ef6f7f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +4T8iX99gAqgJ5BctaoO0z5v6fTkfkbyQDnP2I0WdSKUKn/VawCuwn2fihW6n6ZxXpjQC4kw5xUoq6HVjZJIWNOnF7uhjkooB2E1RVP3+wucS28PAu/fIy6+R94Ufk+xlL19uJUU78n9X2B0MsEVR3rJ3QahKP6uQNUyL6O74GlfYYWzggpH6TFedxhlRp9b7CkXyc7E5RR4g92lwiLfKaFnz90QVpgpZj8plraTbmZO9KqSOsqI/ztbT1P5LCMf/y8s/Lzp8Cmz87amLTXCyiVAzGBe+V/F+iJJad4BSDbntJZ81JAOP5fGfcuMPC9UW1zeeResJwQEPd/tsDJPFidp2xnswSoxuKgNPAXr8+E/BemsEo/Ns7SAIGjJB7X5EhKkyRBHiVDJndjArVgVmj/8YVj5JaLlWSIuqjKnhzo71oKwvxqRaXEe1YATGxPNPrko+DocSQ4g0HdePfM+ssaVJR6v9VgjJU0RLzKPBOsz1qjmVL5+BEUI01Hrjg0yv5kB8SUDeWqsFoti5UcngwfWBUcSvdvFJXWI6woXX8svVOE+e9A/fDjeIYW0ZJL+jbvD5dOCQ1Ra40B0Pwql+05hqufrJJc+Q3HupaOA5aI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR12MB5633.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(136003)(376002)(451199021)(55236004)(38100700002)(186003)(26005)(7696005)(38070700005)(122000001)(86362001)(55016003)(83380400001)(4326008)(33656002)(2906002)(5660300002)(8936002)(8676002)(316002)(52536014)(6506007)(71200400001)(53546011)(9686003)(54906003)(6916009)(66556008)(64756008)(66446008)(66476007)(76116006)(41300700001)(66946007)(478600001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CVS/BrBFTKl9rfSPGgnxHYyHLHybsnsXd+pRqfr5/WC+Jb64ikFYeC2ps4D9?= =?us-ascii?Q?2y+PC5rTw9qpEQKnI2g/Kd662K99JuU72+I5aQ+Qirqqhzq5Qxua5okAZNFu?= =?us-ascii?Q?d7YcND0O5dL3ps8iwJHdbNy+KALTptWizJwyNFa3qXteAYEqeRtOHuc+adDz?= =?us-ascii?Q?AlQKf18CWp60aBz4s6BRL9zBRdkjOgPWIchLMk2fc6XZLQXLVN1QUkX9JZHa?= =?us-ascii?Q?P6UeR0BoPW0vyjORkPyKhIXkozN/dzGR+2i1j+5a7Fx4xwCaGsEDbtDrLX2R?= =?us-ascii?Q?ymj8Q5STxiA77vFmL+08KVzyXlewWyB4zKdpxXzOSJDegU4r9V4Tti2LmxUm?= =?us-ascii?Q?0f1REWeoHTk94qZlrWKzyr6p8+vOmUbzWwL9IVYS83ueDQykWu4GqvwxsvTC?= =?us-ascii?Q?kdNYZ4pA3VyT97LgXo4MEP3HUI+EG1nKF2BMwznzK1h2w8NEvXOr2iL96IdX?= =?us-ascii?Q?WIYbZv74FP0PAULrCF45PbehQZf5sIIadad0AEEVjqSQQsd9yTtyr/kDyKLJ?= =?us-ascii?Q?J3wGwFBvA9o9bOhjQqGR5qRsPk867t8aVmzNMR5a33NhdOO0t7wCd/7gM5Da?= =?us-ascii?Q?DRsM/TMd5qaQo++4RoyCgLxerAzlRDJ0xfgD65R3KJH0aBobMvoDhVVym5le?= =?us-ascii?Q?uF//4WhoEat4uwJiWQJq3fdis2SjnRY4wccdVW0n28viKbY54oFYixNLqQRQ?= =?us-ascii?Q?obFQwDfv7jPG5zQEP5QtRb6VVjD1My8KMc99c4zWAA8UNdC1EP504axxTuRH?= =?us-ascii?Q?qSoVmqDhVHxiSRKaTyvzrEh13tYkQsV60KIvjJ0LKfD/KOLejvNPSbH+AQww?= =?us-ascii?Q?N2hrQ8DnNXDHDSaWdh4uRdZQuXa5n0WvDyOH5O6IGK8jxGm+7GLcY6qfCJwH?= =?us-ascii?Q?Xj36pXOuBKu2JLuBJkCLg2EWJszJT0bcwDjlVaVFdQQ7genQsZq6tG2IyRDS?= =?us-ascii?Q?vlvfgbyjssLlmxRyFdOu0FQZp7Ude3rVZsjcC20msgtdYJMNNqz4iT5bRoX2?= =?us-ascii?Q?nkqQNCR1t5e9pwlxI/dyCklhXxmwoQn4jzZ0GMU8DeQMuF1XbExRbT1Np+L/?= =?us-ascii?Q?KFNcHqyu2We0DWm5SmoUCYS3dG8eVo9IL1coz5Qznjcye0BFDhCo4IiSKL73?= =?us-ascii?Q?qQjl08VWUl/g/ONG9uwkSjUMSYL9uDEpx6MD1dCK5HR8hx13a3Vthq7Ok+mK?= =?us-ascii?Q?vKCTviwlyzU+VSyJlTqy+mh/qQyML3gRmezLp+8S+BQ9IjWVFlirZjLTrgx/?= =?us-ascii?Q?EJ0VeiQCDJuJqwNw0MMTc8dHSQEkm9ypU3Dx8unoG/dadkAC7CjuZAL2ajaX?= =?us-ascii?Q?ZPFigYe+sYt78xydhasjY4Q+cvpl45Q0Tyb6aIRgbRJqRs+mLCWw5RyuaXhQ?= =?us-ascii?Q?mxzQfAY6IOwOHcZwsMEpnsXiNYtcQbIfyX9v7QWjHgxAvTt6CxrnRjwQw0GO?= =?us-ascii?Q?aG7SeBme9RtV18mX/CGrbkQIzMosFwCDqJFhgq6kHehkQ2Mv/hxcaLcAQTVB?= =?us-ascii?Q?pdR2eau6xOl0QKaJNNmSJVAv01Ssq3KA5k4R81+fooJRvgLdQo02/OLfeTAl?= =?us-ascii?Q?vaTs/NOmBIao8ejfTd8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR12MB5633.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f08aa2f8-c705-4574-4eb5-08db51ef6f7f X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2023 07:15:01.2263 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lGvJU5cWu1lhBpGvLGzgyLIVEb62OjX/gAN+wjSNxFQtWl1mTnRJaKZpqmmHbdmk1e8MZnHzdLj5FSR94BWYAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7965 X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: [AMD Official Use Only - General] Hi Florian, > -----Original Message----- > From: Florian Weimer > Sent: Monday, May 8, 2023 10:36 PM > To: Karumanchi, Sajan > Cc: libc-alpha@sourceware.org; carlos@redhat.com; Mallappa, > Premachandra > Subject: Re: [PATCH v1] x86: Cache computation for AMD architecture. > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > I'm sorry to report this new cache size computation approach is not > compatible with older AMD CPUs. Some existing hypervisors set these > CPUID values to zero while still identifying these CPUs as AMD. I filed = a new > bug to track this regression: > > New AMD cache size computation logic does not work for some CPUs, > hypervisors > > > It looks like we need to keep the old way of doing things. > Would you be able to work on a new patch? [Sajan] Yes, I will work on a new patch to handle the zeroed out CPUID scen= ario with the old way. > > I'm also going to file a separate bug, suggesting that we deselect string > functions that require cache size information if this information is not > available (mostly due to hypervisor masking). But that's a different iss= ue. > > Thanks, > Florian Thanks & Regards, Sajan K.