* [PATCH] aarch64: Disable A64FX memcpy/memmove BTI unconditionally
@ 2021-09-24 7:49 Naohiro Tamura
2021-09-24 8:15 ` Szabolcs Nagy
0 siblings, 1 reply; 3+ messages in thread
From: Naohiro Tamura @ 2021-09-24 7:49 UTC (permalink / raw)
To: Szabolcs Nagy, Wilco Dijkstra, 'GNU C Library'
This patch disables A64FX memcpy/memmove BTI instruction insertion
unconditionally such as A64FX memset patch [1] for performance.
[1] commit 07b427296b8d59f439144029d9a948f6c1ce0a31
---
sysdeps/aarch64/multiarch/memcpy_a64fx.S | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sysdeps/aarch64/multiarch/memcpy_a64fx.S b/sysdeps/aarch64/multiarch/memcpy_a64fx.S
index 65528405bb12..ae7464e09f42 100644
--- a/sysdeps/aarch64/multiarch/memcpy_a64fx.S
+++ b/sysdeps/aarch64/multiarch/memcpy_a64fx.S
@@ -19,6 +19,9 @@
#include <sysdep.h>
+#undef BTI_C
+#define BTI_C
+
/* Assumptions:
*
* ARMv8.2-a, AArch64, unaligned accesses, sve
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] aarch64: Disable A64FX memcpy/memmove BTI unconditionally
2021-09-24 7:49 [PATCH] aarch64: Disable A64FX memcpy/memmove BTI unconditionally Naohiro Tamura
@ 2021-09-24 8:15 ` Szabolcs Nagy
2021-09-24 12:19 ` naohirot
0 siblings, 1 reply; 3+ messages in thread
From: Szabolcs Nagy @ 2021-09-24 8:15 UTC (permalink / raw)
To: Naohiro Tamura; +Cc: Wilco Dijkstra, 'GNU C Library'
The 09/24/2021 07:49, Naohiro Tamura wrote:
> This patch disables A64FX memcpy/memmove BTI instruction insertion
> unconditionally such as A64FX memset patch [1] for performance.
>
> [1] commit 07b427296b8d59f439144029d9a948f6c1ce0a31
this is ok to commit, i assume you tested that it does
not unfavourably misalign some critical loop. i can
commit this for you if you want.
Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>
> ---
> sysdeps/aarch64/multiarch/memcpy_a64fx.S | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/sysdeps/aarch64/multiarch/memcpy_a64fx.S b/sysdeps/aarch64/multiarch/memcpy_a64fx.S
> index 65528405bb12..ae7464e09f42 100644
> --- a/sysdeps/aarch64/multiarch/memcpy_a64fx.S
> +++ b/sysdeps/aarch64/multiarch/memcpy_a64fx.S
> @@ -19,6 +19,9 @@
>
> #include <sysdep.h>
>
> +#undef BTI_C
> +#define BTI_C
> +
> /* Assumptions:
> *
> * ARMv8.2-a, AArch64, unaligned accesses, sve
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] aarch64: Disable A64FX memcpy/memmove BTI unconditionally
2021-09-24 8:15 ` Szabolcs Nagy
@ 2021-09-24 12:19 ` naohirot
0 siblings, 0 replies; 3+ messages in thread
From: naohirot @ 2021-09-24 12:19 UTC (permalink / raw)
To: 'Szabolcs Nagy'; +Cc: Wilco Dijkstra, 'GNU C Library'
Hi Szabolcs,
> The 09/24/2021 07:49, Naohiro Tamura wrote:
> > This patch disables A64FX memcpy/memmove BTI instruction insertion
> > unconditionally such as A64FX memset patch [1] for performance.
> >
> > [1] commit 07b427296b8d59f439144029d9a948f6c1ce0a31
>
> this is ok to commit, i assume you tested that it does
> not unfavourably misalign some critical loop. i can
> commit this for you if you want.
Thank you for the review.
Yes, I've tested and confirmed no problem.
Please merge it for me.
Thanks.
Naohiro
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-24 12:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-24 7:49 [PATCH] aarch64: Disable A64FX memcpy/memmove BTI unconditionally Naohiro Tamura
2021-09-24 8:15 ` Szabolcs Nagy
2021-09-24 12:19 ` naohirot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).