public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "naohirot@fujitsu.com" <naohirot@fujitsu.com>
To: 'Adhemerval Zanella' <adhemerval.zanella@linaro.org>,
	"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
	Mike Frysinger <vapier@gentoo.org>,
	Florian Weimer <fweimer@redhat.com>
Subject: RE: [PATCH] Replaced obsoleted AC_HELP_STRING to AS_HELP_STRING
Date: Tue, 16 Feb 2021 02:36:36 +0000	[thread overview]
Message-ID: <TYAPR01MB6025AD711F1BCFB4A1A56DC9DF879@TYAPR01MB6025.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <8f6cdd67-c67a-224a-702b-dbe28408e72c@linaro.org>

Adhemerval-san, Mike-san, Florian-san,

Thank you for all comments!
This is my second patch to glibc community, which I found during
thinking about how to check compiler option '-march=armv8.2-a+sve' to
add a64fx SoC multiarch code.

I took that consensus has been make among maintainers :-)
So I'd like to contribute to replace other obsolete macros too,
AC_TRY_COMPILE, AC_TRY_LINK and AC_CHECK_TOOL_PREFIX.

Thanks.
Naohiro

> -----Original Message-----
> From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> Sent: Tuesday, February 16, 2021 5:31 AM
> To: Tamura, Naohiro/田村 直広 <naohirot@fujitsu.com>;
> libc-alpha@sourceware.org; Mike Frysinger <vapier@gentoo.org>
> Subject: Re: [PATCH] Replaced obsoleted AC_HELP_STRING to
> AS_HELP_STRING
> 
> 
> 
> On 15/02/2021 17:21, Mike Frysinger wrote:
> > On 15 Feb 2021 13:39, Adhemerval Zanella wrote:
> >> Again, I don't have a strong opinion about it so I not following your
> >> slight aggressive tone here.
> >
> > apologies if it comes across that way.  i'm just (in my view) stating
> > facts (they're deprecated) and that alone is sufficient justification.
> >
> >> I just initially asked *why* change it,
> >
> > as stated in the original patch: it's an obsolete macro, and there's a
> > not-obsolete replacement.  seems like we should always merge this sort
> > of thing ?
> >
> >> Also please fix it on the aclocal.m4 as well.
> >
> > aclocal only uses AS_HELP_STRING that i can see.  where are you seeing
> > use of that AC variant ?
> >
> 
> It was a mistake from my part.
> 
> > on a somewhat related note, i can't help but feel like we should
> > switch to using aclocal to manage aclocal.m4 too.  splitting it up
> > into sep m4 files under m4/ should help with the gnarliness of the language ?
> > -mike
> >

  reply	other threads:[~2021-02-16  2:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-15 12:31 Naohiro Tamura
2021-02-15 12:59 ` Adhemerval Zanella
2021-02-15 13:29   ` Mike Frysinger
2021-02-15 13:39     ` Adhemerval Zanella
2021-02-15 15:38       ` Mike Frysinger
2021-02-15 16:39         ` Adhemerval Zanella
2021-02-15 17:17           ` Florian Weimer
2021-02-15 18:51             ` Adhemerval Zanella
2021-02-15 20:21           ` Mike Frysinger
2021-02-15 20:31             ` Adhemerval Zanella
2021-02-16  2:36               ` naohirot [this message]
2021-02-16 12:01 ` [PATCH 3/3] Removed obsolete AC_CHECK_TOOL_PREFIX Naohiro Tamura
2021-02-16 16:41   ` Zack Weinberg
2021-02-17  1:25     ` naohirot
2021-02-21 23:36   ` Mike Frysinger
2021-02-22  1:48     ` naohirot
2021-02-21 21:31 ` [PATCH] Replaced obsoleted AC_HELP_STRING to AS_HELP_STRING Mike Frysinger
2021-02-22  1:41   ` naohirot
2021-02-23  2:02   ` Carlos O'Donell
2021-05-10  0:52     ` naohirot
2021-05-10  1:17       ` Mike Frysinger
2021-05-10  2:15         ` naohirot
2021-05-10 14:16           ` naohirot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYAPR01MB6025AD711F1BCFB4A1A56DC9DF879@TYAPR01MB6025.jpnprd01.prod.outlook.com \
    --to=naohirot@fujitsu.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).