From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on0609.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe05::609]) by sourceware.org (Postfix) with ESMTPS id B68BD389003B for ; Thu, 1 Jul 2021 15:33:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B68BD389003B Received: from FR3P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::12) by AM5PR0801MB1875.eurprd08.prod.outlook.com (2603:10a6:203:43::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.23; Thu, 1 Jul 2021 15:33:46 +0000 Received: from VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1d:cafe::79) by FR3P281CA0002.outlook.office365.com (2603:10a6:d10:1d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.8 via Frontend Transport; Thu, 1 Jul 2021 15:33:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT023.mail.protection.outlook.com (10.152.18.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Thu, 1 Jul 2021 15:33:45 +0000 Received: ("Tessian outbound 1763b1d84bc3:v97"); Thu, 01 Jul 2021 15:33:45 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4f33b2f6baf5d8a6 X-CR-MTA-TID: 64aa7808 Received: from 4dc76c6a906e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C63C8EAF-3993-4EB4-BB75-603CBC63E16E.1; Thu, 01 Jul 2021 15:33:18 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4dc76c6a906e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 01 Jul 2021 15:33:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IzBBqnl5yKEKvq/N8deXB2a4eYmH79Za/h7mCJD1LTqedIBnAvta6MpOZkf8H8hlZQpOY0NttQxuSQOZsG2Q0+TVsi/ZAHUR29FPc0KP5NsEemPYKDjPcKlxG0PvaK3JzIOuX0uOUh133+6iRPG6/wRSIc8Nz4MGk0J7ONJVFKV0+CC3nFElYr4QfFqy28XcUBSu7EBDir5WU2cAdMirqp0L42ZpB/dQxFm9GnhIpv5MTsh/B89ONHdRGcIooSr8KDnFvMPKEymZTb4PVymsjPTey+gcCsCQsxbCJnesgwgvNUW3gLkuBC3JJsDragFCoSZd+DoPAxww8E4aZM99nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nW96X5TytskM2xWoirAbt/OvhtYZUkNO7rqaOhSpsyI=; b=N9aMrFeyBw/KkCNp+uUUHjUZco/CiJ6wv5rHw9OFjyJ+j/2yFi0b61ApnsLDlibzHZQy0lcSkuoSzqtOT9VWn5N3PIyYFu0qoJKrbNF4pXos32MyBrUuhrGTDtSZvidtsRQ2aOdY2hmxTMssN9MqVE3MQwgvQzLy8P+ySnYSpC2T1fyvKPlnfuaUHXs6rXEASQ7b4XvxkxLl6KXG5/quSJfXELNhepOpxuqjVTKIqOVwSFiY0KHxD3fXLaVcnp/KqaCQ0taRLQeVeMpWU5XH9/aM8jVLKN7EC6YeBXMyFDMGgzevtpTB+k5oPJhy8eWxaFxw+LdZI5YOSAR3EBVovQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from VE1PR08MB5599.eurprd08.prod.outlook.com (2603:10a6:800:1a1::12) by VI1PR0801MB2045.eurprd08.prod.outlook.com (2603:10a6:800:89::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Thu, 1 Jul 2021 15:33:15 +0000 Received: from VE1PR08MB5599.eurprd08.prod.outlook.com ([fe80::8c25:b5e8:b9be:13ac]) by VE1PR08MB5599.eurprd08.prod.outlook.com ([fe80::8c25:b5e8:b9be:13ac%5]) with mapi id 15.20.4242.023; Thu, 1 Jul 2021 15:33:15 +0000 From: Wilco Dijkstra To: Szabolcs Nagy CC: Szabolcs Nagy via Libc-alpha Subject: Re: [PATCH] AArch64: Add hp-timing.h Thread-Topic: [PATCH] AArch64: Add hp-timing.h Thread-Index: AQHXbAWY9l2T1LdHsES2JDT34KltX6ssQNwAgAACntaAAaV8AIAAPnMAgAASh3Q= Date: Thu, 1 Jul 2021 15:33:15 +0000 Message-ID: References: <20210630084643.GE14854@arm.com> <878s2rk9z2.fsf@oldenburg.str.redhat.com> , <20210701134810.GF14854@arm.com> In-Reply-To: <20210701134810.GF14854@arm.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [82.24.249.100] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 03b48d5b-f3b9-4b69-1515-08d93ca59d43 x-ms-traffictypediagnostic: VI1PR0801MB2045:|AM5PR0801MB1875: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:913;OLM:913; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: smSfvoABGsdww2wON9yBjgZwbV2vGBVzToq4m70gMA34SzAzlgIKoJob2CShSTdpiycBvFehHx0osuu0aFaO5kTy+8Tiu7t+u9vA0+1qzXvZV7/WQrBIJj7PKdICoNaCkh0OOaleUZiMNGvWUFnKqYmLbVTQoH3jtAIRab9JQIrudiNfrSBgLDlakkrv35Wax6JkjLyAipL6UYkI1617FSCVkjSOUeyD8kf37bJrb93qVbFq6FYuzwszTrT5ygV/vAoj30EHYITbGmsB3GY4LKPrXYn4TmzufZ9Wep425WaN/lxeKy562s6oVW7btdqJM3uVyO61M4qTfQchTkYdr9cJrbeDZG+zVnUbcRaBpegS4OA4aRisjlh24NMPUwozuiCJofOqt34L88QsCYF+txurJrMpgPeMsvuVDtijeZPnhO5vr15AlU1wjuWOutOpI+HKVxuMRPgJKGV9auIShy+OtJoTm8F8/mC/045gZgd2cnpZrB0VgTUFdU1gs0Dxt3tDRHRDp5Gvg0+TbcTW3Y1JrEk0rcydLOb3Wo3MGwZgWxRxeUm1D8iDuB2aFdUkuQfBWm7e6RtnR5yqhXQgORsjYt+MzR4YOLDFwhsFZqb0XmrtBGCaiwnf2XJyc22cMOy6+XgGjh0hOzP5fzITYg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB5599.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(376002)(366004)(396003)(346002)(39860400002)(186003)(76116006)(91956017)(478600001)(66946007)(2906002)(26005)(7696005)(6636002)(66556008)(52536014)(86362001)(5660300002)(4326008)(64756008)(66476007)(6506007)(66446008)(8936002)(33656002)(6862004)(316002)(55016002)(71200400001)(9686003)(38100700002)(8676002)(4744005)(122000001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?rDKHAP6UAW3kcdpx2eDSZXgFoQIlAy2kFRUJUzXvrnIH6/5URpHIs8/yu1?= =?iso-8859-1?Q?EsWDfayTaktSUVDm5NiQSMiD+a/jA2RXMPQEz6meeZsIwNNTkCFvyjMmbu?= =?iso-8859-1?Q?TKSjcEa0qPTd3T7MGtFMfR8w+rykaKYCk1aZGoPu/RGU94G9SRkz4oYT/o?= =?iso-8859-1?Q?9vkIfsPnE0eu29rMf4vghLg9GOAc+2Am/aLz76N6WQ/8rQUZKGONmzBMS0?= =?iso-8859-1?Q?neYOSt+me8699+sGIWHhL7xdxmPDeedIzPa5zU7t2SjmxMFjc/HzgCsBRd?= =?iso-8859-1?Q?Al4GulKebQouCmNfK6oZJMW5BeFrHOebGuEs43hDnlOre3YY7clMzEN65L?= =?iso-8859-1?Q?zAluST5FNKgE3f0Qyg6fPJzEUMsZ5J9YA0nEzpOnuBLUU4sPTC/4VEkcwI?= =?iso-8859-1?Q?ws3L6Py5iIUy0oguPF3aMXmaC7NnBcubcajrrRbD8BicT4jyt/JBxHAFMl?= =?iso-8859-1?Q?DVPLdCpek5YWk5Xblk4X15Ye4g2TWWxU6sXLmUAEU5oCW9a9RLeQ3Acz1d?= =?iso-8859-1?Q?H8F7QfUMJb6izN/EZJ+Chz6/6HSjzmlQfT9NNPXSX3tVK7q2SncBPegLx+?= =?iso-8859-1?Q?i1kOXfpVj6MWDKDVYmYkBbZ0hGiTXUx6LZALGBme43G5z6PM7eXxJpgRaP?= =?iso-8859-1?Q?P+EIJFCS5gC1k82LBcUA9V3x0tyov2J1kp8RRUwnOFWjU8ek9jmFMrXCSV?= =?iso-8859-1?Q?3qeKj/Je3f1TkOtroTgi9J9zVA1suZpym+d3n0mPKSgVvIXtUhjLWlA2C+?= =?iso-8859-1?Q?7wHg8+Sz18s5CHUAeCdd7hak7UERcRHdcM0P1bX+dsezqADgSsXkw44k1y?= =?iso-8859-1?Q?ioFzpQemFvr/bMTI+4gr+BflFWIBY+VnMB/HD59uJxw80MRNyk9X+4VGea?= =?iso-8859-1?Q?B1rsrv6zy3/Seg+SIRb5dIAZX09pwRCQzP8Layzj+wb/002UI87MspS7/+?= =?iso-8859-1?Q?f2UOGh7UfSmw3ZFW0l7z/HbXa0A6Hkps10cB6S5UxdjQGBPNBCYt1BR8YQ?= =?iso-8859-1?Q?7Cg82C8D5QpOb3Pm4kVNTPqcDwandqG8s6fB8MJZHtklyQotWYR5jOB56r?= =?iso-8859-1?Q?zrCjwXD+dbmMaHOKQ6h9scPq6coqkxmNKcynqa7urpf+Cikzhur4Dld5Yu?= =?iso-8859-1?Q?c4NIQmX4jJk0JfpFIiDOa8uP6Jdybqh+CPYc25ffNx7Kbb/IiTg5UhRcKe?= =?iso-8859-1?Q?RVkPNBfovRBJv/eu6r9SScN/yULzdBCDOxb196WsqI4tvuKmawKitPqLR0?= =?iso-8859-1?Q?clAejmr+cJGG4th70fJcOpfPJiGs1Yz/V3hNU9dp32CVG/3LNJS1RozKom?= =?iso-8859-1?Q?hC8vIPgcuYGfbyiypOvwjcGBiGExKN/kBXfYdo39iCFkKWw=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB2045 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: b011e53d-cee8-4f4e-f76c-08d93ca58b6f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uCefJ7J2677vmoVo91Dehpp54Asb/Jp2tygXg0ZQxgLT4zsR/kwTE7NB5wt9I5IQt7GdvUkHLrC0JLbtBfuy7v07dZkG0CWVMGVVd4xciJKW6cRusjiMT9oKBMoGrS6UePJjigGxMSYt9TulmUiFvLH9+6P8+Sd0+MNP6g79DB8M1Gl3sqy1ocfFlWd5i4sNRSBqWS3tX1JMnKkUWtuHCJgv9gktyHdpTOkQoLLJo16TPEyyO5NlwvD8ZXG/a7XaFj18iAehYGfVPYnVivs5HYPdeeXmu9PHwyZ5t6wVKLgCmFnxhlXSQEA24iVA/W+5u+ESEXam9UxTYkOtBS9PBq06K/UWNzPbIIepD1d1j2idocbj8JxS1+5IGqKlhkqDXR9LTHxFBGhm+pzyfbD07aEdy8fSUVRjwVlDEFUgTy3/lOWvCvcY0PN6JVPlnGGbxkmSJW1sHHttCUeXtYuNv00pV1W/R85azSkJvOJgnfdX+jD6AQFTAI9KvXH9JFD2eZHGNZH4eqvnLgROIfiYgqz5KlvdsphkPaxVJD4bNO1+vQtxBrxt2PplwYdwyy0eavnd0BhajE8spGxNSdm35O0eh9VyeQrnfavwiaPQ2AaQnsq/e4zS0Xi7S5bv+cbw7UQRHi/0Mf9s97ReQ4jvm/At82ArBwz54P90p7PH0+iMqY63gMd1S0LRDTA43QWELePPSjgCfPe9VKs8ZJTr4Q== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(376002)(346002)(36840700001)(46966006)(6862004)(186003)(8936002)(336012)(47076005)(55016002)(9686003)(316002)(70586007)(81166007)(70206006)(4326008)(86362001)(356005)(6636002)(2906002)(7696005)(478600001)(4744005)(82310400003)(26005)(8676002)(33656002)(5660300002)(52536014)(82740400003)(36860700001)(6506007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 15:33:45.3996 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 03b48d5b-f3b9-4b69-1515-08d93ca59d43 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1875 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jul 2021 15:33:51 -0000 Hi Szabolcs,=0A= =0A= > then just say the commit only affects the glibc benchmark code.=0A= >=0A= > i'm happy to accept the commit with that.=0A= =0A= I've changed the log to:=0A= =0A= Add hp-timing.h using the cntvct_el0 counter. Return timing in nanoseco= nds=0A= so it is fully compatible with generic hp-timing. Don't set HP_TIMING_I= NLINE=0A= in the dynamic linker since it adds unnecessary overheads and some anci= ent=0A= kernels may not handle emulating cntcvt correctly. Currently cntvct_el0= is=0A= only used for timing in the benchtests.=0A= =0A= > if we want to use it in the dynamic linker then we should=0A= > dig into the potential kernel issues (what versions are=0A= > affected etc)=0A= =0A= Agreed. Plus which machines might be affected - not all CPUs have=0A= trouble incrementing!=0A= =0A= Cheers,=0A= Wilco=