From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150077.outbound.protection.outlook.com [40.107.15.77]) by sourceware.org (Postfix) with ESMTPS id 6A1203857815 for ; Wed, 3 Nov 2021 13:39:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6A1203857815 Received: from AS9PR04CA0054.eurprd04.prod.outlook.com (2603:10a6:20b:46a::12) by DB7PR08MB2956.eurprd08.prod.outlook.com (2603:10a6:5:20::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.18; Wed, 3 Nov 2021 13:39:39 +0000 Received: from AM5EUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46a:cafe::3a) by AS9PR04CA0054.outlook.office365.com (2603:10a6:20b:46a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 3 Nov 2021 13:39:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT025.mail.protection.outlook.com (10.152.16.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Wed, 3 Nov 2021 13:39:39 +0000 Received: ("Tessian outbound 7b0bcc4a550a:v108"); Wed, 03 Nov 2021 13:39:39 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2b166417d9fc2fb3 X-CR-MTA-TID: 64aa7808 Received: from 70374233f767.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 93619DEA-D1DD-465E-8117-DD6C7EAC6C3F.1; Wed, 03 Nov 2021 13:39:30 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 70374233f767.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 03 Nov 2021 13:39:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GXw7A2QhRBztsNzocAIGuwxjalFlBekk342wRD9kNWDR3vD9coyxtmys1XvgwdcYJeojQ/iZ7jExm/33C/C7V4CuUe75ksnF3pdVGbq2Vo/cc3Rq6F1pinwdC0Q/vmcVBg/y0qbfTEcRr2EeYOv3o4yesZXpCD/JuwOBiZK3CMNRYMnXe3cvkYr7ybj6ksghf3gTFwUghpm2lRR6VOxZMlW7lu5sgUSRTfmjTN8geTvpA9LczjA5GYF6kkNIDTVeusNfJk1uGf2r0cG/tjjt+TEnALLt+Ubr2c8po3n/tfkn0MgYGVbdljvhJ5asrYU2eXUMGw9ZO9gpxMJM3MCUDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8T+9XfNEwZDwnu1oXs+m1Jvb6SP62n8Y9k60T64vdDs=; b=nBUmaZVB+XM4BNmmSwlRtX3+a68Y2tEgBMnIGuJiAaXxE3ligNiYdbbLsEjYC1I194Vu/4sYdkAwo6uy3PfOfqW9PLQuLQb8CbHg5y9i6uaaFs+0RNlZMmEVHt2XojaxRuWvGtagZiWzI9QVh9qyqLxgFZmAFoD+D2aOv/UlsQYHzjea+uZvupydO6buRvbhzy7+fhsg778z/4ke8eTgjFyQhyjt9C9H+Xq4yEeuAq66E70iRJgTKfI9tgA3jqlhJ+d8J0NHVeflHaocAdYZWYmkh9T1GKbgjXyv50AhdMfVX8DU52le01L+KtRTPhfHlAcnAxg3cgxscBcG6jIThg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from VE1PR08MB5599.eurprd08.prod.outlook.com (2603:10a6:800:1a1::12) by VE1PR08MB5023.eurprd08.prod.outlook.com (2603:10a6:803:107::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Wed, 3 Nov 2021 13:39:29 +0000 Received: from VE1PR08MB5599.eurprd08.prod.outlook.com ([fe80::e49f:f587:130d:78e4]) by VE1PR08MB5599.eurprd08.prod.outlook.com ([fe80::e49f:f587:130d:78e4%7]) with mapi id 15.20.4669.011; Wed, 3 Nov 2021 13:39:29 +0000 From: Wilco Dijkstra To: Noah Goldstein CC: GNU C Library Subject: Re: [PATCH v2 2/6] Benchtests: Add benchtests for __memcmpeq Thread-Topic: [PATCH v2 2/6] Benchtests: Add benchtests for __memcmpeq Thread-Index: AQHXzydildyHj3G/GkOYCgr47Hwgu6vu1TYAgAHk9YCAARTFYg== Date: Wed, 3 Nov 2021 13:39:29 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: a80f5860-8c3d-15c1-ee2e-f182baa30a30 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 37e466fd-48dd-43ef-28d3-08d99ecf6244 x-ms-traffictypediagnostic: VE1PR08MB5023:|DB7PR08MB2956: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LCZqO/QoOuBtCp+yE8uqdP1TyuCIRlgSQfFdfJFKFzjMBIekhcIsjT//3CFYu3ylNKxJ2JePkEd/UaeHfh8IpE/1PNmnUffY2UvjtIhpj5rCq2S2WESmqVM5aZOQkvtfHidsnSS2/zn7aUeOJ8TZ788LYyhaTARCEj0A84RiErqNAZ1yTMgr/TSjVcDyG7LLmCW0c2U6+86H4WF0qwWD0xTAOT2/qLqVrDTYIaqU7vdllrwIckMPkC18u6ohOgWhXAijex49HjbQ1qXXTBY1RS/QUNQcKxqjgIKg38lv4ZevGhLyhFBWV2QMkHGXYuRUspTQmxswHNyrI70tU3fO9v+YB4Q/Jbq0cPtTfIwlA8ywXhtQrresevoCkKyLmX4XQlBgyBAbrDPc3jPQ4pICCnJ0d/RGPhGHcBSe393kmmbm5ivw29C3D73VCuwhfPxRZ4ZQsJZAIETpaijg33qMKpzsqbW1H5NWQl3EEU2ToUZDiLBSKrEemRFDzf2R3/XN0g1uZWIIXvLUgI4UCOweo9HkiyEd4T6SXtyi1zMknfxseeh9XOcorgsXZkHnQ0WTX2GSXaAv7vHouJD1wFiU/o1lDM3p1cYWIYF4PmbiOExmQ4snyiHDBrEmkOoOjyEUpgELRcnSeS90VkmBaQ+vZe/UKXwFW1Q6VspEL7CEE0Uwei366OZDrNry5OP7sUDhuZaWzN5no47WJWMxtuGPlQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB5599.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8936002)(26005)(6916009)(4326008)(2906002)(8676002)(66476007)(76116006)(91956017)(7696005)(508600001)(83380400001)(66946007)(4744005)(316002)(64756008)(66446008)(9686003)(38070700005)(38100700002)(6506007)(122000001)(66556008)(86362001)(52536014)(33656002)(71200400001)(186003)(55016002)(5660300002); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5023 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 016054eb-c7d2-4c30-b641-08d99ecf5c32 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oXzs7GbCnNls5ZOcHT4FQ+c5n0WnEymtT3UQnburSERopaSkQKvgPpFtsB3zQA/e+rFMLGT7SJpW0pWOR3Ksx6xG+ropZOdfGocKmlGcvGFKb9tpNL+KCxt+EClIqARU6g+2lx0uYnKFR11ciIyPOtbcPojE3AjjNaTFA3xz2NzTtBnh+6rnjnrp/DcYfCp+lwpc/CbCrk33BDzi6x8x/uIohY4oEM2gy9EI5PBpP7WwpL0mxD9/ftjzWUZbdIIMiecNq3zIborLQ0enIxwGHk454OtPXwhXzBLoCFzYeilJbxGDO3SmFI+Sqg6qLMjvWdesrlYdRbGDQ3tci27pn6JmBuIxLYKPQyqxM8B6ZJWcs0LHpPB5zJURBuHCZnP3d4HLhpNJ2R9C/foRWHNpXG8bBP35TBsfnYJ7bUwwApgCnjLwAE31EXIkO0rYfv3mKTQTBP5vdnvY40XGcKollQ/IKC0f12Whgghhgyx4H8fco4TogPhcKYzPinCRO0vrtk9jBvWtvnuTtqRQnmsy17dKkGSEis0nyLivVTD8nkbQRs+3RJS6/9y9pihD4kt+2U0JUN3feNRn+Z3Ep4OR0LDCHC1Zm31nWdytyAfaHzVjkkwCB6hYJiY+raezOQm3xWnVIRThln5XkwVo/i+ZFbgspAUsE29tO4rgnAXjv57hbmY+vuyddP0NqkJryZzImrJH7LrsYH43R0+jYM/90Q== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(186003)(86362001)(4744005)(336012)(55016002)(2906002)(70206006)(70586007)(9686003)(8936002)(508600001)(33656002)(6506007)(316002)(47076005)(83380400001)(8676002)(4326008)(5660300002)(6862004)(82310400003)(36860700001)(52536014)(26005)(7696005)(81166007)(356005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 13:39:39.3088 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 37e466fd-48dd-43ef-28d3-08d99ecf6244 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB2956 X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2021 13:39:44 -0000 Hi Noah,=0A= =0A= > > As committed, it's literally the same benchmark as memcmp, however I=0A= > > expected it to call __memcmpeq... You'll need to change the definition = of=0A= > > MEMCMP as well.=0A= =0A= > Not certain why, but it does seem to be getting the right ifuncs. Can upd= ate it=0A= > if desirable.=0A= =0A= > Is this also true for 'wmemcmp'? I don't see it defining MEMCMP either.= =0A= =0A= Ifuncs use TEST_NAME (which is right) while there is also IMPL (MEMCMP, 1)= =0A= which is not correct. It is defined in bench-string - it does support wmemc= mp,=0A= but it is missing support for __memcmpeq.=0A= =0A= Cheers,=0A= Wilco=