public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Matthew Malcomson <Matthew.Malcomson@arm.com>
To: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Cc: nd <nd@arm.com>
Subject: [Patch] [Makefile] Exit if provided an incorrect argument
Date: Fri, 14 Dec 2018 15:16:00 -0000	[thread overview]
Message-ID: <VI1PR0801MB20145F5DF9B9E836FB02F5BCE0A10@VI1PR0801MB2014.eurprd08.prod.outlook.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

At the moment the ./testrun.sh file generated for testing a new glibc
doesn't handle incorrect arguments well.
It prints the usage of the script in an infinite loop.

This patch stops the infinite loop by exiting the program.

Tested by manually running the script after building.
I don't have commit rights, so if OK could someone commit this for me.
OK for master?

ChangeLog:

2018-11-29  Matthew Malcomson  <matthew.malcomson@arm.com>

	* Makefile (testrun.sh): Exit if provided incorrect arg.


diff --git a/Makefile b/Makefile
index b4703e48fec93075cd5e3ddd83469705d2fee8f8..1e1866be3da1ba4520911eb27016544de419161b 100644
--- a/Makefile
+++ b/Makefile
@@ -148,6 +148,7 @@ while test $$# -gt 0 ; do
       ;;
     --*)
       usage
+      exit 1
       ;;
     *)
       break


[-- Attachment #2: testrun-help-fix.patch --]
[-- Type: text/plain, Size: 284 bytes --]

diff --git a/Makefile b/Makefile
index b4703e48fec93075cd5e3ddd83469705d2fee8f8..1e1866be3da1ba4520911eb27016544de419161b 100644
--- a/Makefile
+++ b/Makefile
@@ -148,6 +148,7 @@ while test $$# -gt 0 ; do
       ;;
     --*)
       usage
+      exit 1
       ;;
     *)
       break


             reply	other threads:[~2018-12-14 14:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14 15:16 Matthew Malcomson [this message]
2019-01-15 10:01 ` Matthew Malcomson
2019-01-15 10:04 ` Florian Weimer
2019-01-15 10:33   ` Matthew Malcomson
2019-02-04 12:09     ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR0801MB20145F5DF9B9E836FB02F5BCE0A10@VI1PR0801MB2014.eurprd08.prod.outlook.com \
    --to=matthew.malcomson@arm.com \
    --cc=libc-alpha@sourceware.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).