From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51997 invoked by alias); 14 Dec 2018 14:26:30 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 51980 invoked by uid 89); 14 Dec 2018 14:26:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=20181129, 2018-11-29, Hx-languages-length:1037, H*c:HHH X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8olztWW2ebH4W+gVwtDLNV+/7m4OVhA8us+RfBGkZXQ=; b=RfU7pBWQnaovoxNQXrG4Knh3B/Vir4XHpHgfeyNiyk3GnFSCDCBD3lPexLL3JkLZ1wdO5agUO2sxkMC5EYcHhTczH9pCmJRsMdWsAG2hhpBec7el92xGwzwxRNBHxQVe3OK4QWuCaCNHwNhnE+gqoVtRUPTtJ8WZRZEu6DoWhAc= From: Matthew Malcomson To: "libc-alpha@sourceware.org" CC: nd Subject: [Patch] [Makefile] Exit if provided an incorrect argument Date: Fri, 14 Dec 2018 15:16:00 -0000 Message-ID: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Matthew.Malcomson@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Content-Type: multipart/mixed; boundary="_002_VI1PR0801MB20145F5DF9B9E836FB02F5BCE0A10VI1PR0801MB2014_" MIME-Version: 1.0 X-SW-Source: 2018-12/txt/msg00489.txt.bz2 --_002_VI1PR0801MB20145F5DF9B9E836FB02F5BCE0A10VI1PR0801MB2014_ Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable Content-length: 786 At the moment the ./testrun.sh file generated for testing a new glibc doesn't handle incorrect arguments well. It prints the usage of the script in an infinite loop. This patch stops the infinite loop by exiting the program. Tested by manually running the script after building. I don't have commit rights, so if OK could someone commit this for me. OK for master? ChangeLog: 2018-11-29 Matthew Malcomson * Makefile (testrun.sh): Exit if provided incorrect arg. diff --git a/Makefile b/Makefile index b4703e48fec93075cd5e3ddd83469705d2fee8f8..1e1866be3da1ba4520911eb2701= 6544de419161b 100644 --- a/Makefile +++ b/Makefile @@ -148,6 +148,7 @@ while test $$# -gt 0 ; do ;; --*) usage + exit 1 ;; *) break --_002_VI1PR0801MB20145F5DF9B9E836FB02F5BCE0A10VI1PR0801MB2014_ Content-Type: text/plain; name="testrun-help-fix.patch" Content-Description: testrun-help-fix.patch Content-Disposition: attachment; filename="testrun-help-fix.patch"; size=284; creation-date="Fri, 14 Dec 2018 14:26:23 GMT"; modification-date="Fri, 14 Dec 2018 14:26:23 GMT" Content-ID: <041F012AA6876D4492FABFE26D8D350C@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 Content-length: 387 ZGlmZiAtLWdpdCBhL01ha2VmaWxlIGIvTWFrZWZpbGUKaW5kZXggYjQ3MDNl NDhmZWM5MzA3NWNkNWUzZGRkODM0Njk3MDVkMmZlZThmOC4uMWUxODY2YmUz ZGExYmE0NTIwOTExZWIyNzAxNjU0NGRlNDE5MTYxYiAxMDA2NDQKLS0tIGEv TWFrZWZpbGUKKysrIGIvTWFrZWZpbGUKQEAgLTE0OCw2ICsxNDgsNyBAQCB3 aGlsZSB0ZXN0ICQkIyAtZ3QgMCA7IGRvCiAgICAgICA7OwogICAgIC0tKikK ICAgICAgIHVzYWdlCisgICAgICBleGl0IDEKICAgICAgIDs7CiAgICAgKikK ICAgICAgIGJyZWFrCgo= --_002_VI1PR0801MB20145F5DF9B9E836FB02F5BCE0A10VI1PR0801MB2014_--