From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73496 invoked by alias); 1 Nov 2016 15:58:35 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 70631 invoked by uid 89); 1 Nov 2016 15:58:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=U*owner, sk:owner@s, ownersourcewareorg, sk:owners X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com From: Tamar Christina To: Joseph Myers , Andreas Schwab CC: Carlos O'Donell , Florian Weimer , GNU C Library , nd , Bin Cheng Subject: RE: [PATCH v4] Fix -Os related build and test failures. Date: Tue, 01 Nov 2016 15:58:00 -0000 Message-ID: References: <6eac682f-26fa-6a47-9497-357206266ba1@redhat.com> <6be7dce5-bfa7-32c7-5bac-6c3b79776683@redhat.com> <38a493b5-e73f-1bf8-46f0-4121e547a05d@redhat.com> <2ff34c0c-7571-4198-890a-2b30dd7d2920@redhat.com> <5379c2f2-74e6-2550-8d42-2d41d1f6478d@redhat.com> <428b3741-9228-68f3-76ec-d042e4075ded@redhat.com> <87mvhjwod1.fsf@linux-m68k.org> In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Tamar.Christina@arm.com; x-ms-office365-filtering-correlation-id: 08452121-719c-4846-aab6-08d4026fe710 x-microsoft-exchange-diagnostics: 1;AM4PR0802MB2161;7:9M+N0eiD+O9zR+HrT2AaPAVE8gEptvUGbptDqpcoAxRchvW0gUYOnmHaPKH8gMiNNA67cqGAIXxnuFLwNH/vl4jixk6GzOpbCvTiUpx7IQGx5HLb1Mi7o/CFEJbv31pLb7HJ6sSVLz5bLqLbU6P1HQ8EHW3ZAqLvAIYgPaUg5kCJgiy0rMuC2LzcMyumoFdwcoK8XOyATNAfdwQpHPbxvv0Hi3ti7Ph24g7dZOTYqtXfx6oAWH81y+qUTJyZ7+vPlS6z2wZW4O3uk8BIUtpaku3WTDQF5ypdx2XkID7H84dwij+cnuWBpt00XjCp0SofsqtLaJoiEWUXslNM8gUdXn5mUXcXj0BN+C9SWDLA4jM= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0802MB2161; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:AM4PR0802MB2161;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0802MB2161; x-forefront-prvs: 01136D2D90 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(13464003)(24454002)(189002)(199003)(106356001)(105586002)(106116001)(5002640100001)(101416001)(54356999)(76176999)(50986999)(9686002)(76576001)(93886004)(7696004)(66066001)(33656002)(4326007)(5660300001)(2900100001)(92566002)(3660700001)(3846002)(586003)(6116002)(102836003)(10400500002)(189998001)(8676002)(5001770100001)(97736004)(7736002)(7846002)(305945005)(3280700002)(74316002)(2906002)(122556002)(81156014)(81166006)(77096005)(2950100002)(86362001)(68736007)(8936002)(87936001)(19580405001)(19580395003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR0802MB2161;H:VI1PR0801MB2031.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2016 15:58:20.5875 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2161 X-SW-Source: 2016-11/txt/msg00031.txt.bz2 This also breaks ARM and AArch64, Would it be worth reverting the commit until this is fixed? It's currently blocking trunk builds. Kind Regards, Tamar > -----Original Message----- > From: libc-alpha-owner@sourceware.org [mailto:libc-alpha- > owner@sourceware.org] On Behalf Of Joseph Myers > Sent: 01 November 2016 11:13 > To: Andreas Schwab > Cc: Carlos O'Donell; Florian Weimer; GNU C Library > Subject: Re: [PATCH v4] Fix -Os related build and test failures. >=20 > On Tue, 1 Nov 2016, Andreas Schwab wrote: >=20 > > On Okt 30 2016, Carlos O'Donell wrote: > > > > > diff --git a/resolv/res_send.c b/resolv/res_send.c index > > > 6d46bb2..4ec8c1a 100644 > > > --- a/resolv/res_send.c > > > +++ b/resolv/res_send.c > > > @@ -664,7 +664,7 @@ send_vc(res_state statp, > > > a false-positive. > > > */ > > > DIAG_PUSH_NEEDS_COMMENT; > > > - DIAG_IGNORE_NEEDS_COMMENT (5, "-Wmaybe-uninitialized"); > > > + DIAG_IGNORE_Os_NEEDS_COMMENT (5, "-Wmaybe-uninitialized"); > > > int resplen; > > > DIAG_POP_NEEDS_COMMENT; > > > struct iovec iov[4]; > > > > That breaks powerpc and s390. > > > > res_send.c: In function 'send_vc': > > res_send.c:668:6: error: 'resplen' may be used uninitialized in this fu= nction > [-Werror=3Dmaybe-uninitialized] > > int resplen; > > ^~~~~~~ >=20 > And the other change to the same file introduces a new use of > DIAG_IGNORE_NEEDS_COMMENT with a comment that only mentions -Os. > Was the intent to edit the latter use to be > DIAG_IGNORE_Os_NEEDS_COMMENT, with the former one edited by > mistake instead? >=20 > -- > Joseph S. Myers > joseph@codesourcery.com