From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: Xuelei Zhang <zhangxuelei4@huawei.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
nd <nd@arm.com>, "siddhesh@gotplt.org" <siddhesh@gotplt.org>,
"jiangyikun@huawei.com" <jiangyikun@huawei.com>,
"yikunkero@gmail.com" <yikunkero@gmail.com>
Cc: nd <nd@arm.com>
Subject: Re: [PATCH v2 2/2] aarch64: Optimized memcpy and memmove for Kunpeng processor
Date: Tue, 22 Oct 2019 18:29:00 -0000 [thread overview]
Message-ID: <VI1PR0801MB21275D517F5EEFBBFDD3E30D83680@VI1PR0801MB2127.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20191017131548.10808-1-zhangxuelei4@huawei.com>
Hi Xuelei,
In order to select the right memmove implementation, multiarch/memmove.c needs
similar changes as multiarch/memcpy.c.
Also since the memmove entry sequence does both check for medium and large cases, the
full overlap check should be done in both. Currently only sizes 96-512 benefit, not the
move_long case:
+ /* long move: more than 512 bytes align the dstend */
+ .p2align 4
+L(move_long):
+1:
+ add srcend, src, count
+ add dstend, dstin, count
This should do the same as move_middle:
+L(move_middle):
+ cbz tmp1, 3f
Wilco
next prev parent reply other threads:[~2019-10-22 18:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 13:16 Xuelei Zhang
2019-10-17 14:57 ` Yikun Jiang
2019-10-18 15:50 ` Wilco Dijkstra
2019-10-22 18:29 ` Wilco Dijkstra [this message]
2019-10-21 14:25 Zhangxuelei (Derek)
2019-10-22 9:50 ` Yikun Jiang
2019-10-24 14:57 ` Carlos O'Donell
2019-10-26 9:57 ` Florian Weimer
2019-10-26 13:40 ` Carlos O'Donell
2019-10-29 1:20 ` Carlos O'Donell
2019-10-29 14:34 ` Wilco Dijkstra
2019-10-26 13:22 Zhangxuelei (Derek)
2019-10-26 13:40 ` Carlos O'Donell
2019-10-26 13:46 Zhangxuelei (Derek)
2019-10-29 3:22 Zhangxuelei (Derek)
2019-10-29 3:26 ` Carlos O'Donell
2019-10-30 6:42 ` Yikun Jiang
2019-11-01 12:55 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0801MB21275D517F5EEFBBFDD3E30D83680@VI1PR0801MB2127.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=jiangyikun@huawei.com \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
--cc=siddhesh@gotplt.org \
--cc=yikunkero@gmail.com \
--cc=zhangxuelei4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).