RE: [PATCH v5 12/13] string: Add sigabbrev_np and sigdescr_np

[Tamar Christina <Tamar.Christina@arm.com>]

Hi Florian,

> -----Original Message-----
> From: Florian Weimer <fweimer@redhat.com>
> Sent: Wednesday, July 8, 2020 12:37 PM
> 
> * Tamar Christina:
> 
> > This commit seems to have broken the aarch64 build:
> >
> >   sigdescr_np.c:24:1: error: conflicting types for ‘__sigdescr_np’
> >    __sigdescr_np (int signum)
> >    ^~~~~~~~~~~~~
> >
> >   In file included from <command-line>:0:0:
> >   ../include/string.h:57:20: note: previous declaration of
> > ‘__sigdescr_np’ was here
> >    libc_hidden_proto (__sigdescr_np)
> >                       ^
> >   ./../include/libc-symbols.h:605:33: note: in definition of macro
> > ‘__hidden_proto’
> >      extern thread __typeof (name) name __hidden_proto_hiddenattr
> (attrs);
> >                                    ^~~~
> >
> >   ./../include/libc-symbols.h:624:44: note: in expansion of macro
> > ‘hidden_proto’
> >    # define libc_hidden_proto(name, attrs...) hidden_proto (name, ##attrs)
> >                                               ^~~~~~~~~~~~
> >   ../include/string.h:57:1: note: in expansion of macro ‘libc_hidden_proto’
> >    libc_hidden_proto (__sigdescr_np)
> >    ^~~~~~~~~~~~~~~~~
> >
> >   In file included from <command-line>:0:0:
> >   ../o-iterator.mk:9: recipe for target '/home/teamcity-
> > agent/work/fcc7c27539f88edf/build/string/sigdescr_np.o' failed
> >   sigdescr_np.c:34:28: error: conflicting types for ‘sigdescr_np’
> >    weak_alias (__sigdescr_np, sigdescr_np)
> >                               ^
> >   ./../include/libc-symbols.h:152:26: note: in definition of macro
> ‘_weak_alias’
> >      extern __typeof (name) aliasname __attribute__ ((weak, alias
> > (#name))) \
> >                             ^~~~~~~~~
> >   sigdescr_np.c:34:1: note: in expansion of macro ‘weak_alias’
> >    weak_alias (__sigdescr_np, sigdescr_np)
> >    ^~~~~~~~~~
> >   In file included from ../include/string.h:63:0,
> >                    from sigdescr_np.c:19:
> >   ../string/string.h:469:20: note: previous declaration of
> > ‘sigdescr_np’ was here
> >    extern const char *sigdescr_np (int __sig) __THROW;
> >                       ^~~~~~~~~~~
> >   make[2]: *** [/home/teamcity-
> > agent/work/fcc7c27539f88edf/build/string/sigdescr_np.o] Error 1
> >   make[2]: *** Waiting for unfinished jobs....
> >   sigabbrev_np.c:24:1: error: conflicting types for ‘sigabbrev_np’
> >    sigabbrev_np (int signum)
> >    ^~~~~~~~~~~~
> >   In file included from ../include/string.h:63:0,
> >                    from sigabbrev_np.c:19:
> >   ../string/string.h:466:20: note: previous declaration of
> > ‘sigabbrev_np’ was here
> >    extern const char *sigabbrev_np (int __sig) __THROW;
> >                       ^~~~~~~~~~~~
> >
> > I'm afraid I don't know glibc internals well enough to know what the
> > right fix is here...
> 
> What's your GCC version?  I don't see this when building with a GCC 10 cross-
> compiler.

It seems to be GCC 6.3 from a native Debian docker image

0e188cdeda88 ~# gcc --version
...
gcc version 6.3.0 20170516 (Debian 6.3.0-18+deb9u1)
...

0e188cdeda88 ~# lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description:    Debian GNU/Linux 9.12 (stretch)
Release:        9.12
Codename:       stretch

Cheers,
Tamar

> 
> Thanks,
> Florian