From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2086.outbound.protection.outlook.com [40.107.247.86]) by sourceware.org (Postfix) with ESMTPS id 06D73385B51F for ; Mon, 20 Feb 2023 13:25:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 06D73385B51F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k1wkkOiybogILGiSiNDFY/IrNs19FTKfdmOH987x9zs=; b=H+Qgg8tZvLJ5GeBqy7VMP4yNkrpVKqXKBrR7zgljFTNjJvVY1u7/idtsTZLK/mT2sYUAvqNRRjXVwJBnbYG+0g3W6HpxxVRa9S72FDnHmrErqKziPeJLnTrLx781wNkn0dcvNsy3SiMwOlaZaVIhSI4eauh6rFoF2y6+EoVmNE4= Received: from AS8PR05CA0008.eurprd05.prod.outlook.com (2603:10a6:20b:311::13) by VI1PR08MB10050.eurprd08.prod.outlook.com (2603:10a6:800:1c4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.18; Mon, 20 Feb 2023 13:24:59 +0000 Received: from AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:311:cafe::53) by AS8PR05CA0008.outlook.office365.com (2603:10a6:20b:311::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.20 via Frontend Transport; Mon, 20 Feb 2023 13:24:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT052.mail.protection.outlook.com (100.127.140.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.20 via Frontend Transport; Mon, 20 Feb 2023 13:24:59 +0000 Received: ("Tessian outbound baf1b7a96f25:v132"); Mon, 20 Feb 2023 13:24:59 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3434ac25dfc6a6f0 X-CR-MTA-TID: 64aa7808 Received: from 24cd8a3592e8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AAD006B3-194E-471B-9D30-B8F9B4A905FE.1; Mon, 20 Feb 2023 13:24:53 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 24cd8a3592e8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 20 Feb 2023 13:24:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LiYZ2xOJuoji7VNjWAtmzVS5udK7zeDcGj1p+fBa885Z1l5gdRnekKP+wnELfwdqW7suhfr47RjEnm9HgK4nPGI6IEnkBGeoX+E8atxLocSHMOL4U1Bue6GGAg6gJ4rgHGJr51qPnisx1J+xmYer1yCINHYd2aJk07kAoCKcanuVcuWEA8SKh+AISJrVNeRHhCLCTuumrp9Wz3C/ZXIpn6Wld/1gxQXyD0oIEaI6I9JPJp2yYaMhdzH7bn6KC6r7pS4Hr6iFcjb77JiZcK0lC209a5dmlkLPFrAsRkM5d5hZ2L4AuyCSQpxu3aQkgP7cFlQM/HgLlnpPJUPprRVcAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k1wkkOiybogILGiSiNDFY/IrNs19FTKfdmOH987x9zs=; b=a5tAsPGicDCeXq9VfMTFJm4YvxmlL66LpzKUtC7OEV9i0k+sO7n2b3bBzGTS1NwuBMPNvUAUQT/DBp4cic0ZHAYPq8nttEU2rjUpXbqtWRilF9NxMXbwLvBRPbmMGYiPKOsyozOZh3L+Tw0omHrMZVTIejqSEe/E1wGOLcoXsS0UmcXHUCUuz/1Lh2utSOyTq7fqfgbkvw2agc2F+ZoQpssHKfta3+q4XH5VAft30ZDv9zhQopaY0sgnVHraQyxeIy82PbjO2vy6ykR6k9GaumVil5Bl0402jpr2q6HzAn8WmBI3rzodW8kxdTs7p/IXADzQ6gTdDP7VW/s7vurPAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k1wkkOiybogILGiSiNDFY/IrNs19FTKfdmOH987x9zs=; b=H+Qgg8tZvLJ5GeBqy7VMP4yNkrpVKqXKBrR7zgljFTNjJvVY1u7/idtsTZLK/mT2sYUAvqNRRjXVwJBnbYG+0g3W6HpxxVRa9S72FDnHmrErqKziPeJLnTrLx781wNkn0dcvNsy3SiMwOlaZaVIhSI4eauh6rFoF2y6+EoVmNE4= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by AS2PR08MB9896.eurprd08.prod.outlook.com (2603:10a6:20b:5fe::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.19; Mon, 20 Feb 2023 13:24:51 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::29ca:64bc:9a10:b072]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::29ca:64bc:9a10:b072%7]) with mapi id 15.20.6111.020; Mon, 20 Feb 2023 13:24:51 +0000 Date: Mon, 20 Feb 2023 13:24:30 +0000 From: Szabolcs Nagy To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Richard Henderson , Jeff Law , Xi Ruoyao , Noah Goldstein Subject: Re: [PATCH v12 18/31] arm: Add string-fza.h Message-ID: References: <20230202181149.2181553-1-adhemerval.zanella@linaro.org> <20230202181149.2181553-19-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230202181149.2181553-19-adhemerval.zanella@linaro.org> X-ClientProxiedBy: SN4PR0501CA0105.namprd05.prod.outlook.com (2603:10b6:803:42::22) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|AS2PR08MB9896:EE_|AM7EUR03FT052:EE_|VI1PR08MB10050:EE_ X-MS-Office365-Filtering-Correlation-Id: ce99ccbd-772f-4789-a5e6-08db1345ddb6 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: d9WQLXmp3tdTFuogicehWvkLXtP+44aeuDfspcJwLrj2hARMwuYTAOJhKzIWuBNDu8u30uopH389WFM53hM6zgN7LsT3EdvBPXsy1L84uSmsxmMn1JZkb47Gxj8xvVGuxOPd6P3rOxDoLzCePDsSysFNtdjwa8BBz6KNn9geIsLtNxIzT5KBHrcLkFgsWiLD1jQl0iXrR/dBXHT7juRR0/FbaQ2NAlKcP0vhOnTZmiyjoRS6P6to3cufiRuUVW3QNV4fxSPY/jmsfHUTj5MNSzjfCrGsWqS2IEW805TKTifG2px4VAyZ9+lHGHeil/EzoZBF4ePGbns7bNPw3TLePfA/UwUfgIDpW7PR1mXNCPzT1/d6m4RDGiaRUUWdYznncm6iS0AYxkQUjel/coJBE1cQg/ugJ20YAgkRJ1JtCoOz2Ox50KUtkzxmaEMDoYH9r/3zYnF8KqXQwS+2hqAEzo1sf+Vl1z8/46lMYd8e1kWIPlwtyafcqhcpky7KXTNN4SrBT1mrUloNMBB3SUCTMBpjQSE/cPiRbep20dTyEOtROuYkLI6wRAs/o580gPEySVqt0u8DwUm1KVlK5SiZUh4tGGLMB+aiYBx/94F4mPbTvUV3OgLE8sh/t0fGhbypEYE4qXCz9HUWzyR/Wo3sqA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(376002)(136003)(396003)(346002)(366004)(451199018)(54906003)(316002)(66476007)(66556008)(8936002)(6916009)(41300700001)(8676002)(66946007)(4326008)(6666004)(6506007)(2616005)(26005)(6512007)(186003)(478600001)(6486002)(36756003)(2906002)(86362001)(44832011)(5660300002)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9896 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0fe42d10-3069-4989-eb90-08db1345d871 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zNJPt0mc+1m83MDQBirs0w4ncX2ZYehKTPNVseQY9OX+Rq7Jh1MP3JL/vh2U5nLyxNUbxFJ5GvWTzffzVrJvQKHwKkb0uh56Z3TcfPwWYFbscyB7JHHqYtFQ6wMFwmtRI56GMXpnMrwve0G9MZDsyFFhHEzhHun7H927trTYm0jGM/K/bQbFGiFJcOOgc/weaUjRQVqqRAm1z48mF4UVhbFnO+PbxLfEEHHJBqc/Up+bAZDdbN8zLTuD6wlIKPKwUtUn3LZQzYpW5qbCLhlJGxUTnRbZyZ48iYXfDMAKVMBCQumWqmMfGthlYvU4Ps6XIiBGne4w5ZWggchp8smxGCBmBeLXi1mAowbBSuTZJuvcG3JQqac0LSTc+zLu1aBdh8RNEWWrBpn0V5iRXNklfxtqzLnERpviQuq70a3FQjV4m23qAQ4D0j8vCaSAufDxPX0ux/ELtkHKSIpizfdLNyIGEAYOPkRNeqBpoZInUPzyER9/xzg6cePcuQyHsuqGGGP2YTwHBk+TDnza6TrkbaZE/u9XTGTDhollPVBCA0T0F+bfPDHc4v1HwYxVFxbJ6ImgBX3FRCuRbZr8g8PHtTnNg3qKtGnVhzEA2DfWT4V4MmRJYHp/fwbY4RjN18Hv4iJcj4/FCOQTCBoxDcr9ynn4TzayoTK6SR9IyqeLYD0= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(346002)(39850400004)(376002)(451199018)(36840700001)(46966006)(6666004)(6512007)(6506007)(40480700001)(107886003)(186003)(478600001)(26005)(356005)(82310400005)(82740400003)(47076005)(2616005)(316002)(336012)(70586007)(2906002)(70206006)(54906003)(5660300002)(86362001)(41300700001)(36860700001)(6862004)(8936002)(44832011)(8676002)(4326008)(81166007)(36756003)(6486002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2023 13:24:59.5838 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce99ccbd-772f-4789-a5e6-08db1345ddb6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB10050 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 02/02/2023 15:11, Adhemerval Zanella via Libc-alpha wrote: > From: Richard Henderson > > While arm has the more important string functions in assembly, > there are still a few generic routines used. > > Use the UQSUB8 insn for testing of zeros. > > Checked on armv7-linux-gnueabihf > Reviewed-by: Adhemerval Zanella > --- > sysdeps/arm/armv6t2/string-fza.h | 68 ++++++++++++++++++++++++++++++++ ... > +static __always_inline find_t > +find_zero_all (op_t x) > +{ > + /* Use unsigned saturated subtraction from 1 in each byte. > + That leaves 1 for every byte that was zero. */ > + op_t ones = repeat_bytes (0x01); > + return __builtin_arm_uqsub8 (ones, x); > +} __builtin_arm_uqsub8 is only available >=gcc-10 so now the build fails with gcc-9 ../sysdeps/arm/armv6t2/string-fza.h:36:10: error: implicit declaration of function β€˜__builtin_arm_uqsub8’; did you mean β€˜__builtin_arm_stc’? [-Werror=implicit-function-declaration] 36 | return __builtin_arm_uqsub8 (ones, x); so this code should be conditional on gcc version.