From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2082.outbound.protection.outlook.com [40.107.8.82]) by sourceware.org (Postfix) with ESMTPS id 357B83844746 for ; Mon, 20 Feb 2023 13:45:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 357B83844746 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZM3PcYh8JAp6ItiDwnq/a133j/Hg/NK4adBMUqiGin8=; b=JY0MyJ1ziOzS1BVyyibzDcp54KEv+SKS/QDNI01VPOHKXHxDLg/1WwZILUxEcXqyI6KG3HzTC+BUF+IeZD5QiYqmk4NpMeVI/OiPF6Yow4KAQP/UOiFJAvx1QjDqBDa5T1o1E3ar4ZIOKlPGD37Zen83i3GxUC3MD+Qk+B5qXS8= Received: from DUZPR01CA0237.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b5::20) by AS8PR08MB10002.eurprd08.prod.outlook.com (2603:10a6:20b:63b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.18; Mon, 20 Feb 2023 13:45:23 +0000 Received: from DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b5:cafe::3b) by DUZPR01CA0237.outlook.office365.com (2603:10a6:10:4b5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.19 via Frontend Transport; Mon, 20 Feb 2023 13:45:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT037.mail.protection.outlook.com (100.127.142.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.20 via Frontend Transport; Mon, 20 Feb 2023 13:45:23 +0000 Received: ("Tessian outbound baf1b7a96f25:v132"); Mon, 20 Feb 2023 13:45:23 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 29e0808ebbfe2dc0 X-CR-MTA-TID: 64aa7808 Received: from d15fab56b963.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 24E412D3-9E63-4393-89B6-CC23845DF26D.1; Mon, 20 Feb 2023 13:45:17 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d15fab56b963.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 20 Feb 2023 13:45:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=drDm4m4zWaIF6ZInxlqwIzvmYbY7f5vIOnjx3Awr8KkLQQr1dutUVfcHlCWBj1dNoEFr3ng0tN8UyeL64FAoARGc2cRju4rE8mWBscs8dXBFdjvQwrl1Tcm3Gcnyvdo1Q02d2Chu7Ouh3850FJnnkTFL5LIgTCbu8gGE4HthfjpBPEm3+qNvFKt5mzxk89HHU9yeu4VIZLexTnmrMSBLIDIHXblqm1KpsZUI8yTJ6Ip+gqlj8stL/mU3/Mz1HW5YHYJC3YV9yWk1QDYlgsb1v35s4V33vYrbw0oHNNDR515f6Wy8XSM088SFjpIVkhjU8DWtdSkHadlSkKEN4yX1bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZM3PcYh8JAp6ItiDwnq/a133j/Hg/NK4adBMUqiGin8=; b=W9NbZ0f0e66tcHPv1m/GdTLffnswuMwctZwU5KktRmmV1Qr7V6W5VR9iD4G4uGbAKBVIq4OTmhdumQHbHJWniUxcPDme986PU2aauM3rIWwONEc1WowHOxEYstdRWI8IgI0RzIxtfT1j7A4CLQIlEOlFJXq7du7wKI9tegIU1GWHPWeNx4Ljb55A1trrWVxGNGftiDO3gjAa5iokZwnWxovtJiczbszryvnJ2PVivLdiQTm0cJO2oF9BlyTcfXkwubVih8cQOrEc1TSVWASMwnkEFHxXgsX6jgPJDkHnHlWumtXXmKnIjB8KWPFjkQ1OAka0B6qY07jvLwyNngJl4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZM3PcYh8JAp6ItiDwnq/a133j/Hg/NK4adBMUqiGin8=; b=JY0MyJ1ziOzS1BVyyibzDcp54KEv+SKS/QDNI01VPOHKXHxDLg/1WwZILUxEcXqyI6KG3HzTC+BUF+IeZD5QiYqmk4NpMeVI/OiPF6Yow4KAQP/UOiFJAvx1QjDqBDa5T1o1E3ar4ZIOKlPGD37Zen83i3GxUC3MD+Qk+B5qXS8= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by DBAPR08MB5670.eurprd08.prod.outlook.com (2603:10a6:10:1a6::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.17; Mon, 20 Feb 2023 13:45:16 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::29ca:64bc:9a10:b072]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::29ca:64bc:9a10:b072%7]) with mapi id 15.20.6111.020; Mon, 20 Feb 2023 13:45:15 +0000 Date: Mon, 20 Feb 2023 13:45:02 +0000 From: Szabolcs Nagy To: Adhemerval Zanella , libc-alpha@sourceware.org, Richard Henderson , Jeff Law , Xi Ruoyao , Noah Goldstein Subject: Re: [PATCH v12 18/31] arm: Add string-fza.h Message-ID: References: <20230202181149.2181553-1-adhemerval.zanella@linaro.org> <20230202181149.2181553-19-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0407.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::35) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|DBAPR08MB5670:EE_|DBAEUR03FT037:EE_|AS8PR08MB10002:EE_ X-MS-Office365-Filtering-Correlation-Id: c28145a1-d26f-4bdc-bca7-08db1348b748 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IfCovJgTjRekKZN1hrPNN57vt+nRY3vD0fxjaFFD3s9zmMJqlDpWayOeRb9n0BgCQYcBBdqtzqNqNdGXnP7YynyZdMqhhPc8voUTWKGsggAkSRdZFwZjwJOFu6y7B1TGc2M6Eu3sOUtNobwm8kELzFm/sNXQEq3IEbGLd64gOdrql3xE9U7X8ucD8hoVUdM6EnjoklN8VJAfYXht+UhNRm4koYqmknBXThYHyF6MW8osCJ+VthkX8HiHPam66dW63F0JrVvIH65j7PhWGNbRS3VNgldMt9/xf8bLZeXOtxCSs30UtiGkricKde3BB7/ppmR69ta8Hdfqhli4esuvw+rZipvIApA1hxbfO0N7YZnaqOKS8xs5AM76LPObYdKYQCPCR7cgc/tgNMYFx0U6p9LeEqOnCn1I3PP958MHk6zn3Xx2gQwDoWcoV05hU7d13q2CADPGGjPMQgmnagf/xaIs33zy+dM5YMjxYDRRQpMBGu0cT0+hm7qKevQmY5RVide/9Q4HGaNU0fqGj/3iKRZLt6UdAFB8UEwp8qiB+D3SjJvhNmlBd/3ie+vWFsPjKJz+H2zBjoZW1fOia22OyhVzBoSpv+jALaq2zSOgcdgW3R4WrS2BxQbGCfh8aiq4jkzUkEQfqc8NxhD0912stQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(39860400002)(376002)(136003)(346002)(366004)(451199018)(66946007)(66476007)(4744005)(66556008)(41300700001)(5660300002)(44832011)(8936002)(86362001)(2906002)(38100700002)(8676002)(478600001)(6666004)(36756003)(186003)(6506007)(110136005)(6486002)(6512007)(316002)(2616005)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5670 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: eb58833f-8bcc-401b-e51f-08db1348b292 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HlZPiR75FN+XAtWSg0TKMybQx2jrVkoUkxJIi9EEFsUV25S+pXLUGabK6clGoze8O5dmpbO+4aBQE0JXOt8HJwnNH/xctf5faERZD2AG5Blpumgyx+Lnc38QuGhcd9P1KNxs98xXqr9p9dzd138DhaLFg/dB2cb64JX/CgwPOEmpGz1tsbc9+/d13TfwyXV6Q0ceo1ZjAznAwc6L38DiiM5xQdRCJ/h1rWcrM7wqHCPecsVPt/x9LaMgWrb2KE0lNCFzdefTs+UNIXTwGcjTiI52WliTZ8J2TRgDbp/5Z3tKs/4wEDEeiDE3Ev/vUUpZ28NW2kyT0AJzuzcOTz7OpmuVsNvsnqb1wVXziyFT72eGXITLOP90cZWYTLTIiCbtHeDQ/pvwyPcCGxnRUM16AdIIGnvE6ZIDXr9f006xvnQPETOazVvBl2KSD27zp5XtkyJziX5c1SHW1W6EMgvl+nZTzAH2QGCiRb0cRxyT8efsRV7zmEtTW/vyOY95KVtrLbd90vS1xo+lHVCZ8Eubyp3avUP9izq6MN1DVBPI28U1zF8rVkDYnr9+auae8usm+HLuzotY4YmA2NIeiqlrv78e29DR1euB5bIEoPgtQOw4BHSIDQNcgMZ4QZztAoERop3kOUl+AzkiOQsPukKtps1grWZAMXulF3iahGcXkksSWFDCOgWjqXBsEZn0MZtk8IHc32GRlj+kASrJwd1N6w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(396003)(39860400002)(136003)(346002)(376002)(451199018)(36840700001)(46966006)(40470700004)(336012)(47076005)(36860700001)(40480700001)(2906002)(44832011)(4744005)(82310400005)(6666004)(6486002)(26005)(6512007)(186003)(6506007)(2616005)(86362001)(82740400003)(81166007)(40460700003)(356005)(70586007)(478600001)(8936002)(41300700001)(8676002)(5660300002)(316002)(36756003)(70206006)(110136005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2023 13:45:23.6627 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c28145a1-d26f-4bdc-bca7-08db1348b748 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10002 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 02/20/2023 13:24, Szabolcs Nagy via Libc-alpha wrote: > The 02/02/2023 15:11, Adhemerval Zanella via Libc-alpha wrote: > > +static __always_inline find_t > > +find_zero_all (op_t x) > > +{ > > + /* Use unsigned saturated subtraction from 1 in each byte. > > + That leaves 1 for every byte that was zero. */ > > + op_t ones = repeat_bytes (0x01); > > + return __builtin_arm_uqsub8 (ones, x); > > +} > > __builtin_arm_uqsub8 is only available >=gcc-10 > > so now the build fails with gcc-9 > > ../sysdeps/arm/armv6t2/string-fza.h:36:10: error: implicit declaration of function β€˜__builtin_arm_uqsub8’; did you mean β€˜__builtin_arm_stc’? [-Werror=implicit-function-declaration] > 36 | return __builtin_arm_uqsub8 (ones, x); > > so this code should be conditional on gcc version. > i think asm ("uqsub8 %0, %0, %1" : "+r" (ones) : "r" (x)); should be a good fallback (untested).