From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hall.aurel32.net (hall.aurel32.net [IPv6:2001:bc8:30d7:100::1]) by sourceware.org (Postfix) with ESMTPS id 258203858D1E for ; Sun, 9 Oct 2022 22:09:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 258203858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=aurel32.net Authentication-Results: sourceware.org; spf=none smtp.mailfrom=aurel32.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Content-Transfer-Encoding:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=YHLikFSBqMk435yshZD7XWb0GETeIkGRb66ARSSW46I=; b=iPk7mAh2erSlvpP4yp4KG+dv1q 7dPGXYcjiqpTO+Vwkvv2weYSQtKqAUeFQ+D3aRPweEUbBx3ccbYeFHmPxj8455nGd03dBD8oRfquC GCkylkb8zWiyuZVOYkaZUqSH8YaIwtVRJsHNxK9lGF3LR+aQ2nDS/wX2AIxUxPdw11RdFfrXwdTJ8 zx05abg/msKx5UDlLzqIpKxjo0kSQsAXsQimolXiMkX5fjKFsgLdQg466Fc/1FJn31q9bRMpr409J LxVZMl8uL4t04SuZqIZdrXDosBKsm6EImHxI4IrVxsgzE7L18W67yKBTyhBDoiTWDhAE/Siq/mdMC OY4xuAEA==; Received: from [2a01:e34:ec5d:a741:8a4c:7c4e:dc4c:1787] (helo=ohm.rr44.fr) by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oheUe-002w7l-Ot; Mon, 10 Oct 2022 00:09:56 +0200 Received: from aurel32 by ohm.rr44.fr with local (Exim 4.96) (envelope-from ) id 1oheUe-00Fam7-1B; Mon, 10 Oct 2022 00:09:56 +0200 Date: Mon, 10 Oct 2022 00:09:56 +0200 From: Aurelien Jarno To: Michael Hudson-Doyle Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] Fix BZ #29463 in the ibm128 implementation of y1l too Message-ID: Mail-Followup-To: Michael Hudson-Doyle , libc-alpha@sourceware.org References: <20220822020504.138206-1-michael.hudson@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220822020504.138206-1-michael.hudson@canonical.com> User-Agent: Mutt/2.2.7 (2022-08-07) X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-08-22 14:05, Michael Hudson-Doyle via Libc-alpha wrote: > --- > sysdeps/ieee754/ldbl-128ibm/e_j1l.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sysdeps/ieee754/ldbl-128ibm/e_j1l.c b/sysdeps/ieee754/ldbl-128ibm/e_j1l.c > index f85ba94466..0a5fe68342 100644 > --- a/sysdeps/ieee754/ldbl-128ibm/e_j1l.c > +++ b/sysdeps/ieee754/ldbl-128ibm/e_j1l.c > @@ -792,10 +792,13 @@ __ieee754_y1l (long double x) > { > /* 0 <= x <= 2 */ > SET_RESTORE_ROUNDL (FE_TONEAREST); > + xx = math_opt_barrier (xx); > + x = math_opt_barrier (x); > z = xx * xx; > p = xx * neval (z, Y0_2N, NY0_2N) / deval (z, Y0_2D, NY0_2D); > p = -TWOOPI / xx + p; > p = TWOOPI * __ieee754_logl (x) * __ieee754_j1l (x) + p; > + math_force_eval (p); > return p; > } > Tested-by: Aurelien Jarno Reviewed-by: Aurelien Jarno Small nitpick, you might want a similar commit message than for the ldbl-128, especially now that they will be far from another in the git log. Note however that for that one the issue is reproducible with GCC 12 even in -O2. -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net