From: Aurelien Jarno <aurelien@aurel32.net>
To: libc-alpha@sourceware.org
Cc: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>,
Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH v3] Avoid undefined behaviour in ibm128 implementation of llroundl (BZ #29488)
Date: Sat, 22 Oct 2022 12:14:55 +0200 [thread overview]
Message-ID: <Y1PCn56J+HjaVkZv@aurel32.net> (raw)
In-Reply-To: <20221010060050.3741173-1-aurelien@aurel32.net>
Ping. Tulio (as powerpc machine maintainer) or Joseph (as math component
maintainer), could you please have a look at this patch?
On 2022-10-10 08:00, Aurelien Jarno wrote:
> Detecting an overflow edge case depended on signed overflow of a long
> long. Replace the additions and the overflow checks by
> __builtin_add_overflow().
> ---
> sysdeps/ieee754/ldbl-128ibm/s_llroundl.c | 21 +++++++++------------
> 1 file changed, 9 insertions(+), 12 deletions(-)
>
> This patch is based on the original patch from Michael Hudson-Doyle,
> using __builtin_add_overflow() as suggested by Florian Weimer
>
> It passes all tests on ppc64el with gcc 12 with both -O2 and -O3.
>
> diff --git a/sysdeps/ieee754/ldbl-128ibm/s_llroundl.c b/sysdeps/ieee754/ldbl-128ibm/s_llroundl.c
> index d85154e73a..d8c0de1faf 100644
> --- a/sysdeps/ieee754/ldbl-128ibm/s_llroundl.c
> +++ b/sysdeps/ieee754/ldbl-128ibm/s_llroundl.c
> @@ -66,38 +66,35 @@ __llroundl (long double x)
> /* Peg at max/min values, assuming that the above conversions do so.
> Strictly speaking, we can return anything for values that overflow,
> but this is more useful. */
> - res = hi + lo;
> -
> - /* This is just sign(hi) == sign(lo) && sign(res) != sign(hi). */
> - if (__glibc_unlikely (((~(hi ^ lo) & (res ^ hi)) < 0)))
> + if (__glibc_unlikely (__builtin_add_overflow (hi, lo, &res)))
> goto overflow;
>
> xh -= lo;
> ldbl_canonicalize (&xh, &xl);
>
> - hi = res;
> if (xh > 0.5)
> {
> - res += 1;
> + if (__glibc_unlikely (__builtin_add_overflow (res, 1, &res)))
> + goto overflow;
> }
> else if (xh == 0.5)
> {
> if (xl > 0.0 || (xl == 0.0 && res >= 0))
> - res += 1;
> + if (__glibc_unlikely (__builtin_add_overflow (res, 1, &res)))
> + goto overflow;
> }
> else if (-xh > 0.5)
> {
> - res -= 1;
> + if (__glibc_unlikely (__builtin_add_overflow (res, -1, &res)))
> + goto overflow;
> }
> else if (-xh == 0.5)
> {
> if (xl < 0.0 || (xl == 0.0 && res <= 0))
> - res -= 1;
> + if (__glibc_unlikely (__builtin_add_overflow (res, -1, &res)))
> + goto overflow;
> }
>
> - if (__glibc_unlikely (((~(hi ^ (res - hi)) & (res ^ hi)) < 0)))
> - goto overflow;
> -
> return res;
> }
> else
> --
> 2.35.1
>
>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2022-10-22 10:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 6:00 Aurelien Jarno
2022-10-10 21:48 ` Michael Hudson-Doyle
2022-10-22 10:14 ` Aurelien Jarno [this message]
2022-10-24 13:55 ` Tulio Magno Quites Machado Filho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1PCn56J+HjaVkZv@aurel32.net \
--to=aurelien@aurel32.net \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=tuliom@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).