From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
Andrew Pinski <pinskia@gmail.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] aarch64: Use memcpy_simd as the default memcpy
Date: Tue, 25 Oct 2022 13:55:28 +0100 [thread overview]
Message-ID: <Y1fcwHwVnFVtzMLX@arm.com> (raw)
In-Reply-To: <AS4PR08MB79012199C16469C388D87124832B9@AS4PR08MB7901.eurprd08.prod.outlook.com>
The 10/19/2022 12:31, Wilco Dijkstra via Libc-alpha wrote:
> Hi Adhemerval,
>
> On 13/10/22 09:28, Wilco Dijkstra via Libc-alpha wrote:
> > Hi Andrew,
> >
> >> This changes how neoverse-n2 is handled, is that expected?
> >> That is neoverse-n2 was returning __memcpy_simd before and now will be
> >> returning __memcpy_sve as n2 has SVE.
> >
> > Yes, the SVE memcpy can be used by any CPU that supports SVE. Having this
> > as a general rule is better than special casing every CPU.
>
> > Maybe move this change to a different patch?
>
> That if statement made no sense after the change, so I removed it altogether. Either
> way, it doesn't seem large or important enough to warrant a separate patch. I could
> add a note in the commit log, eg:
>
> Since __memcpy_simd is the fastest memcpy on almost all cores, use it by default.
> If SVE is available, a SVE memcpy will be used by default (including Neoverse N2).
the patch is OK to commit with this note.
thanks.
prev parent reply other threads:[~2022-10-25 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 15:19 Wilco Dijkstra
2022-10-12 19:12 ` Andrew Pinski
2022-10-13 12:28 ` Wilco Dijkstra
2022-10-13 12:30 ` Adhemerval Zanella Netto
2022-10-19 12:31 ` Wilco Dijkstra
2022-10-25 12:55 ` Szabolcs Nagy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1fcwHwVnFVtzMLX@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).