From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2047.outbound.protection.outlook.com [40.107.104.47]) by sourceware.org (Postfix) with ESMTPS id A92953854151 for ; Fri, 28 Oct 2022 12:23:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A92953854151 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nuIheWQdpgCT9/9W4XfszIsvC310km5iBOIF4+425DAiXAdplq46AdqnZ2B32FysSkt9ze9meaUsX6VUmR0b7tDaH2OLRLyfzaewMsZVndrYBRlOdVFdZoWDyL9ESFkInq6FUlCWYh7ZfCjS7GBRX42nY3XCziaAn3zUuPlhzbarH9+HZFLGniHUl1kCMVasfwwf8JTUsvKIxMGAZx6NRUbCevhuEWE6HqzQlNqnqrHwGZBDNRBlG6TLNdHGWDfj3Iw9k7QHu4Hks1LDihztfFf4WhpnW+EuWur0HXwDm/Nji8lXDD2010F7Xy6k/ojf99NF+GG353+ssx7W7v+twA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IvYAzct/P9IKrT69FHfswZjlxNV7D9TzMAxTbk6qJYU=; b=KvKaAGFIuIIbD0FDSZnGr8NsBz5M9mtx/uhGBHITvq2O+i6onThSp3QO6Qj7E/5YhvtVVeAwawDhmRzhEVnFha1zqx5KSuE4sNrIy4qC9FxNyirQ5I0bukfgkBg1vQKmTEJaFt0F+PaYZUhTaG+mYFXVAv72pD4dMj8wV4JEh6Vde0D4HbjL7GVPVFUaIbga7LFX1QvsaquL8XkGm4jmOrjkFX/UkG9ZrLzk5jM1LIEN1g/I1WaMgE/pXmSTmL9TTdSabaWge/qxBINt2NQNcCvA2Bg4gmajJVbRoIl1meX8RoMBjHL7nuyr+jHUyaHVYBZAGwRVP+G9miZe69mE2g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IvYAzct/P9IKrT69FHfswZjlxNV7D9TzMAxTbk6qJYU=; b=gHyiP/0arxzwkNXd2bnf3SIbrWTVrCyO3N/7tajYKsTp5d4Uyo1aZ8JokpctRSG+rhvg0D8cC3s055QFDUno721joxBX/pgxxueh+u3lsetPpptpwx4CW5WiVxzSy+AdyaMIJyGWB9g+b8m+ucDYWnecQC3XQpggJZNI1QrjyRE= Received: from DB8PR06CA0063.eurprd06.prod.outlook.com (2603:10a6:10:120::37) by AS2PR08MB8504.eurprd08.prod.outlook.com (2603:10a6:20b:55f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14; Fri, 28 Oct 2022 12:23:32 +0000 Received: from DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:120:cafe::18) by DB8PR06CA0063.outlook.office365.com (2603:10a6:10:120::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14 via Frontend Transport; Fri, 28 Oct 2022 12:23:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT007.mail.protection.outlook.com (100.127.142.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14 via Frontend Transport; Fri, 28 Oct 2022 12:23:32 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Fri, 28 Oct 2022 12:23:32 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a862a1cc0ae3de02 X-CR-MTA-TID: 64aa7808 Received: from 853ec9d35967.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9F1106F1-8DD6-4267-A54A-CCC034F5710C.1; Fri, 28 Oct 2022 12:23:25 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 853ec9d35967.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 28 Oct 2022 12:23:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HIQG8xW0xqvykMuqNT/4PFLuhU1iWo8WmWDCp9Dl4ZPtD2/MuaOEDQxIJhYwvahzsOmg4wR4iSIwG+k1TMD4jkW/ujqOokmIheNESVmsuVaABcKF8hOdEbkc622QN9cxF+G9Ht+TjH4cGJi3BRc53/GjHl4LzXeEBx1KzQvp8e5afqIgRiY7p/feYwjGTOkvGhrBNCYYGJv+ago3YjJ0unXY+QNLzomffu8Ss2aqnkSkLuBIVSubkO5E4EUQghknYAT1l23HebeCDZCibouKwsHgUjvVgo/owLb7r79zHn7SkdMzW2j8evuyxWB4PBerZzuA1H1h26WC8HSWgG/geg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IvYAzct/P9IKrT69FHfswZjlxNV7D9TzMAxTbk6qJYU=; b=Lt2aU8cE1c6uUIlXAx3TppRC5iA4Xh94dbWX0DIRy+PyezP7rGcqlacLLcPC7C81agzAjk4YzT9dAdFXuxXP4ivr7t5Yncj0NjkP4mSlwqYkMowvPkcRFM0/hql8qUm5XTvYqd7kqxdBp2GeIoynDytDXKol8pSWL5+9bsNLOH2m1pGRNMU/H5xPGWd5Ywa4g3zFtBf4JFjjvBq7d+5ummrYZPoQO11L3AXdLcjXsX4LX0m6S4im1eo5KHoERMGzTHYI821VIY3ZocWKjr5UrGzlJXW1n+So3TWhdb+3ls30BEUbIF9IQ9HAy14TqxqrfXtjTK6MEv6e0+bLs4Wl7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IvYAzct/P9IKrT69FHfswZjlxNV7D9TzMAxTbk6qJYU=; b=gHyiP/0arxzwkNXd2bnf3SIbrWTVrCyO3N/7tajYKsTp5d4Uyo1aZ8JokpctRSG+rhvg0D8cC3s055QFDUno721joxBX/pgxxueh+u3lsetPpptpwx4CW5WiVxzSy+AdyaMIJyGWB9g+b8m+ucDYWnecQC3XQpggJZNI1QrjyRE= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by DU0PR08MB9751.eurprd08.prod.outlook.com (2603:10a6:10:445::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct 2022 12:23:23 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::8999:7c8d:d088:d198]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::8999:7c8d:d088:d198%5]) with mapi id 15.20.5723.029; Fri, 28 Oct 2022 12:23:23 +0000 Date: Fri, 28 Oct 2022 13:23:07 +0100 From: Szabolcs Nagy To: Florian Weimer Cc: Szabolcs Nagy via Libc-alpha Subject: Re: [PATCH 16/20] Fix malloc/tst-scratch_buffer OOB access Message-ID: References: <87zgdgh5du.fsf@oldenburg.str.redhat.com> <87edusfan0.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87edusfan0.fsf@oldenburg.str.redhat.com> X-ClientProxiedBy: LO2P265CA0155.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::23) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|DU0PR08MB9751:EE_|DBAEUR03FT007:EE_|AS2PR08MB8504:EE_ X-MS-Office365-Filtering-Correlation-Id: 1106ddb8-ef73-41db-404e-08dab8df3a7b x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WEv8VrclPRkGz3LY6JK9FJ5sxOls4ciAa3k/HKN372sdjzVl77dM+j93Bz5MKGz+dHrNIldRfaCx8cE151xm+LNnCPJAOAIXLVqMGqfYvXnVMJpDkgWC2bIIwOmn2uC5bq3uwx9catk/acU0MdSZWTeTtN4WojkuGBEepnSUN22ISwdlZEykZr7MoKy+cKcL1nAmFEog78B5FNo5TJxSWK18yfcg25sBRVaTI46xynmRuoYaUl3TibLH6n2DIrOcpRL0pnPwIMNpek1IzsoEICATL4je06LWGmyEEWrcHLt2jBnMFYndQeZnoUUY+oSdPGG52wQsjDNLgyqVreHjOe/nQAWfHUkUm0M2yozV+rRGkQx+wUTwTfv1Y6wSCuy/idXnq8QiGrsn6i9gaNrhPaunZk5PXMEBfL+RVg9gDK3TYDnXLcx1XsHCb5w7vic51LMAvYSftcOEUv6NBECeQ1eZuNaet9kshz+t6fRvXJ9rbEV31xKsndPNk7ERe5h7+6z/beLQQXk1efFfKvZbUNzokCDOgcmP5j809UwdNl0OUZBNmOJPusiPA0T6bsTzprzBQjQ2XCH2WUUgpgZ8A+211r8AYjWGTyZjklPhS4H3J2ON19/ubMQGbCwm/XzrolPFqhQNETfirVKGLa7dDoKcnXX/XDpUl+eb2YWx85WKx4Z893YJ4+9dvydFLfmY X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(396003)(366004)(136003)(451199015)(36756003)(4744005)(44832011)(5660300002)(2906002)(38100700002)(86362001)(2616005)(26005)(6512007)(186003)(6666004)(6486002)(478600001)(316002)(6916009)(41300700001)(6506007)(8936002)(4326008)(8676002)(66476007)(66556008)(66946007);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9751 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1bb182cc-ae78-4164-dee1-08dab8df34ae X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ymTuSCRslZ6zaW45ifGrwEjJaLhGuYxNTorQ8++k2Wvz0HG53JYRddheuPBGjyJgX5uv0EtO8SsXhYtR6r654zvyoWO9H3HIH00KEmgvgfjpaiMRU59c8KhKjlQ+v2Tc9PdLygpyKNfkmflECRdB3tuYLaH3C+3wF5EDDUwn97Mcwbns0rbcZ18o7ZYaNRTHeE44arLDFbuxagIjnBTet+CEQcaXWYnna/HX92z8GQZELxqg+mt7wRHXwWFJAx7qF+TnQHUvi/k2LnfH+stGVcwb7TS5cUIDVSbaQDEZsiDK/XgKnrEvCJQwA0t71fdUIJkpgodQIPLnWP5N+WCZWN0ihpxTQEALehSAaNzCkebJkLqVzNBpRoe6nlUirqfepY8/wb4Fwkflu1fZ3i79Wge42xiekq1HEW6vOLgxRc962M9ppOSd85cjWd/Qpdd51F1F4vZ7cr/vpeStU4OTsnDKuuoJf/Ot/dLjlIyoFQN4+/F/hC0PADCoc4WIUTHiV0Bp91utA5igLjUM5rAJQji1s0Lnm1L7RN6YoL3T97hQqd2sItx8nOHCQ68C5REEUu0wdC29nRxCAovxh1Cg4hK8dIdQOw/iQz6Bxay3Om466CT3UUSNUoupukXC2uf0SBrvvV18bg5vHjifPDYdSlA6Bp1QO6RMSasf7YffjDDPlTDNfNBBjmN/y7jIUEX1EUYW+lbs/7G10CVNfZHkUgDSGBnOmjhg7RwDtlcba4u6lEXhBN7P7+NPapqr0NdxzFbgrKVXkNr+qI1LD5Rlog== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(346002)(136003)(451199015)(46966006)(36840700001)(40470700004)(47076005)(6512007)(41300700001)(356005)(81166007)(86362001)(36860700001)(82740400003)(4744005)(2906002)(5660300002)(8676002)(70206006)(4326008)(70586007)(82310400005)(6862004)(44832011)(6506007)(40460700003)(6666004)(8936002)(2616005)(186003)(336012)(26005)(478600001)(316002)(6486002)(40480700001)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 12:23:32.4563 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1106ddb8-ef73-41db-404e-08dab8df3a7b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8504 X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 10/28/2022 13:30, Florian Weimer via Libc-alpha wrote: > * Szabolcs Nagy: > > >> I think we should keep the test loop, but create a new scratch buffer on > >> each iteration. > > > > given the documentation of scratch_buffer_dupfree > > i don't see how the test supposed to work with > > sizes > buf.length or what's the point of this loop. > > Hmph. Let's just remove it. It's unused anyway. Should I send a > patch, or do you want to do it? i think my original patch makes sense that at least has one scratch_buffer_dupfree test. or do you prefer to remove this bit completely?