From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hall.aurel32.net (hall.aurel32.net [IPv6:2001:bc8:30d7:100::1]) by sourceware.org (Postfix) with ESMTPS id DDBD8385801C for ; Mon, 31 Oct 2022 22:20:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DDBD8385801C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=aurel32.net Authentication-Results: sourceware.org; spf=none smtp.mailfrom=aurel32.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Content-Transfer-Encoding:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=3adxQJPgkOmhAX3hDs8tzRM9BG9sKO8oXhthR7RblNg=; b=Ui1OHugS8ZWpG0stXiF/mlX21w mM/BbXVJMIBD/ob+Zto5kmxzwzkilutM25n0k88/Qzw5XyIRjMmUvJgSePH2exoW+JmRKsTzVl9cr n8exh8xoSVyyb7fm0HZyIky4AyC1AvpSNdRlkDKFxZ63z+Delfghh/JPehxDw9uK3dWzaNdSL58O7 n3/GTCPOI5Sj1O3yXL8mmnFiYSFfUJ6V18F8/Koj6oPbq6UnepBNdQuZR7zPyGB2eJh/hRtHGlyoZ XkSrPtQbCbazj15NY8n+5cYDZccRdcdQJdUettIWbF6Q+RAB3+Ll2POJ15EBObNe6VjvOOZY2QWLt HSZe40kw==; Received: from [2a01:e34:ec5d:a741:8a4c:7c4e:dc4c:1787] (helo=ohm.rr44.fr) by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1opd8w-001kl4-Vd; Mon, 31 Oct 2022 23:20:30 +0100 Received: from aurel32 by ohm.rr44.fr with local (Exim 4.96) (envelope-from ) id 1opd8w-006ECX-0T; Mon, 31 Oct 2022 23:20:30 +0100 Date: Mon, 31 Oct 2022 23:20:30 +0100 From: Aurelien Jarno To: Adhemerval Zanella Netto Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] linux: Fix fstatat with !XSTAT_IS_XSTAT64 and __TIMESIZE=64 (BZ #29730) Message-ID: Mail-Followup-To: Adhemerval Zanella Netto , libc-alpha@sourceware.org References: <20221028205440.1091298-1-aurelien@aurel32.net> <85bbb5fa-735e-254e-4467-e2726fd0ecc3@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.7 (2022-08-07) X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-10-31 14:25, Adhemerval Zanella Netto via Libc-alpha wrote: > > > On 31/10/22 13:03, Adhemerval Zanella Netto wrote: > > > > > > On 28/10/22 17:54, Aurelien Jarno wrote: > >> Commit 6e8a0aac2f883 ("time: Fix overflow itimer tests on 32-bit > >> systems") changed in_time_t_range to assume a 32-bit time_t. Therefore > >> stop calling it from __fstatat for systems with 64-bit time_t. > >> > >> Resolves: BZ #29730 > > > > Although this change is not incorrect, I think the fix I just sent [1] is > > slight better because it just alias non-LFS stat to LFS stat for mips > > (which is also a small runtime and code optimization), while avoiding > > touching generic code (so we need to check if trigger another issue on > > different architecture). > > > > [1] https://sourceware.org/pipermail/libc-alpha/2022-October/143089.html > > So I was wrong that we can assume stat and stat64 are equal on mips. Maybe > instead of adding the fix on stat we can make it more generic and move it > to is_time_t_range (so it can potentially fix usage not only on stat code) > as my comment on https://sourceware.org/bugzilla/show_bug.cgi?id=29730 ? Yes, we can move it to is_time_t_range, but then it gets trickier to get the condition. Your comment in BZ #29730 uses TIME64_NON_DEFAULT, but it is not defined for OpenRISC, so it means it will cast to time_t. However this has been explicitly changed that way in commit 6e8a0aac2f883 to unbreak OpenRISC. We probably want a condition that is "kernel ABI uses 32-bit time_t". Do we have something like that already defined? -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net