From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2081.outbound.protection.outlook.com [40.107.21.81]) by sourceware.org (Postfix) with ESMTPS id 8525D3857C69 for ; Thu, 3 Nov 2022 14:02:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8525D3857C69 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=jbuLTY7JBsw3iDgQcSTdPcfJU6Ks0CZp/iTJ14UIpcygmpzQNEwc7UZM8Na3e/dMlz613/eAaMgPR95nBB5IRbqvs5w6AD8THJICaUCwI3JTkqvophfrK38gILzQOwd/guTd0wkB+afQMbQzOCIk7+/bTo5hBnsSB6/fOct2wC+WB0IYX1zoiQszMfp95s61RFNlhw7Sjd+8UW95fGuAxuD/TbFJPJXlF91dTmuEf1ttTKjF9Ken/q2aZXm1TxRfas2D8R4/U//zXoKV7tYEPNUpx4pZw6WHEn8NCp5tWHHpNLLe01btaw44NGByi53ugxVEwOPsDcv0jsn0/Nqa8w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LcBTa0TGy1hiL52TKPxQd11LWINpYjLTuJ1HoCfVxEI=; b=M4X5YnwhcWRIrP7YaWPqtsFIMz1jHNVkuzrUZI+t1OlGATyzx3B5FvV6PvVuliMXkl1g76f4l0+E/EInQv24kBDTxQfb1tUdHjAoZ8qrKx+Iry0n8l0G6cKVnv0JH3WYpwq70kZZoXbT7zjzA9EH9DYH+oYTV/cL+3FVJ8+3nqZFwhMBDEEkU9mDoLrWdKE0szpzkIbuFEUD4ZDLJhxyiTUsOxrqkGJoDT2fLQh3h39dnBIWCUJnnpag6Ax1AhcMa7AFGOnNSuaB7lztjsjp/By7yaKHsjEdZegISQ+jbKC3fOd2HF9z7W8DX++lOaPt7fdoJCvXJhnFCQZ7g9ZjAg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LcBTa0TGy1hiL52TKPxQd11LWINpYjLTuJ1HoCfVxEI=; b=5OK3uRo62M2W/Alsjkfe6TMx0XZGip2+crigrBnP5WSEbhHMK5AKvtxrpl7LZVWcVv3CQqBHNJvZl2co42nzb+YiUS42IfB1xEpVa1mPzspCI9pqqnv3BdTSe0d/tB51AN8hDjx2dK8rVRe8u9UdKbh+y7wfKFTG0HATTlViTNE= Received: from AM5PR0701CA0052.eurprd07.prod.outlook.com (2603:10a6:203:2::14) by AS8PR08MB9118.eurprd08.prod.outlook.com (2603:10a6:20b:5b6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 3 Nov 2022 14:02:16 +0000 Received: from AM7EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::2b) by AM5PR0701CA0052.outlook.office365.com (2603:10a6:203:2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.19 via Frontend Transport; Thu, 3 Nov 2022 14:02:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT024.mail.protection.outlook.com (100.127.140.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Thu, 3 Nov 2022 14:02:15 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Thu, 03 Nov 2022 14:02:15 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 5c9ff9f3305fc911 X-CR-MTA-TID: 64aa7808 Received: from f2b21e744838.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 60AFF659-719D-4932-8206-B448C524BB4D.1; Thu, 03 Nov 2022 14:02:08 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f2b21e744838.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Nov 2022 14:02:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SWJL+bSSqY4ZvOfLGJLeEHlGMoKsLJ+1Z5PM6ZlU8NEj8EG45a3GPX7A9Mh9uFZdb9/d2IbwfUZvIzw51QsHX8DIsAfKh33nVAMQsVhuAGscUNDX/X6xeLedvbFvXtXkBF1Wc82TTLAhA09OFHGtkP/PmWHXKDGPiUGDpKdR/2FsRfR4/gC6xTwrPKfESBjzuv4pugtEhzpd3WhvNLxweUVkTgykZE/5th4aL9mvce2iFu6H3ai8GNfWxGuFja2cO+bXQYbw9SW4/C1T0STLCRfl2C5yi4uUWXMy7VXzW3ylIOE5kDkNPp4vNJbm1HrsKkb79+GfOUPauPoZPP6ZiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LcBTa0TGy1hiL52TKPxQd11LWINpYjLTuJ1HoCfVxEI=; b=EeC0sg/Chfr6o5AA1Fj0J3dvlvGX0lSRTnDJiEZiv8cH1URT3pdYnma85EJws0sDC18EXPIoCi4Vhtph9mMZ8USaU9Tf2mZgTtEpsE130b/K5gIDSnoBWdvMMH6hMGAcNHC3iAozQneHZbNiK+rPor+sbZOSsICvqXcQK3pVum2tTOtS1iHP2OKkdNJpTtgueqK5+44s3DGEUGB864eGy5NY5q8KQUr2vcdaN4/tgY5bOESWSRf0Y/iSYoyczGrrRiw3RkS1gNLtIuEYijg5WrJLvQNAJHnuR68v0NQag8X8zIm3kX+oFgX/eqjN+DBOsmYuoNGacHcxIVq+qwp4yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LcBTa0TGy1hiL52TKPxQd11LWINpYjLTuJ1HoCfVxEI=; b=5OK3uRo62M2W/Alsjkfe6TMx0XZGip2+crigrBnP5WSEbhHMK5AKvtxrpl7LZVWcVv3CQqBHNJvZl2co42nzb+YiUS42IfB1xEpVa1mPzspCI9pqqnv3BdTSe0d/tB51AN8hDjx2dK8rVRe8u9UdKbh+y7wfKFTG0HATTlViTNE= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by PR3PR08MB5868.eurprd08.prod.outlook.com (2603:10a6:102:81::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Thu, 3 Nov 2022 14:02:06 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::81ce:94a0:632d:7016]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::81ce:94a0:632d:7016%3]) with mapi id 15.20.5791.022; Thu, 3 Nov 2022 14:02:06 +0000 Date: Thu, 3 Nov 2022 14:01:52 +0000 From: Szabolcs Nagy To: Adhemerval Zanella Netto Cc: libc-alpha@sourceware.org, Christian Brauner Subject: Re: [PATCH v2 4/9] aarch64: Add the clone3 wrapper Message-ID: References: <20220930192613.3491147-1-adhemerval.zanella@linaro.org> <20220930192613.3491147-5-adhemerval.zanella@linaro.org> <1d4ce210-2b28-b061-9780-f643eaa80a27@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1d4ce210-2b28-b061-9780-f643eaa80a27@linaro.org> X-ClientProxiedBy: LO2P123CA0099.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::14) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|PR3PR08MB5868:EE_|AM7EUR03FT024:EE_|AS8PR08MB9118:EE_ X-MS-Office365-Filtering-Correlation-Id: a278e168-38aa-419f-4730-08dabda403a3 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fOuSRbDKN3jJJ6IgR+kC7gxxCDiQvDM2bucgiLJ/XRYMZN9ERaZLeyCDP2LX+rSJT8D2l9ElvEawVLrIRgGxrDGC0eTcXVyvC7K/NXCUtWVKfvm+bRcQ8RpboJbN/vzIXZX8Ka/oUH44AZ2y4D/ojxScMj0zGvXdnJy4W/Y1jf+VVra22/kp3564f3eRSus59h/p0WU2kRIKqo2xSjKLNRx3VoAu2HDB3kJB9unDnIVsQub4s27RDXTWjxUTR/35YqnAPhYEysNLuwYPhW0P6OiTz5yfKcS0f9bjlO4Rf0822s18cw+fh/sayVBb+ItTZO4rwA6ZSAkv3FmHLLIayGOoMuebyuv2Ol/dihruHuPh70w0M/6RlsGGXzj/FCfnSwFlU/uVfrouYtoQ42N9pisrsJn3CRQOobt9GtoA9p69mwR3hHqt/JzZKIOnJ6tjacKusfuRVb1nqXdSazRB2OjBJcx4MEDEzSDMrjmO9kP3xItGwEUAMUiK/fu/IvZ/HDjKYrMYxHwriRmvq1JhIS8KKQ7SDXldUwoanAKYRplbB0MhriWeLl5J5llcnjxW40FirJWPDfL4Zww5WCAGJF5cQae+FrcaJI6KdT98nwG6oQntxVnTn+m4cYj66GQT9seMkMI/3rYAfl9NWeNa6nPG58g7Zfy/bgjHoap41pLzUHfvVi9z3u+Hys/NgUE4RqxhxyJXIzBPz3WqK2d4oxTPrl0S9wG/conHc+Lnmx0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(376002)(136003)(39860400002)(396003)(451199015)(2906002)(86362001)(8676002)(5660300002)(38100700002)(44832011)(41300700001)(66556008)(8936002)(4326008)(66476007)(6506007)(6666004)(66946007)(6916009)(478600001)(186003)(6512007)(2616005)(316002)(26005)(966005)(53546011)(6486002)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5868 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c3afffd4-247a-4791-9a18-08dabda3fd8f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tqPVmGUpJtXk63pg6KHfW5q9DhjNUX2KgVeutOYzp0UJL5W6LUx29Lvks6o2DL78hA38V8kDVYDwTLIj7J6+hjzVu1nUWXmSUA5al3CEb1d60j68r0Lm6oM+sf8GYfh1XWjF0GCUvmyr3VvQuKgK7S52MqaVSFmhgfDxnSCObj1eTToufF65hsRcOK1oZIJNW3XGZiIaqkulYBydTOZbnd2YN/Yo6rGBzi9rXIk/geVbivwoePLiY483LJ/jUKhG53uMYWR91rNrRPeT6IIuzU4bpqKhvHn25ukuIMPw9zw770YMPLKhNH0MZH0sjWOAQS0daMQLVx2fYLrK8hgx2a898qDm26Ly4G1eLeyJlrteJTESd5BC95MpprQRdV7R820PcFE0XEPap7bQlxyFTbTeSPQlA+kRpzQtrRb199P8Wz15oANdWBIaEkAXCzvGsdH6+cvsNFEbQQ7Mh+xF8FfIUyCAoFW2/PKpw9AHi7JXv1/vhezoLCwUuHmT3/pZc+cbnjwn39jOqP05HrQQpgDi9ij8QwcbhlnU96IeSDh4BK/G6l4tNM4tP2gHzSZ/1a+TxpA0KuPJ6IJ+u5b+cPx6Ojdcdv1jvqrC5eHIToq64ckByXqWqr9ClnyQEt6MVF40nUlz1a3+Kb3sfX7I/qL5ULu5YrfFi2hg7lEgz5fYoRf4zc8G/qNTx+wLefI0Zzmbmco9bBB3BEEaHm5cHKyVVbOrLA60lDI8icMo/8B4aTXS2IN1ujVbL1Z7dXAO0KHncF77uVcVYjiR4LU3LL14nKWjyYMzMUJgQ0cPqXU= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(376002)(346002)(451199015)(36840700001)(46966006)(40470700004)(6506007)(26005)(6512007)(6666004)(107886003)(53546011)(2616005)(70586007)(70206006)(47076005)(478600001)(5660300002)(40460700003)(186003)(44832011)(336012)(966005)(8676002)(36756003)(4326008)(82740400003)(316002)(356005)(6486002)(81166007)(82310400005)(2906002)(40480700001)(8936002)(86362001)(41300700001)(6862004)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 14:02:15.8883 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a278e168-38aa-419f-4730-08dabda403a3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9118 X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 11/03/2022 10:15, Adhemerval Zanella Netto wrote: > On 02/11/22 09:12, Szabolcs Nagy wrote: > > The 09/30/2022 16:26, Adhemerval Zanella via Libc-alpha wrote: > >> It follow the internal signature: > >> > >> extern int clone3 (struct clone_args *__cl_args, size_t __size, > >> int (*__func) (void *__arg), void *__arg); > >> > >> And x86_64 semantics to return EINVAL if either cl_args or func > >> is NULL. The stack is 16-byte aligned prior executing func. > > > > "x86_64 semantics" sounds wrong: maybe this should be documented? > > i'd expect 0 cl_args/func to be UB like in most posix apis. > > Right, I think it is worth to document the function semantic > properly at least on its internal header (include/clone_internal.h). > H.J also added a new clone3.h headers, which is not currently installed > that I am inclined to just remove it from now. We might reinstate > if/when we decide to provide the clone3 as an ABI. > > And returning EINVAL for 0 cl_args/func aligns with our exported clone > interface, where EINVAL is also returned for 0 function argument. ok. > > > > and aligning sp in the child fails if signals are allowed there > > (pthreads does not allow signals now, direct callers might). > > i dont know if that's a concert (or if unaligned stack is > > something we should fix up in clone3). > > It was overlooked on initial x86_64 clone3 implementation as well. I > think it better to just return EINVAL for unaligned stacks and avoid > to change the stack pointer in the created thread. long time ago linux did that on aarch64, but it was removed: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e6d9a52543338603e25e71e0e4942f05dae0dd8a i think in clone3 the kernel should have aligned (it knows the bounds now), doing it in the userspace wrapper is weird (should we adjust the stack size?). and not doing it at all makes clone3 hard to use portably (user has to know target specific pcs requirements). not sure what's the best way forward.