From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150079.outbound.protection.outlook.com [40.107.15.79]) by sourceware.org (Postfix) with ESMTPS id 994E238582B2 for ; Mon, 7 Nov 2022 13:34:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 994E238582B2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=JnPvqIZEVF3y6ObpdRz08LFrusLL05cmEEwuOtEnT7Cq+hZW9NEQaOcM5ZuItA9H183WULPYjAKd+VFBAd/oHNBHDZGm+u1UsjuUcdAjyCakup0sr2Mu9MDCvGSKC5X83xMBPpv4X/ks/YY4SO42kKGilZ8elnL+l6K0eerIB5dd/wTFOd3FQdpKzpdrATvie8XCsLaMH/RDkL0IoV1AXfrs2xE72BuGDrFbkOowzFf71snQIztBs7+ZQBmz3+6q3TdTMo30XghYDGiaLTwXRlZauBg8wyodvqyoarHKatkqiiFAHByDgQ3YEO+AWSOW73YjooAq1cGsxFgOoQywfQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8AslIybpGZXt90fq0w6ch/+h+O/NMLUWw4NkHqDUCd4=; b=G2tnY/MAFd9A2ehwyN/rGgca6Oko2RDDWqv4pb8Hnbdl90EmTF59k09OdEdU7YK8CARojzOShqKJxKxf1BvXNbiEk2AzfkD7BxhR42Eho314t9cpvYX6F52cWF1REXYX0Bz6QhiXpWnKo4vTDNPckMN1tawpOEiLpMcldFMrIDvR3MwiI0atgNwNWI+QcExjMZJ/SVPMGS4FPT6kn0PWG8sGbkhTeBv8EUmNKZT/AKgBemelBasfiwXwr0Pj8XyOqwjbuh1KUIX9fvrFZ61hCil5MOvafUiyctW0PNTX7z3bGEIQYqtEvLqNMcY0Yjj/E1SDDu2toS4pi2GrzfUoMw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8AslIybpGZXt90fq0w6ch/+h+O/NMLUWw4NkHqDUCd4=; b=aDGns6JKQTeJPZ/g8AK5XoL/XUBBVzn95lMbmMKtU5tYJ2nmp/qm1XQzil+W3L631qN1eNPbDqEtYQxBFN478bTcU+YV74yCu8nwC6K2XMbxlgSmWyCZPLnIYOnL+W4yoVZnjAQHeFZxAd6ullk94y54Kf6d6/ovf6KhKQ6ykdE= Received: from AS9PR06CA0200.eurprd06.prod.outlook.com (2603:10a6:20b:45d::25) by AS8PR08MB8994.eurprd08.prod.outlook.com (2603:10a6:20b:5b3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 13:34:52 +0000 Received: from VI1EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45d:cafe::2d) by AS9PR06CA0200.outlook.office365.com (2603:10a6:20b:45d::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19 via Frontend Transport; Mon, 7 Nov 2022 13:34:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT012.mail.protection.outlook.com (100.127.145.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 13:34:52 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Mon, 07 Nov 2022 13:34:51 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6ce6f31fd48c2cab X-CR-MTA-TID: 64aa7808 Received: from 818781d1e5e1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B5F17F32-47B9-400F-8B42-DD06B2DFE0DA.1; Mon, 07 Nov 2022 13:34:44 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 818781d1e5e1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 07 Nov 2022 13:34:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R9/MsiXGMAdw4QU7SQ9TU31+JdSzcNLfxjk65I10eQA48ECEDd6YyxQ4Lzh4OAlKsPSTFcdY2pYLUH0qAfBChBoTD5ZX4YjEnucuP1ZfmuFD41alOvfgQmFGKJjJ0eskubBB2VnJCmE7wHRYu9Mwp1MDz9sKMlDAyzmB+lAudSdetGO9+YOdo76kv9fuj3yr2SmeW1fyxWB4spZLX8hIpoeDMSFNuXQB+T353nctj+R1znca/G5X0EFSNk8p6B24014E9DPHMbu0o3dc02LyZGvOiNbUOnh4rS+WBrbctFKs1/K2o5JPFD5h6rhkQMwEeTCvS7iIJLhuRZNst5z+7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8AslIybpGZXt90fq0w6ch/+h+O/NMLUWw4NkHqDUCd4=; b=JQ8G5xQY4TWGGPOw3lLE38W6Nyq/2j1JnMyWH9AyHvPRSw2tQh63R6GUhDi9m/YBeOur+v7LGkkaTpdRUzjLlAo+xWUn9HBND6BhNMH7fNW9gD2cWHff3x6AxZ5MT6dzE7q6KnMjhwJpbHt7A13cIpCoU74Sv+peS4pul7OQJOBLf6b9WCER9fYQiSgaP+yYtw49qp4iMeQFOcXDEjOtIzHIoHoeG3L949NhRoga9TyZ651rr7qTm5eSpYOtn/4LAFc2a9wFGIMS1MaFSZktGe3aPSCeQbIvMFvbCZpfOH5oyVhkB+MfMcBVOY2+yYGq4iCkA7GXSZl8eOpKbdQO4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8AslIybpGZXt90fq0w6ch/+h+O/NMLUWw4NkHqDUCd4=; b=aDGns6JKQTeJPZ/g8AK5XoL/XUBBVzn95lMbmMKtU5tYJ2nmp/qm1XQzil+W3L631qN1eNPbDqEtYQxBFN478bTcU+YV74yCu8nwC6K2XMbxlgSmWyCZPLnIYOnL+W4yoVZnjAQHeFZxAd6ullk94y54Kf6d6/ovf6KhKQ6ykdE= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by PAXPR08MB6736.eurprd08.prod.outlook.com (2603:10a6:102:13e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 13:34:42 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::81ce:94a0:632d:7016]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::81ce:94a0:632d:7016%3]) with mapi id 15.20.5813.011; Mon, 7 Nov 2022 13:34:42 +0000 Date: Mon, 7 Nov 2022 13:34:28 +0000 From: Szabolcs Nagy To: Xiaoming Ni Cc: , , , Subject: Re: [PATCH] elf/tlsdeschtab.h: Add the Malloc return value check in _dl_make_tlsdesc_dynamic() Message-ID: References: <20221104093000.25169-1-nixiaoming@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO3P265CA0008.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::13) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|PAXPR08MB6736:EE_|VI1EUR03FT012:EE_|AS8PR08MB8994:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c49f947-38e8-4311-9ea5-08dac0c4d980 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: v219ifJ/ZTIpNMrKcB/ux5MS1M52mr7Q8+USNS5t4Hr06BJg4Q1vNd8sqVNYGHy+qd5j2uRPrKi9gfHkUNyHZCduF6n5nD/3qPe9VljX/xC6mUhBOyAZf07wiGDSrH47rGk0QH2lwiE8YGtzxukW6sqpLFX1m86fu6+3vZYpTpOibDZIyOfkm5zwiA5jYsd1JGkyNUEUZb8s+DfodwdKy0Iyf+WDvJfhUMTyxfmDpZwPnCU/ZiSljVe7d3BdTnOnlq3i7xDmF59wHVCdudfnyyeCazzK4M01qFq34os6K3jjTLyX/snbDYBT2mvOZ5S8CRoVok5IkTBiDFMJNxi6bfkhZLCQyYlH8R6fcIiK8/wd1JU/4g3DKrU3wYjVmRxfy571B7As4iBneMshU2UHhWOeU7jha3YfUGDeW50r+D++g/sy+p3zNRnYLSL6SUedl2zPmLtFjEWq0o2gMS7w6Uk+PIHXZzuzrM1aRo7hodow4wpGSRWBIbv5XUntDtI8DbENcUDF2Xmiphb5saxKoQIw5fbFCV7mCL9ZfGrzuoTKmgDYH6r9xRbLSXsajZlNB80gQRCiXQrnoPPYyjjIC6lBwid49Ep/DfPGBQltZzjzFyEXXJBNo0726I95FTtlHzQEP5noIhy9esoZPj7CP8YKhcrkm2RCM3lWCDziMTQomT7cBsrOMFnN/ASG/Mes9LbniQSqJ/3oA3hzqb89Qw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(136003)(346002)(396003)(39860400002)(451199015)(2906002)(36756003)(44832011)(316002)(41300700001)(66946007)(8676002)(6916009)(66476007)(54906003)(4326008)(478600001)(5660300002)(8936002)(6486002)(83380400001)(66556008)(38100700002)(26005)(86362001)(6506007)(6666004)(6512007)(53546011)(2616005)(186003)(66899015);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6736 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7603485a-7835-4f22-cf98-08dac0c4d35a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C+c01Q33kUf23R4QvvPOE6SFFYNIQW4T+ygoyl59RxZe8d8CTOzhy6XqjQVQWyw5AG9e/rSfwcL1oHFKxKMTo5IopYEEqKWxl29XpM3dhaIkAIitshlg7XyiOESfcqzso++KICevZGRv4b7n0IhLUpTKSCV1Itk0Dvf4bbnnGfhbXYLGntq/Ot5/EUyRX53COqkRfvIcxD/py/XkNtqelpFTZp7qT+HvydoPpcFWun6f2XaYgBgIsLylEzhhVnEszgiJmhlrv+OBFzWwmlqo3JuBQojbYa3pNoUAlCnCRmzhUFrC1/kHv89BxND/WRk2BD36DQ7oXnhPe0MbLrwLXkicYilC7+9DeB6M6P2yLhUjA3pzNpgC+ySkmStgr2wL8Qv0AShT4tK3TWsTo8MwH2ezUUf+neYu7vKVKges4XgG/u6NRCqbPmZTWwnual/lrMPaYjoxSm3eSmiASfJwozTXY9r9v7PXfJlstY+t/h819NSPcIqg9q5McVq64OMrhHoPFFCz+Zkk8HTfNRrqQ0GoKdwFZkhIp/JVO7eFLiXQFveCgkITdUPdBFRUCu4NY3J+IqmUiz0ZYIJFDhr0cmOoz5vbsGzoGj+neyEA69U/2EZ2s0vSEhrfrE82Aw/7Z05icfRRUEQzm3UKVhqzHlcBWnbN6t2N9XWAAvXNUBextlICpmub6W8FCVk/miJ0mT+lfcKma2HfYtUno+/5zLvd6THETIUh5P4AOWQYzdS+TvfkdgAZQg0DGspZgZ0pyaO/GdKbFzCV/uJddJ83LA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(396003)(136003)(451199015)(46966006)(40470700004)(36840700001)(66899015)(82310400005)(36756003)(316002)(54906003)(81166007)(6486002)(40480700001)(5660300002)(356005)(83380400001)(41300700001)(478600001)(2906002)(4326008)(44832011)(8936002)(6862004)(70586007)(70206006)(8676002)(6512007)(2616005)(336012)(47076005)(40460700003)(26005)(53546011)(82740400003)(36860700001)(186003)(86362001)(6666004)(107886003)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 13:34:52.0460 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c49f947-38e8-4311-9ea5-08dac0c4d980 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8994 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 11/05/2022 10:34, Xiaoming Ni wrote: > On 2022/11/4 19:00, Szabolcs Nagy wrote: > > The 11/04/2022 17:30, Xiaoming Ni wrote: > > > Check the return value of malloc based on the function header comment of > > > _dl_make_tlsdesc_dynamic(). If the return value fails, NULL is returned. > > > > > > Signed-off-by: Xiaoming Ni > > > > note that allocation failure is not recoverable here: > > the caller cannot really deal with NULL so tls access > > will crash. > _dl_make_tlsdesc_dynamic() is called by "void elf_machine_rela()" > Whether to add _dl_error_printf() to elf_machine_rela() when > _dl_make_tlsdesc_dynamic() returns NULL ? > Or change "void elf_machine_rela()" to non-void ? the error has to be propagated up to dlopen in one way or another. i think this can be done by _dl_signal_error (but it has to be verified that there are no leaked resources or held locks along the call stack up to dlopen). and then it's probably better to do this from _dl_make_tlsdesc_dynamic instead of return NULL. this is bug 27404, i cannot work on it now, but i can review if you have patches. for now i committed this patch so the code matches the comment. > > i think the patch is good, but it will only help if > > the failure is propagated to _dl_relocate_object and > > handled in dlopen by returning an error. > > > > let me know if you don't have commit access, then i > > can commit it for you. > > > I don't have permission to submit, thank you for your review and help. > > > Reviewed-by: Szabolcs Nagy > > Thanks > Xiaoming Ni > > > > > > > --- > > > elf/tlsdeschtab.h | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/elf/tlsdeschtab.h b/elf/tlsdeschtab.h > > > index 8c02e45a49..82733159e3 100644 > > > --- a/elf/tlsdeschtab.h > > > +++ b/elf/tlsdeschtab.h > > > @@ -110,6 +110,8 @@ _dl_make_tlsdesc_dynamic (struct link_map *map, size_t ti_offset) > > > } > > > *entry = td = malloc (sizeof (struct tlsdesc_dynamic_arg)); > > > + if (! td) > > > + return 0; > > > /* This may be higher than the map's generation, but it doesn't > > > matter much. Worst case, we'll have one extra DTV update per > > > thread. */ > > > -- > > > 2.27.0 > > > > > . > > >