From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2067.outbound.protection.outlook.com [40.107.22.67]) by sourceware.org (Postfix) with ESMTPS id 2440A393BA4D for ; Mon, 5 Dec 2022 14:55:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2440A393BA4D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HuwngXyr7L5U8kL/3QVd4UiTG+n1FZGhl1iXjjE4tQ9phGU0v9wFuF4tZV23njERXSXDaM7GxbdyGrWY9g08uv0J6epE3rA038DL0Ijo62loP9hPQoUrnuMomn6JIfE28at8w9I+lnA7b18/4yThCFfqsz/9b5GhRd93LYn8nvrY6TR7sTiwb44vfHXJKEidcralvA6e+1GO5x06XwtTRjfVwu1cOHZfoQx0pWbV6pTUD3zUyMDk77Wi5ifgYl2c2vrUzEYB3mPuVYlhKbUbCKFOwbrLe1uUAaJEl7XEaxlvsc0VSxuUbIw97eLKNzhr31/LzGLh5FIW0rM5c2dbbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QA1UTnHn50ha8h9a6mE1K0bAUNdK7bIYna+qGF/S9/8=; b=E0aVoTqinfcG0WR0LL5PK9PDV8todWGnoVIFuA0Crk12FeSb7AFqOVe7fJOzfYe5Ho7iz+hSaYiVD5yzfKN/Ap7sDclKhZOG2vITLokA77ocQBy7bSU/2qU3dS2pVqzD4glSkc5CFxZpiXnFn4f4YhsiK1snZzrmq6ZgpPdI8KUpVj2w8LKrZPsAm0eZlgyJhZJXw/xNedhrQkHwYXebzR32LBB19u0DAtmSu6HA/pCcmJ9l94yGnqxXX+vqIxt4Hn8jp1f9SDWStf7yo78nYQHVg4WnOnRn56CGsFNitd8gDPNFIbYQeq1CQEbWYyDN6zGmV83/VjRdZVUgRSs7lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QA1UTnHn50ha8h9a6mE1K0bAUNdK7bIYna+qGF/S9/8=; b=8IfKrMpOG3M3S3548H5buqsxYQQUwTax8wwAw9votcADL33+GNoSytVKb74E3uehllul2cGIawrRtm+CbcwB8rrCZfmXVkEKA9j5jwahsqZccUadpiSIgbm1YdT8oWkItOqjTm4NU7juZ1IilPBqmwOz245NmX7ROD39CCnY28E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by AS8PR08MB6326.eurprd08.prod.outlook.com (2603:10a6:20b:335::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.13; Mon, 5 Dec 2022 14:55:07 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::81ce:94a0:632d:7016]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::81ce:94a0:632d:7016%4]) with mapi id 15.20.5880.011; Mon, 5 Dec 2022 14:55:06 +0000 Date: Mon, 5 Dec 2022 14:54:50 +0000 From: Szabolcs Nagy To: linzhuorong Cc: , , , , , , Subject: Re: [PATCH] aarch64: fix elf_machine_dynamic compile error [BZ #29835] Message-ID: References: <20221202035902.27063-1-linzhuorong@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221202035902.27063-1-linzhuorong@huawei.com> X-ClientProxiedBy: LO4P123CA0297.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::14) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|AS8PR08MB6326:EE_ X-MS-Office365-Filtering-Correlation-Id: b5ec0c5f-2c34-4a77-017f-08dad6d0b142 NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cuiOPviJ6wUPhqw8zoUKpUu2Gw9toaNUsS/sll/ZaXMKJNf2OM1jUtp0PfkRC4CtEW7ZMFUXUZQs0/c1SwqOT39APcnT6Aznok6ul8ajyKChs5fwM7GdKyUKLSaV4pvrnDUv5qj7N6jKX7R/gjohdCpuCh0c2eVLor1gGBcZmwjW8mT46fjfdAj8pT61iY+CWMYoF5pKvvkPNMxRUrNU3bx/Cl9UtA3ju8bX2NUJkcmB6k28XDPleWxPSMAIhD5eIXvQ8IM2xLFJ3z+5cI65GSkcgLrVCYC9gF9liAULeRdNdzzvsE7nlBuBRPsX7MlaAajbFUxI6I3QRTqrNjS6baQaYiH9TRBx9CJd3Pp3xFzgZzYYlkamhDk0yJN5TKJQVidUx5tAq9Ufy+7nZcTWVqpPWIXNrnl22fqjutMt48hms/zlV+J6yd69McTKcuGbtlhR+KSgjSrNaWcZoXRbH0Jd5Q4u7EIm2ijGWN/G6JxjMQXG6p6uAQTp56wbJ6uLIyp9gkMfBnI+yhVAdT9Q7IEloJcd9V13sDkHzSbgwRzBtYTGrQSNaEU04Dy5I8gfZnj6AmsIbg3+acWvG4A5IZC9IBUhdEVyeDJ0GNXJvLN5iybnUuEyatgVg1PwYUWzhCK5U6jDSjrpR+T13CYZwg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(396003)(346002)(366004)(451199015)(4326008)(83380400001)(86362001)(41300700001)(5660300002)(38100700002)(8936002)(44832011)(2906002)(8676002)(26005)(6506007)(186003)(6512007)(6666004)(54906003)(316002)(478600001)(6916009)(66476007)(6486002)(66556008)(2616005)(66946007)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3FLeGJHcjRzZ29Zb21QbVhMVEZQcXZFSHp1cEZhNnRLc29kdVhNbW1hM3Ew?= =?utf-8?B?NTlLMDlrZ1RzVmJzaXlRcW5kM204ZmI4alphc2c2UWEzdG9pc2wxb1h4cU9k?= =?utf-8?B?THJIK01ZMGZlTmpjSEV2ZXllbGdrN3p3MEwvdW5RUnowZ3NoSWkyY3RiS1Ex?= =?utf-8?B?aUNMZ3pSZjdUZm9GUTU0bFNUdFRXOHROYktFMTdDMXlXaDdDME9PUENHTVlT?= =?utf-8?B?ekVTeVczcUthN2Z4M1FSWFduTDVkaWRkTXJyUm5SOFpnNmJZZ2Fva3drNWJw?= =?utf-8?B?L2Yzd08wdStZV3ZFOUQ4Rzh2WFgrSjdla0V4N3VOeDEyTGtCRS9xbEJpdmEr?= =?utf-8?B?QmViMkhtd1NaOExMekdhUnh3aDMyOXpmTXRoNDZ1clNNbktVSldJTThIRGVq?= =?utf-8?B?NTZvckZuVUJtVTRZWlp5bjE0T0VpVWVuTjNwSjB0NU9hT250MGxlZkxXeTI2?= =?utf-8?B?aGJ4OUVxQlJBQUdMbytqMVdKcGE2cFREVGhmSTgzVEYzSDF1UDF6cEJzQ1V4?= =?utf-8?B?Qy94Z0JFQTVkQ2FxbnByNHh1Uk5oM3JFQTZHUmV5MXljQXQvSGw2ZElaSnVE?= =?utf-8?B?RG1CeHRsYk5PTXpIOGY1V0tKbDhMOGN6ekNWZ3hicmxmYVNBZ3RwN3gxVEVv?= =?utf-8?B?WXBhMVhkcFN6dmpySWQvcHJZMlI4dUZyU3pEUGRyclZOQ2w0eTk1TUJZa0Vo?= =?utf-8?B?cUMrNlJrU0ZwL1NJbG0rUTlQbHd2U1N1NjhTb0tOYmJEM0dRYUpQY2RDUWN3?= =?utf-8?B?SHR6U1Nka1lCWjNvNzdXTmtvYldwTjE0RUlZZkNXMlhZTXY3dlFMTE4wV0cv?= =?utf-8?B?UUJDcWlQd1BBUngyK3lrWHdXQUdPOGxNSldIRXZBSGQ3Vm56ZGtmcEwwRkh2?= =?utf-8?B?YmdvSmZXUHlBTWZqUndoK1ZnTDc4TGh0UlpWb1hSZThsWG9zaW10QTVFdFZV?= =?utf-8?B?UkJmeW9ySjF1aDNaNnU1SHZ1eTJnRkxjRUc0UXFPUEU2V3dqbFJKQjE4alRK?= =?utf-8?B?U0VqRjZmNjVYczJuZjhJRjNJemF2N1BLTld6UTM4bC92KzEwU3E1bUZSNmZr?= =?utf-8?B?RThJQnZteWh6Mm80SEh5Uy9ZbWVVMHRlREVzVHpueFpIMjVNdnNPRzBueXZh?= =?utf-8?B?NUR0VjJvTjRxNzVBSGp1VVlzTDd3Si9mRk5leG5RSTg0dGw4SnM3MVRRSlo4?= =?utf-8?B?Tk5lcUpmRGJKWFoyNWhROUxQOFJCUmNlMVpDUkNyZ08yY2M4OFNOUHVkY1Vl?= =?utf-8?B?RDV1YUJVeE90LzlqbDY0Qk5uTGVBZzljdkZKSFVVUWtxZVhkUEtFK3VzVVAy?= =?utf-8?B?L0k2TnFERzk1TkxNWjBac0VVVnJuVUpqNHhsMnFySTdyaXJxMTBkc21WbDZ6?= =?utf-8?B?MVNFNmpGNjhUS3RYT0N1OS8vRUtoUUpvVE5hcmdCdnU5SGtsMWpDaWkzRzZ0?= =?utf-8?B?eEh4TlpSRXRuRjU4Q1lsa0RGZFFUUmJXWWs2RXJNL2tiYWZGWm9PQnN1TlE1?= =?utf-8?B?YUk3empvZG5GcnRsSW9mWHNrSnBleHFQVjdKSGtSdytvS0F2d0ZwTldlS05v?= =?utf-8?B?bE4zUnlQR2psb2ZaUXl1bUp6dDUyaE81SDlSb2tVaytaTjhmZWE1N3JISGVj?= =?utf-8?B?OTFFOEc5eWtJcnlmekNlUDB0alRkRW5Eek9QelBLeDlGbXJHVmRXcWRqeU12?= =?utf-8?B?UlI2bkYvK3FtZjRPLzYzY0NIT3FTRWc0a2NycEVjeDA3MzJGdTZCdzJMVllH?= =?utf-8?B?YjZWelpKVUZaMWdMaEJyQks1ZWY4eVRnRjNOeW4rVVdHUWtCSjlheXppanln?= =?utf-8?B?bTcyNHBHcndsb0lGdWdwTGpGS0RqMExpenM0SmVqUDBBc2RuakdGb2E0clUz?= =?utf-8?B?b0ZNaUQxVWZxSTdYTzRYMUdiYXhLclVCRkhDOEhPMlVOKzEreUJhRE96R1gx?= =?utf-8?B?RkRCcmV4MmI2UUhlbVA0SFp2dWpGZFhQT2dZaURqa2F0TzRzbTFSNHRaMmw0?= =?utf-8?B?UGl3MkdpRzF0VmxGUjBqSjh6ZzFXMjNnNEhzb2x0NGR1dzUwaHkyT09RQ2du?= =?utf-8?B?UHd6Qk1pYVgrTnk5elBuYVFvaENXeFhiazBiR1NGSnhIQ2ZaQkZNMFBiOHJn?= =?utf-8?Q?YGHhNGMAiJJh5PtT1owh1pPKw?= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5ec0c5f-2c34-4a77-017f-08dad6d0b142 X-MS-Exchange-CrossTenant-AuthSource: DB9PR08MB7179.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2022 14:55:06.5241 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nD3YrEu6/VN+hd8PcBYQEEEVKOfs3hEZW/0WLZLE9YRMvmDoNCDTBmqR6eht3DZS4usy5+7BiCk2zKBjr4qYrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6326 X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The 12/02/2022 11:59, linzhuorong via Libc-alpha wrote: > elf_machine_dynamic compile error when compiling glibc with --enable-static-pie option turned on, static executables do not have symbol _DYNAMIC glibc no longer has --enable-static-pie, instead it has --disable-default-pie . static pie should have _DYNAMIC symbol since it has dynamic relocations (relative relocs), what is the binutils version? maybe glibc should disable default pie if old binutils is detected. > > Fixes: bca0f5cbc9257c13322b99e55235c4f21ba0bd82("aarch64: Make elf_machine_{load_address,dynamic} robust [BZ #28203]") > > Signed-off-by linzhuorong > --- > sysdeps/aarch64/dl-machine.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/sysdeps/aarch64/dl-machine.h b/sysdeps/aarch64/dl-machine.h > index ae8b14425a..49b1d1ea0e 100644 > --- a/sysdeps/aarch64/dl-machine.h > +++ b/sysdeps/aarch64/dl-machine.h > @@ -53,8 +53,9 @@ elf_machine_load_address (void) > static inline ElfW(Addr) __attribute__ ((unused)) > elf_machine_dynamic (void) > { > - extern ElfW(Dyn) _DYNAMIC[] attribute_hidden; > - return (ElfW(Addr)) _DYNAMIC - elf_machine_load_address (); > + /* Declaring this hidden ensures that a PC-relative reference is uesed. */ > + extern const ElfW(Addr) _GLOBAL_OFFSET_TABLE_[] attribute_hidden; > + return _GLOBAL_OFFSET_TABLE_[0]; > } > > /* Set up the loaded object described by L so its unrelocated PLT > -- > 2.12.3 >