From: Szabolcs Nagy <Szabolcs.Nagy@arm.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: 'GNU C Library' <libc-alpha@sourceware.org>
Subject: Re: [PATCH] AArch64: Improve strchrnul
Date: Fri, 13 Jan 2023 12:29:29 +0000 [thread overview]
Message-ID: <Y8FOqQepBDFSHKgU@arm.com> (raw)
In-Reply-To: <PAWPR08MB8982A380E327146CB6070B9783FD9@PAWPR08MB8982.eurprd08.prod.outlook.com>
The 01/12/2023 16:00, Wilco Dijkstra wrote:
> Unroll the main loop, which improves performance slightly.
> Passes regress.
please commit it, thanks.
Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> ---
>
> diff --git a/sysdeps/aarch64/strchrnul.S b/sysdeps/aarch64/strchrnul.S
> index 4ca1e58c36ac903fad83c4470ed7f4abd6c74e27..aa8c9a4363051b4098c2f60ee830bab7326a54a7 100644
> --- a/sysdeps/aarch64/strchrnul.S
> +++ b/sysdeps/aarch64/strchrnul.S
> @@ -70,14 +70,22 @@ ENTRY (__strchrnul)
>
> .p2align 4
> L(loop):
> - ldr qdata, [src, 16]!
> + ldr qdata, [src, 16]
> + cmeq vhas_chr.16b, vdata.16b, vrepchr.16b
> + cmhs vhas_chr.16b, vhas_chr.16b, vdata.16b
> + umaxp vend.16b, vhas_chr.16b, vhas_chr.16b
> + fmov tmp1, dend
> + cbnz tmp1, L(end)
> + ldr qdata, [src, 32]!
> cmeq vhas_chr.16b, vdata.16b, vrepchr.16b
> cmhs vhas_chr.16b, vhas_chr.16b, vdata.16b
> umaxp vend.16b, vhas_chr.16b, vhas_chr.16b
> fmov tmp1, dend
> cbz tmp1, L(loop)
> -
> + sub src, src, 16
> +L(end):
> shrn vend.8b, vhas_chr.8h, 4 /* 128->64 */
> + add src, src, 16
> fmov tmp1, dend
> #ifndef __AARCH64EB__
> rbit tmp1, tmp1
prev parent reply other threads:[~2023-01-13 12:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 16:00 Wilco Dijkstra
2023-01-13 12:29 ` Szabolcs Nagy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8FOqQepBDFSHKgU@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).