From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out30-57.freemail.mail.aliyun.com (out30-57.freemail.mail.aliyun.com [115.124.30.57]) by sourceware.org (Postfix) with ESMTPS id 5B9993858D20 for ; Sat, 28 Jan 2023 01:48:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5B9993858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.alibaba.com X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=cooper.qu@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0VaFuJkS_1674870492; Received: from localhost(mailfrom:cooper.qu@linux.alibaba.com fp:SMTPD_---0VaFuJkS_1674870492) by smtp.aliyun-inc.com; Sat, 28 Jan 2023 09:48:13 +0800 Date: Sat, 28 Jan 2023 09:48:11 +0800 From: Xianmiao Qu To: Adhemerval Zanella Netto , libc-alpha@sourceware.org, han_mao@linux.alibaba.com Cc: fweimer@redhat.com Subject: Re: [PATCH v2] C-SKY: Strip hard float abi from hard float feature. Message-ID: References: <20230127020631.77580-1-cooper.qu@linux.alibaba.com> <0c09da9c-dc9d-4843-4c6a-46c21085c4c3@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0c09da9c-dc9d-4843-4c6a-46c21085c4c3@linaro.org> X-Spam-Status: No, score=-14.7 required=5.0 tests=BAYES_00,ENV_AND_HDR_SPF_MATCH,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Jan 27, 2023 at 04:24:32PM -0300, Adhemerval Zanella Netto wrote: > > > It is not clear to me why you need to use '-mfloat-abi=softfp' to check > for soft-float ABI, since it *won't* be used to actually build glibc > (meaning that the compiler build invocation not necessary will use the > same ABI as the test is doing). > This is for compatibility with versions prior to GCC 11. The older versions of C-SKY GCC don't support -mfloat-abi=softfp, so the '__CSKY_HARD_FLOAT_ABI__' is always not defined, and the expression 'defined(__CSKY_HARD_FLOAT__) && !defined(__CSKY_HARD_FLOAT_ABI__)' which is correct for newer versions of GCC does not work for older versions. And there doesn't seem to be an expression compitable with all versions of GCC, so I add the check for the '-mfloat-abi=softfp' option.