public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "Winfried Magerl" <winfried.magerl@t-online.de>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] x86: Check SSBD and STIBP only on Intel CPUs
Date: Sat, 30 Jan 2021 17:26:11 +0100	[thread overview]
Message-ID: <YBWIo4/3008EQ2ps@winnix.dyndns.org> (raw)
In-Reply-To: <CAMe9rOqaQyWdRaDw8jxCTzLSuS0J0-0fTOk5tEsfaGfCKVU1mA@mail.gmail.com>

Hello,

On Sat, Jan 30, 2021 at 05:59:55AM -0800, H.J. Lu via Libc-alpha wrote:
> On Sat, Jan 30, 2021 at 2:26 AM Winfried Magerl
> <winfried.magerl@t-online.de> wrote:
> >
> > Hello,
> >
> > On Sat, Jan 30, 2021 at 09:34:56AM +0100, Winfried Magerl wrote:
> > > Hello,
> > >
> > > I got a suspicious error when building current upcoming glibc-2.33:
> > >
> > > FAIL: elf/tst-cpu-features-cpuinfo
> > >
> > > The relavant details from elf/tst-cpu-features-cpuinfo.out
> > > (likely invariant_tsc can be ignored):
> > >
> > > Checking HAS_CPU_FEATURE (INVARIANT_TSC):
> > >   HAS_CPU_FEATURE (INVARIANT_TSC): 1
> > >   cpuinfo (invariant_tsc): 0
> > >  *** missing in /proc/cpuinfo ***
> > > Checking HAS_CPU_FEATURE (SSBD):
> > >   HAS_CPU_FEATURE (SSBD): 0
> > >   cpuinfo (ssbd): 1
> > >  *** failure ***
> > > Checking HAS_CPU_FEATURE (STIBP):
> > >   HAS_CPU_FEATURE (STIBP): 0
> > >   cpuinfo (stibp): 1
> > >  *** failure ***
> > > 2 differences between /proc/cpuinfo and glibc code.
> > >
> > > The details of the build-system:
> > >       cpu:            AMD Ryzen 9 3900X 12-Core Processor
> > >       os:             openSUSE Tumbleweed 20210128
> > >       gcc:            gcc-10-3.1.x86_64
> > >       binutils:       binutils-2.35.1-1.1
> >
> > the missing kernel-version:
> >         openSUSE:       kernel-default-5.10.9-1.2.x86_64
> >
> > also tested with vanilla-kernels with identical result:
> >         linux-5.9.16
> >         linux-5.11-rc5
> >
> > > Maybe this helps to track down the problem. From a quick look it's
> > > likely uncritical because the feature is simply missing (as opposed
> > > to a missdetected non-existing feature).
> 
> Try this.

Thank you!

I can confirm that the patch results in a successfull run of the test.

The expected result when the check for ssbd and stibp is done for
intel-cpus only.

regards

	winfried


      reply	other threads:[~2021-01-30 16:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-30  8:34 AMD 3900X: FAIL: elf/tst-cpu-features-cpuinfo Winfried Magerl
2021-01-30 10:16 ` Winfried Magerl
2021-01-30 13:59   ` [PATCH] x86: Check SSBD and STIBP only on Intel CPUs H.J. Lu
2021-01-30 16:26     ` Winfried Magerl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YBWIo4/3008EQ2ps@winnix.dyndns.org \
    --to=winfried.magerl@t-online.de \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).