From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 81F5E3851C3B for ; Mon, 15 Feb 2021 13:29:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 81F5E3851C3B Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 954D4340C02; Mon, 15 Feb 2021 13:29:11 +0000 (UTC) Date: Mon, 15 Feb 2021 08:29:10 -0500 From: Mike Frysinger To: Adhemerval Zanella Cc: Naohiro Tamura , libc-alpha@sourceware.org Subject: Re: [PATCH] Replaced obsoleted AC_HELP_STRING to AS_HELP_STRING Message-ID: Mail-Followup-To: Adhemerval Zanella , Naohiro Tamura , libc-alpha@sourceware.org References: <20210215123137.204048-1-naohirot@fujitsu.com> <0820aeae-41c4-e751-e6b2-aaa83921fc41@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0820aeae-41c4-e751-e6b2-aaa83921fc41@linaro.org> X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 13:29:15 -0000 On 15 Feb 2021 09:59, Adhemerval Zanella via Libc-alpha wrote: > On 15/02/2021 09:31, Naohiro Tamura wrote: > > This patch replaced obsoleted AC_HELP_STRING to AS_HELP_STRING. > > As of Glibc 2.33, INSTALL says "GNU 'autoconf' 2.69 (exactly)" is > > required. So we can safely replace obsoleted macro without worrying > > about older autoconf. > > This change doesn't affect the contents of "configure" file. > > If this does not change or improve configure, why change configure.ac > then? why wait for autoconf to start warning that we're using a deprecated macro and failing the build or confusing devs ? patch LGTM -mike