From: Stafford Horne <shorne@gmail.com>
To: GLIBC patches <libc-alpha@sourceware.org>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH] time: Fix compile error in itimer test affecting hurd
Date: Fri, 20 Aug 2021 05:57:02 +0900 [thread overview]
Message-ID: <YR7FnrvIESDyFquE@antec> (raw)
In-Reply-To: <20210819145853.63520-1-shorne@gmail.com>
On Thu, Aug 19, 2021 at 11:58:53PM +0900, Stafford Horne wrote:
> The recent change to use __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64 to avoid
> doing 64-bit checks on some platforms broke the test for hurd where
> __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64 is not defined. With error:
>
> tst-itimer.c: In function 'do_test':
> tst-itimer.c:103:11: error: '__KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64' undeclared (first use in this function)
> 103 | if (__KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> tst-itimer.c:103:11: note: each undeclared identifier is reported only once for each function it appears in
>
> Define a new macro that works for both hurd and linux to detect when
> setitimer and getitimer support 64-bit time_t.
>
> Fixes commit 6e8a0aac2f ("time: Fix overflow itimer tests on 32-bit
> systems").
>
> Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> Cc: Joseph Myers <joseph@codesourcery.com>
> ---
> Hi Joseph,
>
> I know you mentioned defining a new macro, I was not sure if you meant in the
> test or globally. I opted to add this to the test as I don't see a good reason
> to add the macro to hurd which is only needed for this test.
>
> I build tested this on i686-gnu and ran my tests on or1k and it does work.
>
> -Stafford
>
> time/tst-itimer.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/time/tst-itimer.c b/time/tst-itimer.c
> index bd7d7afe83..af97ef6acf 100644
> --- a/time/tst-itimer.c
> +++ b/time/tst-itimer.c
> @@ -25,6 +25,12 @@
> #include <unistd.h>
> #include <time.h>
>
> +#ifdef __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64
> +# define ITIMER_SUPPORTS_TIMESPEC64 __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64
> +#else
> +# define ITIMER_SUPPORTS_TIMESPEC64 (sizeof (__time_t) == 8)
> +#endif
> +
As suggested by Adhemerval I will create a v2 of this patch moving the gist of
this into support/xtime.h.
-Stafford
prev parent reply other threads:[~2021-08-19 20:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 14:58 Stafford Horne
2021-08-19 20:57 ` Stafford Horne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YR7FnrvIESDyFquE@antec \
--to=shorne@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).