From: Mike Frysinger <vapier@gentoo.org>
To: Olivier Galibert <galibert@pobox.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Make using non-default as/ld/etc easier.
Date: Mon, 23 Aug 2021 17:33:45 -0400 [thread overview]
Message-ID: <YSQUOb1UCPXFQuZa@vapier> (raw)
In-Reply-To: <20210823191755.597854-1-galibert@pobox.com>
On 23 Aug 2021 21:17, Olivier Galibert wrote:
just nits. idea looks fine to me.
> --- a/aclocal.m4
> +++ b/aclocal.m4
> @@ -114,15 +114,38 @@ if test -n "$path_binutils"; then
> path_binutils=`(cd $path_binutils; pwd) | sed 's%/*$%/%'`
> CC="$CC -B$path_binutils"
> fi
> -AS=`$CC -print-prog-name=as`
> -LD=`$CC -print-prog-name=ld`
> -AR=`$CC -print-prog-name=ar`
> +check_as_version=0
> +AC_ARG_VAR([AS], [as program to use])
> +if test -z "$AS"; then
> + AS=`$CC -print-prog-name=as`
> + check_as_version=1
> +fi
we do 2 space indents
(i know the CC code above is broken, but best to not keep adding more)
> --- a/configure.ac
> +++ b/configure.ac
>
> +# Accept binutils 2.25 or newer. Don't check version if the path is forced.
we've been inconsistent, but should use "dnl" instead of "#"
> +AS_IF([test $check_as_version == 1],
> +AS_IF([test $check_ld_version == 1],
== is a bashism. you want = instead.
-mike
next prev parent reply other threads:[~2021-08-23 21:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 7:11 Olivier Galibert
2021-08-22 20:14 ` Fangrui Song
2021-08-23 1:43 ` Mike Frysinger
2021-08-23 19:17 ` Olivier Galibert
2021-08-23 21:33 ` Mike Frysinger [this message]
2021-08-24 8:34 ` Olivier Galibert
2021-09-07 7:41 ` Olivier Galibert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSQUOb1UCPXFQuZa@vapier \
--to=vapier@gentoo.org \
--cc=galibert@pobox.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).