From: Stafford Horne <shorne@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: Stafford Horne via Libc-alpha <libc-alpha@sourceware.org>,
Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH v2] time: Fix compile error in itimer test affecting hurd
Date: Wed, 8 Sep 2021 06:20:26 +0900 [thread overview]
Message-ID: <YTfXmu0BD7sHu74Y@antec> (raw)
In-Reply-To: <874kawx2ys.fsf@oldenburg.str.redhat.com>
On Tue, Sep 07, 2021 at 09:24:43AM +0200, Florian Weimer wrote:
> * Stafford Horne via Libc-alpha:
>
> > +/* Return true if the setitimer and getitimer syscalls support 64-bit time_t
> > + values without resulting in overflow. This is not true on some linux systems
> > + which have 64-bit time_t due to legacy kernel API's. */
> > +static __inline bool support_itimer_support_time64 (void)
> > +{
> > +#ifdef __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64
> > + return __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64;
> > +#else
> > + return (sizeof (__time_t) == 8);
> > +#endif
> > +}
>
> Extra parentheses for the second return.
Ah, yes that carried over fromt when I defined as a macro, will fix it.
> I haven't followed development
> in this area and I'm not sure if that's following the direction others
> prefer. I'd say wait a few more days for comments, and if there are
> none, commit with the parentheses removed.
Thanks, I'll wait a few more days.
-Stafford
prev parent reply other threads:[~2021-09-07 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 21:28 Stafford Horne
2021-09-06 21:19 ` Stafford Horne
2021-09-07 7:24 ` Florian Weimer
2021-09-07 21:20 ` Stafford Horne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTfXmu0BD7sHu74Y@antec \
--to=shorne@gmail.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).