From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 17B123858023 for ; Tue, 7 Sep 2021 21:20:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 17B123858023 Received: by mail-pg1-x52c.google.com with SMTP id w8so186999pgf.5 for ; Tue, 07 Sep 2021 14:20:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AMYPEXJmeaD7pb0Tk5verLhyKai6JKKVhXDcXaJYqb4=; b=Z3+wkTEbKBroRr+FLlysRszS9H55BLFJ/ZKQVeiigSZaqYbgg9OL5Z2ndGJ2eerojx 81gNbonoAvfmia3/iWCldqxqHH0s+IHl7iFBbKxAVoIQNBaPOL0kf+9e+pZBETlSvR02 q6vbXCDITXkR/8I8v8i5XCczgBJ+ywSV0EuWTHVpAQ3146C4pDBNs5a46AM2yvzNA14X C0sHwy6M3jDD+HUPvKOc31+zTQ2me9Jli8NPYWjL9yn1KXwSSo3E1YDCdH5/Dz0UkgHX LIFV7egrErKtay65f/xB+yMtEBq+iUFZ2G/EcvcFzZCaoffiEs+eQg66y9uCRSLCwGag ps7Q== X-Gm-Message-State: AOAM5305lWqOyfeENT8D6QE80EOh2Yi5KmeEuCzAbhuMU3exqqKUhbay jBos2gZL7dReHzIqPX9HB+X/2ffCfPs= X-Google-Smtp-Source: ABdhPJx5OCb2ckVWJV8C+DMNH7n4WQ5xxaC0IY6xC3aJuahHHQTrQ6eIlERnnmh0sYvU7epfRWxENg== X-Received: by 2002:aa7:989d:0:b0:3ef:5f81:5c2f with SMTP id r29-20020aa7989d000000b003ef5f815c2fmr404365pfl.44.1631049629167; Tue, 07 Sep 2021 14:20:29 -0700 (PDT) Received: from localhost (g7.61-205-255.ppp.wakwak.ne.jp. [61.205.255.7]) by smtp.gmail.com with ESMTPSA id d22sm32520pfv.196.2021.09.07.14.20.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Sep 2021 14:20:28 -0700 (PDT) Date: Wed, 8 Sep 2021 06:20:26 +0900 From: Stafford Horne To: Florian Weimer Cc: Stafford Horne via Libc-alpha , Joseph Myers Subject: Re: [PATCH v2] time: Fix compile error in itimer test affecting hurd Message-ID: References: <20210819212800.455725-1-shorne@gmail.com> <874kawx2ys.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <874kawx2ys.fsf@oldenburg.str.redhat.com> X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Sep 2021 21:20:31 -0000 On Tue, Sep 07, 2021 at 09:24:43AM +0200, Florian Weimer wrote: > * Stafford Horne via Libc-alpha: > > > +/* Return true if the setitimer and getitimer syscalls support 64-bit time_t > > + values without resulting in overflow. This is not true on some linux systems > > + which have 64-bit time_t due to legacy kernel API's. */ > > +static __inline bool support_itimer_support_time64 (void) > > +{ > > +#ifdef __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64 > > + return __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64; > > +#else > > + return (sizeof (__time_t) == 8); > > +#endif > > +} > > Extra parentheses for the second return. Ah, yes that carried over fromt when I defined as a macro, will fix it. > I haven't followed development > in this area and I'm not sure if that's following the direction others > prefer. I'd say wait a few more days for comments, and if there are > none, commit with the parentheses removed. Thanks, I'll wait a few more days. -Stafford