From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id BCDDA3858025 for ; Wed, 13 Oct 2021 21:51:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BCDDA3858025 Received: by mail-pl1-x634.google.com with SMTP id w14so2749708pll.2 for ; Wed, 13 Oct 2021 14:51:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PbbMVK61iAy8tJxugIDgQgBi5ebR9XAKL0QejTHg11I=; b=7JDEg8W9iE8Pt/iAwBgJAY7QRAMNgEqH+K6Lk4lrSJHM4tqw5vwKlHu0MKEoDBK3zM Xvtx77SObt5m5Eq64TE5YqHyKLITFFbj+/trzQ/m49tM+jAz/A1eQHckTQbDiuvVZEf6 UJ5E7zfcrhEHwMkKGGXD4SyPKv2vLjeQwngET+qlSMhPSVy4APG4aMoJifrqZ1XJu84j x47vKavPVijz31qZDMn3LVhpTz2YbE2bjW+uQIZNg5WQrNftTqU7iFdaRM1HSYBfM3v7 1tDpuG/TjLPKsRDRS6wQ6t78lmY1CLTPhg2bqDF4DiVsHonMcdLFB7ZXCzvdFXwBkfIw XmNQ== X-Gm-Message-State: AOAM531vjLj2wsKAm9B2AA6TgWb3ddDeBrt57IhIxmACqTKZ20+pagaD /xs8MgS4NFGsVeAC8XzmweE= X-Google-Smtp-Source: ABdhPJyDPcnZ7/PP91bXWTRpadVyyXIMFUJZRCMOnZq3wNXb+ArlkfuMX1FCQ3rb11qTurAFkSp51g== X-Received: by 2002:a17:90b:4f84:: with SMTP id qe4mr109803pjb.209.1634161883788; Wed, 13 Oct 2021 14:51:23 -0700 (PDT) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id q10sm453200pgn.31.2021.10.13.14.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 14:51:23 -0700 (PDT) Date: Thu, 14 Oct 2021 06:51:21 +0900 From: Stafford Horne To: Paul Eggert Cc: Adhemerval Zanella , GLIBC patches Subject: Re: [PATCH v3 18/24] y2038: Add support for 64-bit time on legacy ABIs Message-ID: References: <20210607203613.282543-1-adhemerval.zanella@linaro.org> <20210607203613.282543-19-adhemerval.zanella@linaro.org> <4532ccfd-971b-2a4d-c751-799b1962401e@cs.ucla.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4532ccfd-971b-2a4d-c751-799b1962401e@cs.ucla.edu> X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Oct 2021 21:51:26 -0000 On Wed, Oct 13, 2021 at 09:45:22AM -0700, Paul Eggert wrote: > On 10/13/21 4:44 AM, Stafford Horne via Libc-alpha wrote: > > > > +@item > > > +@code{_TIME_BITS=64} and port from the outset uses 64-bit > > > +@code{time_t} and word size equals to @w{32 bits} (e.g. ARC, RV32) > > > +- no action > > > > OpenRISC falls into this category. We have 64-bit support but word size is > > 32 bits. > > If OpenRISC has always had 64-bit time_t, the -D_TIME_BITS=64 option should > have no effect on compilation. I.e., time_t used to be 64 bits, and it'll > still be 64 bits regardless of whether you use that option. > > > On OpenRISC we have __TIMESIZE == 64, so __USE_TIME_BITS64 does not get > > defined. > > That sounds OK. If time_t has always been 64 bits, there's no need for the > 32- vs 64-bit time_t complexity. > > The diagnostics you gave don't seem to have anything to do with time_t. > However, if you're getting them with -D_TIME_BITS=64 but not getting them > without that option, that suggests there's a glitch somewhere that needs to > be tracked down more carefully. Thanks, between this and Joseph's mail it makes sense where I was going wrong. -Stafford