From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by sourceware.org (Postfix) with ESMTPS id 60590385840E for ; Sat, 30 Oct 2021 08:56:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 60590385840E Received: by mail-pj1-x1036.google.com with SMTP id k2-20020a17090ac50200b001a218b956aaso9028840pjt.2 for ; Sat, 30 Oct 2021 01:56:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=60MTXVCryRoQ37Kp5CEtSTi9W2Mj3RwMwWDyb62/LvY=; b=Gz7nK2LB8jasla8Zq4hogSAto0I0/EGGQ4plk2aQW75ikjIptTr+oqt2JmZdqkOkBU QwmP6a2FJjYVCEJ/yEQfJZOopQKyja0+KLsLqd5fkPMi8i6qz/s5HFxKMzhRD5/V2pmb 6QlDF3+M3qUE7GBWW0wx6LW5C1B9HQPZj7lBwrmXccQBwGMLuN22uhjBXeXca94q4YRa 5m3Tf1SSaAiG1m3FjvPTinosoyUKdGw3vg27jgsislaQOXut8gVX4tTGUhpyprAFKLli Fd6mTfECf22AzFHrkkq3kO5iCUKBXZyPbBMGtViUOaQMxPctlUZdeRvHBKCf13Gyp52q I2Yw== X-Gm-Message-State: AOAM530cCWRt1onid10k+REamEhVAEzhzEqZNzq0SKXEysu3MuOvl4C2 xEzxYooDebuj4eD0FHt++pc= X-Google-Smtp-Source: ABdhPJxXqtNRp3+O4EFV9VD72lylcRC/3mmAXshyBjTtV40cXx/L9a+cX3b1U+AhLbyctlqPrSKofQ== X-Received: by 2002:a17:90a:9f93:: with SMTP id o19mr10437769pjp.136.1635584165229; Sat, 30 Oct 2021 01:56:05 -0700 (PDT) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id m7sm7638647pgn.32.2021.10.30.01.56.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Oct 2021 01:56:04 -0700 (PDT) Date: Sat, 30 Oct 2021 17:56:02 +0900 From: Stafford Horne To: Joseph Myers Cc: GLIBC patches Subject: Re: Upstreaming OpenRISC with GCC mainline Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Oct 2021 08:56:07 -0000 On Sat, Oct 30, 2021 at 12:08:18AM +0900, Stafford Horne wrote: > On Fri, Oct 29, 2021, 11:43 PM Joseph Myers wro= te: >=20 > > On Fri, 29 Oct 2021, Stafford Horne wrote: > > > > > $ or1k-glibc-linux-gnu-gcc tst-mqueue5.c -c -std=3Dgnu11 > > -fgnu89-inline -g -O -Wall -Wwrite-strings -Wundef -Werror > > -fmerge-all-constants -frounding-math -fno-stack-protector -fno-c.... > > > > That's -O, i.e. -O1, which is expected to have extra warnings. Making > > glibc build cleanly with different optimization options would be good, = but > > should be handled separately from new ports. > > >=20 > Oh, you are right, I reset CFLAGS before the build so I didn't think > anything would be coming in. I'll try to figure out where those extra fla= gs > are coming from. Alright, now that I am using -g -O2 I am almost getting a clean run of build-many-glibcs.py, using the following branches: GLIBC: mainline (2021-10-29 b3cf94ef15 + or1k port) GCC : mainline (2021-10-29 518bc4ef87e) I am now getting the below for both x86_64-linux-gnu and or1k-linux-gnu-sof= t. It seems to be related to -frounding-math, removing that flag fixes the iss= ue. GCC has 2 patches related to this recently committed: 2021-10-28 81342e95827 Richard Biener middle-end/84407 - honor -fround= ing-math for int to float conversion 2021-10-28 a84b9d5373c Richard Biener middle-end/57245 - honor -fround= ing-math in real truncation Error: or1k-glibc-linux-gnu-gcc tst-timespec.c -fdump-analyzer -fdump-lang-all= -fdump-tree-all -c -fgnu89-inline -g -O2 -Wall -Wwrite-strings -Wundef -W= error -fmerge-all-constants -frounding-math -fno-stack-protector -fno-commo= n -Wstrict-prototypes -Wold-style-definition -fmath-errno -I../i= nclude -I/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux= -gnu-soft/glibc/support -I/home/shorne/work/gnu-toolchain/build-many/build= /glibcs/or1k-linux-gnu-soft/glibc -I../sysdeps/unix/sysv/linux/or1k -I../= sysdeps/or1k/nptl -I../sysdeps/unix/sysv/linux/generic/wordsize-32 -I../s= ysdeps/unix/sysv/linux/generic -I../sysdeps/unix/sysv/linux/include -I../s= ysdeps/unix/sysv/linux -I../sysdeps/nptl -I../sysdeps/pthread -I../sysde= ps/gnu -I../sysdeps/unix/inet -I../sysdeps/unix/sysv -I../sysdeps/unix = -I../sysdeps/posix -I../sysdeps/or1k/nofpu -I../sysdeps/ieee754/soft-fp = -I../sysdeps/or1k -I../sysdeps/wordsize-32 -I../sysdeps/ieee754/dbl-64 -= I../sysdeps/ieee754/flt-32 -I../sysdeps/ieee754 -I../sysdeps/generic -I.= =2E -I../libio -I. -D_LIBC_REENTRANT -include /home/shorne/work/gnu-toolch= ain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/libc-modules.h -DMODU= LE_NAME=3Dtestsuite -include ../include/libc-symbols.h -DTOP_NAMESPAC= E=3Dglibc -o /home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-l= inux-gnu-soft/glibc/support/tst-timespec.o -MD -MP -MF /home/shorne/work/gn= u-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/support/tst-t= imespec.o.dt -MT /home/shorne/work/gnu-toolchain/build-many/build/glibcs/or= 1k-linux-gnu-soft/glibc/support/tst-timespec.o In file included from tst-timespec.c:22: ../include/intprops.h:57:3: error: initializer element is not computabl= e at load time 57 | ((t) (! TYPE_SIGNED (t) = \ | ^ tst-timespec.c:48:20: note: in expansion of macro =E2=80=98TYPE_MAXIMUM= =E2=80=99 48 | #define TIME_T_MAX TYPE_MAXIMUM (time_t) | ^~~~~~~~~~~~ tst-timespec.c:290:19: note: in expansion of macro =E2=80=98TIME_T_MAX= =E2=80=99 290 | .upper_bound =3D TIME_T_MAX, .lower_bound =3D 1, .result =3D= 1, | ^~~~~~~~~~ ../include/intprops.h:57:3: note: (near initialization for =E2=80=98che= ck_cases[20].upper_bound=E2=80=99) 57 | ((t) (! TYPE_SIGNED (t) = \ | ^ tst-timespec.c:48:20: note: in expansion of macro =E2=80=98TYPE_MAXIMUM= =E2=80=99 48 | #define TIME_T_MAX TYPE_MAXIMUM (time_t) | ^~~~~~~~~~~~ tst-timespec.c:290:19: note: in expansion of macro =E2=80=98TIME_T_MAX= =E2=80=99 290 | .upper_bound =3D TIME_T_MAX, .lower_bound =3D 1, .result =3D= 1, | ^~~~~~~~~~ So maybe we need some more DIAG_* macros here now? -Stafford