From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by sourceware.org (Postfix) with ESMTPS id C4845385840B for ; Fri, 12 Nov 2021 23:10:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C4845385840B Received: by mail-pj1-x1036.google.com with SMTP id gx15-20020a17090b124f00b001a695f3734aso8825782pjb.0 for ; Fri, 12 Nov 2021 15:10:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3M61MV1P/LKQ6dL4KgLDu1v1Ve3KEKtaf8Baf6EdF1g=; b=KGhcTvHU3ao5bEc8/EAgWzh5B/kFU2qvXHePc0lYjrWZ2ik6e6OQK12fPlePX798LU U4WIcd1lGwAwwkx0KrSEjLXz6SMy3Ia7s0cjx2CzHxobpvVrQVeg3mMY8kIYBY1kd0z2 AV2q7Xl/Ui1FW1D2CGnPzlQ8Yu777p/2/YtAIxl20jVieqq+d470O2TzYaeQ34XIMRTs Y9OQ0A6rRmtWQ8oh1McJwQrBrZ5743Il6J5fkzRrm/ZcVRG1KoXpstdayy4F6nu9Gy9l pj9FD3y5J1LaKViJI0hq6J7gQW3fRik0EQODSN0n1yIYuvf0L+EIZXIhmtkejpsqrj3W ATlw== X-Gm-Message-State: AOAM533Ez/i2jGoHdBHsDv234l0xwlAwkI5QFIEgQMVOBfoMM56qdcSc 8gnJn3ElPhILV5K+ew/R4zk= X-Google-Smtp-Source: ABdhPJwrYPYfAdYrxDbaRtqs+lxv7tJZbnClVfd3cqtHiBJlwKebbkDK5W3/JZbrBtymgdsutRvD4w== X-Received: by 2002:a17:90b:4c0f:: with SMTP id na15mr40003668pjb.222.1636758623339; Fri, 12 Nov 2021 15:10:23 -0800 (PST) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id pf15sm13005960pjb.40.2021.11.12.15.10.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Nov 2021 15:10:22 -0800 (PST) Date: Sat, 13 Nov 2021 08:10:20 +0900 From: Stafford Horne To: Paul Eggert Cc: GLIBC patches Subject: Re: [PATCH v2] tst-tzset: output reason when creating 4GiB file fails Message-ID: References: <20211102233159.4094554-1-shorne@gmail.com> <61531402-fbc9-fcc9-93b9-f453901bf399@cs.ucla.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Nov 2021 23:10:27 -0000 On Thu, Nov 04, 2021 at 05:30:27AM +0900, Stafford Horne wrote: > On Wed, Nov 03, 2021 at 12:14:52PM -0700, Paul Eggert wrote: > > On 11/2/21 16:31, Stafford Horne via Libc-alpha wrote: > > > + { > > > + printf ("creating timezone file of size: %" PRId64 "MiB failed.\n", > > > + size / (1024 * 1024)); > > > > Why not simply print the size in bytes? Converting to MiB outputs less > > information due to rounding, and is hardly worth the trouble here. Other > > than that, looks fine. > > Hi Paul, > > The reason for the divide by (1024 * 1024) it to make it easier to see where the > failure is at a glance. > > The call to test_tz_file is done two times: > > test_tz_file (64 * 1024 * 1024); > > test_tz_file (4LL * 1024 * 1024 * 1024 - 6); > > For me, it's a lot easier to tell the different between 2 and 4 digits (64MiB > and 4096MiB) than the bigger numbers. The information lost is not too important > considering the test, in my opinion. Hi, I have pushed this as is. -Stafford