From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id 7A0373858C60 for ; Tue, 2 Nov 2021 04:18:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7A0373858C60 Received: by mail-pf1-x42e.google.com with SMTP id h74so4355414pfe.0 for ; Mon, 01 Nov 2021 21:18:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=zvFB/V1RpA7rg/lADi668dWF3vmvMWdClvhsx59ZzAo=; b=2l0Y9K05GTN7fHCQsS9FEuaIxCyGUUiVCfhJqNaaeQo20hxA5ConkJpnaR8kgUxRn/ OTEvLmCdBxIVE+vLTBbiY//3jKbnnCWMsElDXWKuHoasRTqwUHWDsY8DQxEBiY1FND3n oqzXpqLYlvuKdAAPwfvJqxPGFzTolQ3ArZ7B22wwlZ1lE/L99FKQTKMzKad0Z11XAEDC dUZ2EZ3RmoU4OUw7SQehgSVza2eKTnt+hW3EwhepXRQDSVL2Gibf0A4XueH0Y0KUyFpw b4FQhZwpo1m80dRZcw4O38p7t3ENx+YT4MZqm8taKSn9NhQ6DvHYP8LsMnd5bXn0F/mx itpw== X-Gm-Message-State: AOAM533TAXJCg+IiMybXJ6sM3KuTV1rMuTEe2eIxlLmYSFX2R6gZDN/m teVspOfybASnYm6uz9prqw7dT15lKjk= X-Google-Smtp-Source: ABdhPJwwBSf0OAXY/TwUny5KaGRpQTWd0hOtgZIGO3kywwN35nJnzxqpM7VcVyn8cT65i+dErS/FUQ== X-Received: by 2002:a05:6a00:1946:b0:44d:8136:a4a4 with SMTP id s6-20020a056a00194600b0044d8136a4a4mr33877559pfk.46.1635826698407; Mon, 01 Nov 2021 21:18:18 -0700 (PDT) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id e9sm12838090pfv.132.2021.11.01.21.18.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 21:18:17 -0700 (PDT) Date: Tue, 2 Nov 2021 13:18:15 +0900 From: Stafford Horne To: Joseph Myers Cc: GLIBC patches Subject: Re: Upstreaming OpenRISC with GCC mainline Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2021 04:18:23 -0000 On Mon, Nov 01, 2021 at 08:47:04PM +0000, Joseph Myers wrote: > On Sat, 30 Oct 2021, Stafford Horne via Libc-alpha wrote: >=20 > > Error: > >=20 > > or1k-glibc-linux-gnu-gcc tst-timespec.c -fdump-analyzer -fdump-lang= -all -fdump-tree-all -c -fgnu89-inline -g -O2 -Wall -Wwrite-strings -Wunde= f -Werror -fmerge-all-constants -frounding-math -fno-stack-protector -fno-c= ommon -Wstrict-prototypes -Wold-style-definition -fmath-errno -I= =2E./include -I/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k= -linux-gnu-soft/glibc/support -I/home/shorne/work/gnu-toolchain/build-many= /build/glibcs/or1k-linux-gnu-soft/glibc -I../sysdeps/unix/sysv/linux/or1k = -I../sysdeps/or1k/nptl -I../sysdeps/unix/sysv/linux/generic/wordsize-32 = -I../sysdeps/unix/sysv/linux/generic -I../sysdeps/unix/sysv/linux/include = -I../sysdeps/unix/sysv/linux -I../sysdeps/nptl -I../sysdeps/pthread -I..= /sysdeps/gnu -I../sysdeps/unix/inet -I../sysdeps/unix/sysv -I../sysdeps/= unix -I../sysdeps/posix -I../sysdeps/or1k/nofpu -I../sysdeps/ieee754/sof= t-fp -I../sysdeps/or1k -I../sysdeps/wordsize-32 -I../sysdeps/ieee754/dbl= -64 -I../sysdeps/ieee754/flt-32 -I../sysdeps/ieee754 -I../sysdeps/generi= c -I.. -I../libio -I. -D_LIBC_REENTRANT -include /home/shorne/work/gnu-to= olchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/libc-modules.h -D= MODULE_NAME=3Dtestsuite -include ../include/libc-symbols.h -DTOP_NAME= SPACE=3Dglibc -o /home/shorne/work/gnu-toolchain/build-many/build/glibcs/or= 1k-linux-gnu-soft/glibc/support/tst-timespec.o -MD -MP -MF /home/shorne/wor= k/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/support/t= st-timespec.o.dt -MT /home/shorne/work/gnu-toolchain/build-many/build/glibc= s/or1k-linux-gnu-soft/glibc/support/tst-timespec.o > > In file included from tst-timespec.c:22: > > ../include/intprops.h:57:3: error: initializer element is not compu= table at load time > > 57 | ((t) (! TYPE_SIGNED (t) = \ > > | ^ > > tst-timespec.c:48:20: note: in expansion of macro =E2=80=98TYPE_MAX= IMUM=E2=80=99 > > 48 | #define TIME_T_MAX TYPE_MAXIMUM (time_t) > > | ^~~~~~~~~~~~ > > tst-timespec.c:290:19: note: in expansion of macro =E2=80=98TIME_T_= MAX=E2=80=99 > > 290 | .upper_bound =3D TIME_T_MAX, .lower_bound =3D 1, .result= =3D 1, > > | ^~~~~~~~~~ > > ../include/intprops.h:57:3: note: (near initialization for =E2=80= =98check_cases[20].upper_bound=E2=80=99) > > 57 | ((t) (! TYPE_SIGNED (t) = \ > > | ^ > > tst-timespec.c:48:20: note: in expansion of macro =E2=80=98TYPE_MAX= IMUM=E2=80=99 > > 48 | #define TIME_T_MAX TYPE_MAXIMUM (time_t) > > | ^~~~~~~~~~~~ > > tst-timespec.c:290:19: note: in expansion of macro =E2=80=98TIME_T_= MAX=E2=80=99 > > 290 | .upper_bound =3D TIME_T_MAX, .lower_bound =3D 1, .result= =3D 1, > > | ^~~~~~~~~~ > >=20 > > So maybe we need some more DIAG_* macros here now? >=20 > No, since (a) this is a plain error, not a warning that's turned to an=20 > error by -Werror, so DIAG_* can't help, and (b) it's a definite compiler= =20 > bug that needs to be fixed in GCC. >=20 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D103031 Thanks for explaining. For now I am just adding a cast using (double) to work around this. A rece= nt rebase has introduced an abort localplt symbol into libc.so, so build-many-glibs.py is not clean for me anylonger. Once I track that down I should be good to submit v2 of the port for review. -Stafford