From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id C855A3858431 for ; Tue, 16 Nov 2021 05:12:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C855A3858431 Received: by mail-pl1-x629.google.com with SMTP id m24so6407513pls.10 for ; Mon, 15 Nov 2021 21:12:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xQluxbDy/JtVDJEbiLWvE9bsvEEj++OxpyaQHCAD4fA=; b=1+YruP83Wa+rsfJFFDXyhMTUrueFRUWDt5EfyS4lKyIsCoVrZFEOwKlG/8oLRVF9q3 CEvLXwUn5aqPybCaZiGQ7dKta1fiMj4R24AaCjqTiN+yRxlyP7sCuvoTjp081omNzig5 Vd8tKpPu4eu9OJjWmUZgKONcWUr7SGnGPyFPTsxM3BD/JzoIBCrezMYFKoX6daj1kB44 2ncVt49f1pueG1Bez5WVZPmTno7UR7jSTLImTE+lxctdL4Gi0hcze2WCJ08/qNDb6670 TdtiiSCAp5+EUybAZjfLuo8ylF7Use8KcC0hYj3C8Q4/nDOpkMTaUpBWfxhhogSWtR9P NEww== X-Gm-Message-State: AOAM532Sg4yTxB4NvKHS4ImtUae55cvNwIGCDbs9L+g5tmIa0J5pHZ+w iZfT1Ld1znZSYfUgh/DOX185PQHX158= X-Google-Smtp-Source: ABdhPJyAXtNHQquvZj91CbOpgRdM3xFrAM5GNhXmqBN0LEX+O49Q8ionsXnPhvspDmiPHeRWsRddMA== X-Received: by 2002:a17:902:c943:b0:142:1758:8ee7 with SMTP id i3-20020a170902c94300b0014217588ee7mr41655122pla.58.1637039543917; Mon, 15 Nov 2021 21:12:23 -0800 (PST) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id i67sm16873582pfg.189.2021.11.15.21.12.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Nov 2021 21:12:23 -0800 (PST) Date: Tue, 16 Nov 2021 14:12:21 +0900 From: Stafford Horne To: Siddhesh Poyarekar Cc: GLIBC patches Subject: Re: [PATCH] malloc: Fix malloc debug for 2.35 onwards Message-ID: References: <20211113004047.1980486-1-shorne@gmail.com> <98e3b40a-3d1f-bac9-997b-22a659a1200b@gotplt.org> <629dbe12-64c5-4307-183f-2c679a2cdd8c@gotplt.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <629dbe12-64c5-4307-183f-2c679a2cdd8c@gotplt.org> X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLACK autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Nov 2021 05:12:26 -0000 On Tue, Nov 16, 2021 at 04:17:10AM +0530, Siddhesh Poyarekar wrote: > On 11/16/21 02:37, Stafford Horne wrote: > > I am not sure, after my patch the SHLIB_COMPAT usage is just there for compat > > symbols. As you mention using SHLIB_COMPAT to ensure libc_malloc_debug.so and > > libc.so have the same version seems strange, I would think that would be > > controlled by shlib-version or done out of the box. > > Right, so it mostly works, i.e. you have symbols with version names: > > ... > > 00009bb4 g DF .text 00000030 GLIBC_2.35 memalign > > 0000a5a8 g DF .text 00000138 GLIBC_2.35 mallinfo > > 000091a0 g DF .text 00000180 GLIBC_2.35 malloc > > 0000a2ac g DF .text 000000f8 GLIBC_2.35 mallopt > ... > > but they're default versions, which is not desirable since we don't want > this library to be linkable. So you will need a new macro that always > creates the non-default symbol at the version that it was introduced. I think I get what you mean. Is this something you are planning to sort out? As is without this patch the mem tests are failing on my port, and any future ports. For existing ports it is working because of the HACK as you say. -Stafford