public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@gmail.com>
To: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	Nemanja Ivanovic <nemanjai@ca.ibm.com>,
	libc-alpha@sourceware.org, Fangrui Song <maskray@google.com>
Subject: Re: [PATCH] powerpc: Define USE_PPC64_NOTOC iff compiler and linker also supports it
Date: Wed, 17 Nov 2021 13:00:20 +1030	[thread overview]
Message-ID: <YZRpPDgvDP/EeuKb@squeak.grove.modra.org> (raw)
In-Reply-To: <YZRl6PH0Yy8ZB/Az@squeak.grove.modra.org>

On Wed, Nov 17, 2021 at 12:46:08PM +1030, Alan Modra wrote:
> I recommend losing the NOTOC on the call.  You already have the nop
> after the call when !SHARED, which is correct and necessary for a
> normal call.  You also likely have enough control over SHARED builds
> to omit the nop in that case.

Heh, I should have tried a compile first before saying the nop could
be omitted for SHARED.  It can't for -mcpu=power10, where you need a
toc save stub to go from _mcount to __mcount_internal.

-- 
Alan Modra
Australia Development Lab, IBM

  reply	other threads:[~2021-11-17  2:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08 11:33 Adhemerval Zanella
2021-11-08 22:48 ` Fangrui Song
2021-11-09 11:05   ` Alan Modra
2021-11-16 19:42     ` Tulio Magno Quites Machado Filho
2021-11-16 20:20       ` Tulio Magno Quites Machado Filho
2021-11-16 20:48         ` Florian Weimer
2021-11-16 22:12           ` Fāng-ruì Sòng
2021-11-16 22:46           ` Bill Schmidt
2021-11-17  2:16       ` Alan Modra
2021-11-17  2:30         ` Alan Modra [this message]
2021-11-09 13:03   ` Adhemerval Zanella
2021-11-09 17:44     ` Fangrui Song
2021-11-09 18:44       ` Adhemerval Zanella
2021-11-19 15:52 ` Tulio Magno Quites Machado Filho
2021-11-22 17:54   ` Adhemerval Zanella
2021-11-25 17:02     ` Tulio Magno Quites Machado Filho
2021-11-25 17:16       ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZRpPDgvDP/EeuKb@squeak.grove.modra.org \
    --to=amodra@gmail.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    --cc=maskray@google.com \
    --cc=nemanjai@ca.ibm.com \
    --cc=tuliom@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).