From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id A8EB83858D3C for ; Fri, 19 Nov 2021 11:46:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A8EB83858D3C Received: by mail-pg1-x533.google.com with SMTP id d64so6390966pgc.7 for ; Fri, 19 Nov 2021 03:46:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=E1I5tqVZIEqjHHr3t4La+KZRTZ2iPOcb856MoPoNeXo=; b=3Zn0gCu6f0lrle38XhuUMdrhoRlm3fa8k7gxMAC1HFi0QhvPHCXvcdtnriK6ZxkZzv lb8Xn6s+o8uSjtZ2Y8azBoxZ6C+8pyhPy78KCTjKSbBaCOr4QgI7ikAV3tovvidPbbr9 XZDqoPesqMgshfbqWJOQSSwg+Y3HUykh1Cq68v5fqRNc/0XoR63cUZQpgZFoE/IFg/lq Ksx6xNAtvfa0MsMc6OpLa76llVkB1gjcTYhp9fs8qZXTKhCJ6TQjuvYWcnyh1sfT3yZO jrVuMghbqiY1BHkWEHUhbN97a6KYazcabovgsPLKJNMiv+iqk9YWo70Gm6CTVx+HNZOB y32w== X-Gm-Message-State: AOAM532qspbevDMVH8Bd0WHnK1Jx3iyOBwykq6fC5VNfM9D94xMtXmD/ AHBjU9lJIw9tU0Tcp2/Oe2IF/tzp8BM= X-Google-Smtp-Source: ABdhPJw406OBujwXJeGOPQGhGg8/NC5NCnQafPbTJ2qoELlOEQvkVnzHKtHKf82rMHZatGcHA0TeYw== X-Received: by 2002:a62:750e:0:b0:49f:a27d:62b3 with SMTP id q14-20020a62750e000000b0049fa27d62b3mr63284900pfc.37.1637322361699; Fri, 19 Nov 2021 03:46:01 -0800 (PST) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id m13sm2830741pfk.76.2021.11.19.03.46.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Nov 2021 03:46:00 -0800 (PST) Date: Fri, 19 Nov 2021 20:45:58 +0900 From: Stafford Horne To: Joseph Myers Cc: GLIBC patches , Openrisc Subject: Re: [PATCH v2 03/13] or1k: ABI Implementation Message-ID: References: <20211113031639.2402161-1-shorne@gmail.com> <20211113031639.2402161-4-shorne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Nov 2021 11:46:04 -0000 On Thu, Nov 18, 2021 at 10:13:41PM +0000, Joseph Myers wrote: > On Sat, 13 Nov 2021, Stafford Horne via Libc-alpha wrote: > > > +/* Helper for generic ____longjmp_chk(). */ > > Don't use () after a function name just to indicate it's a function, as > opposed to a function call with no arguments (see the GNU Coding > Standards). OK, sorry about that, I know this but didn't remember when going though the patch on my own. I will go through and clean this up. -Stafford