From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by sourceware.org (Postfix) with ESMTPS id BA88D3858406 for ; Fri, 19 Nov 2021 23:36:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BA88D3858406 Received: by mail-pj1-x102d.google.com with SMTP id gb13-20020a17090b060d00b001a674e2c4a8so10032756pjb.4 for ; Fri, 19 Nov 2021 15:36:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xTd0/KemfPs9xdj7VAtU6M+S5SCkJAPQdl1BI1zIq+0=; b=BI0I02GNvQOqrFPM5Nd2BTx4oEFM0p8Ih6y/Zt2040rCdsHqzeoqOEc8LbcCg2G1l+ 1OavYrGcHi4SqwMmQTI4819S3RXamSRK/Y62COR7CODP6UtiL3CB/XFlvnMedwr3S2Xn XTyquTRETyel5DEaquGlLNY6tpDGzsvv5z8X9yNUNqNM4fhBXyaa1ozr839UhWYpDPg4 Dmg7X1sdCjmBXGnf/LIjRBJteZVHaktV6CkeqaTB8geDr2WQWl4N1ejM7w8jQJwsqvvW Tx9tlFFy1yJ8j76oEDW8s9AaxnrxsXvlrd39eBeKRlMgVs0ghStzOi32CH4fnXpM4kqC /FNA== X-Gm-Message-State: AOAM531GcRl6OhP2oqf7LhzJAAy0/vzeaxp+iP2CxsD8n08wx0kT0jWL RNXMgk+efCcT3+GXhmRL0vBJIgbLeJg= X-Google-Smtp-Source: ABdhPJwR0gFvrvStg1jxlftz9iCoL2WNPn5yv/zqtAAPxscWqQtnM6Jp6akTlN0dC+4lSTA4rSUyhA== X-Received: by 2002:a17:90a:6487:: with SMTP id h7mr4544607pjj.40.1637365018855; Fri, 19 Nov 2021 15:36:58 -0800 (PST) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id s15sm542274pjs.51.2021.11.19.15.36.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Nov 2021 15:36:58 -0800 (PST) Date: Sat, 20 Nov 2021 08:36:56 +0900 From: Stafford Horne To: Joseph Myers Cc: GLIBC patches , Openrisc Subject: Re: [PATCH v2 11/13] or1k: Build Infrastructure Message-ID: References: <20211113031639.2402161-1-shorne@gmail.com> <20211113031639.2402161-12-shorne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Nov 2021 23:37:04 -0000 On Thu, Nov 18, 2021 at 10:34:10PM +0000, Joseph Myers wrote: > On Sat, 13 Nov 2021, Stafford Horne via Libc-alpha wrote: > > > diff --git a/sysdeps/unix/sysv/linux/or1k/configure.ac b/sysdeps/unix/sysv/linux/or1k/configure.ac > > new file mode 100644 > > index 0000000000..d439e7fd53 > > --- /dev/null > > +++ b/sysdeps/unix/sysv/linux/or1k/configure.ac > > @@ -0,0 +1,4 @@ > > +GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory. > > +# Local configure fragment for sysdeps/unix/sysv/linux/or1k. > > + > > +arch_minimum_kernel=5.10.0 > > This seems to be a lot more recent than when OpenRISC support was actually > added to the Linux kernel, and also more recent than when 64-bit time > support was added for 32-bit architectures (which may be a convenient > minimum kernel for some new 32-bit architectures for that reason). > Requiring a newer kernel like that is certainly fine if convenient for the > port, but I think the choice of minimum kernel version, and the reasons > for it, deserve mention at least in the commit message and the NEWS file > entry. OK, during the v1 review you mentioned: You'll probably need a newer minimum kernel when requiring 64-bit time support, until all the fallback for 64-bit time on 32-bit kernels without the 64-bit-time syscalls is implemented. I really just chose the version I was working on at the time. I just looked back on it, this version 5.10 is good because. 1. it is a long term support version. 2. in 5.8 I fixed a kernel bug which caused clone/fork to not work with TLS. I will upate the commit/news. -Stafford