From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by sourceware.org (Postfix) with ESMTPS id 0DF9E3858406 for ; Fri, 19 Nov 2021 23:03:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0DF9E3858406 Received: by mail-pj1-x1031.google.com with SMTP id nh10-20020a17090b364a00b001a69adad5ebso10010344pjb.2 for ; Fri, 19 Nov 2021 15:03:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FGe2hx05xiUhVtS3iBlXEfyPhqjn4II1X1cvQiNSVb0=; b=yv1G7KWXm0Hjr1+cM8/K/lgtTE5dl/QwVNzHMZEsbCYtuab/Qw9Izn/zfJ1c5jKtL7 IG5rFgIV2Hajp1ncU8aQiMYXNK8IpYPGN8eyrVHIuh6dZCAsZCeNbD7FCN67df2lpRd6 oTOV+FL9/cZXWa5mLNH6Us6GJe5zVH+W03UZUOHxULeXFg9chnAC/13Wl+2VL63UFe9W nfpDTzp69y2tNtEtnc1yI0LPqGnoBXIZfrz41OxXLSYXdju2hJuPWTiCVmQcDBxz6qgQ 2octu7Gf3KsKK3x8hs+BpzijbZMpc3IR6VPOUWgNCZEVlkk6k0txW/87nqjbjfrSbY2R L8VA== X-Gm-Message-State: AOAM531jC9PYn6swsPdda3FhIEDm6FHiTHLw2Dreq8ZRFTAptITzz+/j I4l2Eu0+tTbQrWXnjQtJvN8ez08Va6g= X-Google-Smtp-Source: ABdhPJznOPiO0eTqzSSdNkMTu/ElG9CuKzWvEJcT26VeL9rhu7di5UeQeL6sPMOgLj17mtvqcFnxfw== X-Received: by 2002:a17:90a:7086:: with SMTP id g6mr4321545pjk.34.1637363021084; Fri, 19 Nov 2021 15:03:41 -0800 (PST) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id f8sm679567pfv.135.2021.11.19.15.03.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Nov 2021 15:03:40 -0800 (PST) Date: Sat, 20 Nov 2021 08:03:38 +0900 From: Stafford Horne To: Joseph Myers Cc: GLIBC patches , Openrisc Subject: Re: [PATCH v2 05/13] or1k: Thread Local Storage support Message-ID: References: <20211113031639.2402161-1-shorne@gmail.com> <20211113031639.2402161-6-shorne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Nov 2021 23:03:45 -0000 On Thu, Nov 18, 2021 at 10:22:23PM +0000, Joseph Myers wrote: > On Sat, 13 Nov 2021, Stafford Horne via Libc-alpha wrote: > > > diff --git a/sysdeps/or1k/dl-tls.h b/sysdeps/or1k/dl-tls.h > > new file mode 100644 > > index 0000000000..f25645c715 > > --- /dev/null > > +++ b/sysdeps/or1k/dl-tls.h > > @@ -0,0 +1,26 @@ > > +/* Copyright (C) 2021 Free Software Foundation, Inc. > > Each file should have a one-line description on the line before the > copyright notice. OK, I went through the patch's and made sure I have this on all .c .h and .S files. > > diff --git a/sysdeps/or1k/libc-tls.c b/sysdeps/or1k/libc-tls.c > > new file mode 100644 > > index 0000000000..43571944dd > > --- /dev/null > > +++ b/sysdeps/or1k/libc-tls.c > > @@ -0,0 +1,32 @@ > > +/* Copyright (C) 2021 Free Software Foundation, Inc. > > Likewise. > > > diff --git a/sysdeps/or1k/stackinfo.h b/sysdeps/or1k/stackinfo.h > > new file mode 100644 > > index 0000000000..14e767c5bf > > --- /dev/null > > +++ b/sysdeps/or1k/stackinfo.h > > @@ -0,0 +1,33 @@ > > +/* Copyright (C) 2021 Free Software Foundation, Inc. > > Likewise. > > > +/* Default to an executable stack. PF_X can be overridden if PT_GNU_STACK is > > + * present, but it is presumed absent. */ > > We don't use '*' at the start of second and subsequent lines of comments. OK, I went through the patch and tried to sort all of these occurances out. Also there were a few where we didn't have two spaces after period ".". Also, a few other similar issues. > (It seems unfortunate for a new port to default to executable stacks, but > it looks like this is indeed what the Linux kernel port to OpenRISC does, > given the lack of an override of the default VM_DATA_DEFAULT_FLAGS and > VM_STACK_DEFAULT_FLAGS.) Yes. Thanks for reviewing. -Stafford