From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by sourceware.org (Postfix) with ESMTPS id CC9593858406 for ; Fri, 19 Nov 2021 23:07:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CC9593858406 Received: by mail-pj1-x102a.google.com with SMTP id n15-20020a17090a160f00b001a75089daa3so12058842pja.1 for ; Fri, 19 Nov 2021 15:07:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=a3QIVls/cN+mZ+EWtF+ki4qzcCZH6MewXbTIyMlbaNI=; b=pMG2HpH2Tac8MLr/YeQsEHAcLnmJXF9+GN/qengpYnAgVpFskcpMEIXwTlEStQLGuj PB8ho7wmos3gBx2hPNUE4xFQEf9lBQdK6b8HOl8TF5ZjZfk1zKpxgPBSVgOlJ93QE+1N wlJhboxBaeiiSmg6kbfkQ74mnFnERt+ZFH1xNre4Y1IHPUAzEUTakK3D8m+t2+xERWV0 tj1QIeU/hlI1Hv1VdbSo+VQwaAyIsnMOkkAR4O3rfQS0qVZ7gSO0AmoqSjpXZ5LRoLcl nt6uKLuk+u2p1zFsyz6tphOueJ4xFhunbkRoGN7G05q4HeM4fEiZbd6NwkmVNH0QQrwm 6e1A== X-Gm-Message-State: AOAM530PiwzsURscGIMzjwg8Mz4DQyyBYZuckn6zhRPkzkRWZtRc31dy fhbEuVGU0e3UrWULjWiCjQk= X-Google-Smtp-Source: ABdhPJy6Ys9TWKy5mTZzwxoqnf5vRszU5vYztnyHsmb+URahpUETLpeXLog0Vuk6pHiVm0IogDaLMA== X-Received: by 2002:a17:902:b097:b0:141:ec7d:a055 with SMTP id p23-20020a170902b09700b00141ec7da055mr81092432plr.3.1637363250917; Fri, 19 Nov 2021 15:07:30 -0800 (PST) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id v1sm620254pfg.169.2021.11.19.15.07.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Nov 2021 15:07:30 -0800 (PST) Date: Sat, 20 Nov 2021 08:07:28 +0900 From: Stafford Horne To: Joseph Myers Cc: GLIBC patches , Openrisc Subject: Re: [PATCH v2 07/13] or1k: math soft float support Message-ID: References: <20211113031639.2402161-1-shorne@gmail.com> <20211113031639.2402161-8-shorne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Nov 2021 23:07:34 -0000 On Thu, Nov 18, 2021 at 10:28:03PM +0000, Joseph Myers wrote: > On Sat, 13 Nov 2021, Stafford Horne via Libc-alpha wrote: > > > diff --git a/sysdeps/or1k/bits/fenv.h b/sysdeps/or1k/bits/fenv.h > > new file mode 100644 > > index 0000000000..49194ad851 > > --- /dev/null > > +++ b/sysdeps/or1k/bits/fenv.h > > @@ -0,0 +1,68 @@ > > +/* Copyright (C) 2021 Free Software Foundation, Inc. > > Missing one-line description at start of file. OK Added for v3. > The constants you're defining here seem to be specific to hard float, but > they're defined unconditionally. Is this because you use the same ABI for > hard float and soft float (which is generally the case when such hard > float constants might be defined for soft float as well - a soft float > compilation could be using a hard float libc that supports those > constants)? Yes, it's the same ABI. I have patches for hard float but am not submitting until the Linux side is sorted out as mentioned in the comment. It seems delcairing these conditionally was normal, hence I didn't mention anything about it. I didn't think as far as allowing for shared libc usage between soft/float float, but I think that would work. > > +/* Define bits representing exceptions in the FPCSR status word. */ > > +enum > > + { > > + FE_OVERFLOW = > > +#define FE_OVERFLOW 1 << 3 > > Macros need to be properly surrounded by parentheses so they always group > as a single operand in any expression. > > > +#define FP_EX_OVERFLOW 1 << 3 > > +#define FP_EX_UNDERFLOW 1 << 4 > > +#define FP_EX_INEXACT 1 << 8 > > +#define FP_EX_INVALID 1 << 9 > > +#define FP_EX_DIVZERO 1 << 11 > > Likewise in sfp-machine.h. OK, I have cleaned those up. > -- > Joseph S. Myers > joseph@codesourcery.com