From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id 072E63857C6D for ; Fri, 26 Nov 2021 23:03:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 072E63857C6D Received: by mail-pg1-x52f.google.com with SMTP id h63so9352128pgc.12 for ; Fri, 26 Nov 2021 15:03:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=E4lGTUFIVtfUEWbq7/RisDVV9ObJUCBoLAU+zG7S7vQ=; b=vKgbXpf5d91EGfLw2yB/xIklYM15oL1L90k/hEeQVfFe5bYW1vh2vjQz7MNxyQazZI 7ufi786J0Ehz/UvdljyBeV4N+R6C6hhA3vHf9+MjZ2TvO/E8YjS9v+F5gs0KM/ZwApI9 Dby26izz1G8JWBXMNxSklHEsUx5aS0KNF5I8QcTp/03sHT4Xnk6o8aRZ2DWT4aIiqwQ1 aFCllP/ww9CvJAH66B4U/EjZTUsGcoJO+nfAWk0wcYMQg2S07Q3O+rtOLpJUKBtIR/7S uXBkftHMNmx3F3w94PC8r0M0yHW/371CFhhpCkhIAftrT7Bec2M6eVBzqAf0OzLlzYg7 HIcw== X-Gm-Message-State: AOAM532riHqwldpU3A8VpIwlInPpImBDj+LDFTBCSL4JfYGPYGvVhfkU cINaewUHcsrVJuhED0+NSscW5ywvbv8= X-Google-Smtp-Source: ABdhPJwemAWKNZEWXp606XxoFYsazkLcxIsrsYBcnE0WBntqg7MuRWsm1rYgThLTPErsiIKis74DXQ== X-Received: by 2002:a63:82c3:: with SMTP id w186mr23183328pgd.301.1637967804067; Fri, 26 Nov 2021 15:03:24 -0800 (PST) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id d12sm7918035pfh.165.2021.11.26.15.03.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Nov 2021 15:03:23 -0800 (PST) Date: Sat, 27 Nov 2021 08:03:21 +0900 From: Stafford Horne To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 4/6] linux: Implement pipe in terms of __NR_pipe2 Message-ID: References: <20211122185437.1934590-1-adhemerval.zanella@linaro.org> <20211122185437.1934590-5-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211122185437.1934590-5-adhemerval.zanella@linaro.org> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Nov 2021 23:03:26 -0000 On Mon, Nov 22, 2021 at 03:54:35PM -0300, Adhemerval Zanella wrote: > It removes the arch-specific implementation for alpha, ia64, > mips, sh, and sparc which requires a different kernel ABI > than the usual one. > > Checked on x86_64-linux-gnu and with a build for the affected ABIs. > --- > sysdeps/unix/alpha/pipe.S | 30 -------------- > sysdeps/unix/mips/pipe.S | 31 --------------- > sysdeps/unix/sysv/linux/alpha/pipe.S | 1 - > sysdeps/unix/sysv/linux/ia64/pipe.S | 36 ----------------- > sysdeps/unix/sysv/linux/mips/pipe.S | 1 - > sysdeps/unix/sysv/linux/{generic => }/pipe.c | 5 ++- > sysdeps/unix/sysv/linux/sh/pipe.S | 42 -------------------- > sysdeps/unix/sysv/linux/sparc/sparc32/pipe.S | 38 ------------------ > sysdeps/unix/sysv/linux/sparc/sparc64/pipe.S | 39 ------------------ > sysdeps/unix/sysv/linux/syscalls.list | 1 - > 10 files changed, 3 insertions(+), 221 deletions(-) > delete mode 100644 sysdeps/unix/alpha/pipe.S > delete mode 100644 sysdeps/unix/mips/pipe.S > delete mode 100644 sysdeps/unix/sysv/linux/alpha/pipe.S > delete mode 100644 sysdeps/unix/sysv/linux/ia64/pipe.S > delete mode 100644 sysdeps/unix/sysv/linux/mips/pipe.S > rename sysdeps/unix/sysv/linux/{generic => }/pipe.c (87%) > delete mode 100644 sysdeps/unix/sysv/linux/sh/pipe.S > delete mode 100644 sysdeps/unix/sysv/linux/sparc/sparc32/pipe.S > delete mode 100644 sysdeps/unix/sysv/linux/sparc/sparc64/pipe.S This patch all looks good to me. We might want to mention in the commit message that this is allowed because: The syscall pipe2 was added in linux 2.6.27 and glibc requires linux 3.2.0. For reference, these patches set the tree wided minimum required version most recently. I dont know what it was before but its fare to say using pipe2 is safe. 2016: 5b4ecd3f95 ("Require Linux 3.2 except on x86 / x86_64, 3.2 headers everywhere."). 2017: 139ace9575 ("Require Linux kernel 3.2 or later on x86 / x86_64."). -Stafford