From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by sourceware.org (Postfix) with ESMTPS id 3D6013858014 for ; Fri, 17 Dec 2021 15:03:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3D6013858014 Received: by mail-pj1-x102d.google.com with SMTP id gj24so2543848pjb.0 for ; Fri, 17 Dec 2021 07:03:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=V7306x+Jo+GDemuCIpeIOawTbzWQwkapGEuokahzb7c=; b=fDhDxCCoLQOM54BmYFtnjS6pcVTc0N7Vh02Bbc1dgkVc7KOTiuG/uQ4fhUaVoP1KGX 1JBCmf76NCMHf+cV6mATzu+SbLjB1RGyWy6cOWv7D1QGQU+QIOxFwYyDTc2oAb4/Godj sLwECgacXqZmF3n6S1CREWOQJkYhFCh1E2qfNrY9QJkmFsrnRdhsUrkKzR/5IBriSMX4 1OUjwvGELZVcFdL0PuRFvilGTCwGJ07EctGcxsgXwIeR9JcJkP7CNVHfu7nQBujqjewA E6ECWDWbAcGfuaVgmuB3i+BNo8Do510BeoWmEE/cg6LW39N8w+p6qDm9TCcPa90QZtRV F37Q== X-Gm-Message-State: AOAM5316TI47bhzWwRRkobB57+Fq3MeBHFmP6vOUIPgh5eXXUeCzR8lR N5V90tsLSw0PU9aGubj3D5UfNedZeNQ= X-Google-Smtp-Source: ABdhPJxzgcUypqebEoXR3etlpGae8Ppmn/fmi0NGLvG1DCD+gzQhnPcSdCTwysPUCpiZ4XTTnvek5Q== X-Received: by 2002:a17:90a:a002:: with SMTP id q2mr4236894pjp.69.1639753392319; Fri, 17 Dec 2021 07:03:12 -0800 (PST) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id mm22sm8802152pjb.28.2021.12.17.07.03.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Dec 2021 07:03:11 -0800 (PST) Date: Sat, 18 Dec 2021 00:03:09 +0900 From: Stafford Horne To: Adhemerval Zanella Cc: GLIBC patches , Openrisc Subject: Re: [PATCH v3 06/13] or1k: Atomics and Locking primitives Message-ID: References: <20211210233456.4146479-1-shorne@gmail.com> <20211210233456.4146479-7-shorne@gmail.com> <39803fe3-ab39-524a-c678-1b74d092c436@linaro.org> <3facf07d-85b9-7ccc-eee5-78be8dc69f45@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3facf07d-85b9-7ccc-eee5-78be8dc69f45@linaro.org> X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2021 15:03:14 -0000 On Thu, Dec 16, 2021 at 04:43:52PM -0300, Adhemerval Zanella wrote: > > > On 16/12/2021 09:52, Adhemerval Zanella wrote: > > LGTM, thanks. > > > > On 10/12/2021 20:34, Stafford Horne via Libc-alpha wrote: > >> --- > >> sysdeps/or1k/atomic-machine.h | 79 +++++++++++++++++++++++++++++++++++ > >> 1 file changed, 79 insertions(+) > >> create mode 100644 sysdeps/or1k/atomic-machine.h > >> > >> diff --git a/sysdeps/or1k/atomic-machine.h b/sysdeps/or1k/atomic-machine.h > >> new file mode 100644 > >> index 0000000000..1e306ae4ef > >> --- /dev/null > >> +++ b/sysdeps/or1k/atomic-machine.h > >> @@ -0,0 +1,79 @@ > >> +/* Atomic operations. OpenRISC version. > >> + Copyright (C) 2021 Free Software Foundation, Inc. > >> + This file is part of the GNU C Library. > >> + > >> + The GNU C Library is free software; you can redistribute it and/or > >> + modify it under the terms of the GNU Lesser General Public > >> + License as published by the Free Software Foundation; either > >> + version 2.1 of the License, or (at your option) any later version. > >> + > >> + The GNU C Library is distributed in the hope that it will be useful, > >> + but WITHOUT ANY WARRANTY; without even the implied warranty of > >> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > >> + Lesser General Public License for more details. > >> + > >> + You should have received a copy of the GNU Lesser General Public > >> + License along with the GNU C Library. If not, see > >> + . */ > >> + > >> +#ifndef __OR1K_ATOMIC_H_ > >> +#define __OR1K_ATOMIC_H_ > >> + > >> +#include > >> + > >> +typedef int32_t atomic32_t; > >> +typedef uint32_t uatomic32_t; > >> + > >> +typedef intptr_t atomicptr_t; > >> +typedef uintptr_t uatomicptr_t; > >> +typedef intmax_t atomic_max_t; > >> +typedef uintmax_t uatomic_max_t; > > > > Sigh, these definition are used solely in only file, memusage.c. Another thing > > I will cleanup. > > I just send a patchset that aims to simplify this boilerplate [1]. It should > also simplify other parts of OpenRISC submission. > > [1] https://sourceware.org/pipermail/libc-alpha/2021-December/134285.html Thanks, I have seen it.