From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by sourceware.org (Postfix) with ESMTPS id 216BE3858405 for ; Mon, 20 Dec 2021 11:53:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 216BE3858405 Received: by mail-pj1-x102e.google.com with SMTP id n15-20020a17090a160f00b001a75089daa3so12640454pja.1 for ; Mon, 20 Dec 2021 03:53:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ayc93V3L7BuYFOl6XWRi3HB+Z+45QFXRMG3zcrEwomA=; b=Ou9+V7eh/U5rM+vgjn8FuJ5THnVkcmpIfLYvYOgRR1+M3ThzsYM4peB/FyUdKo/ZGL QFT7zzSZmDgSDrirlZaFFSzh2Et2+sNLYFn7ENIAR9w3MDO7zPy2cOb+FHypk0iDNnYf dlqb7lnsiPicy6pJW9RQw+oyLi/w83FJLWnQn1+mkVMX8IS7ZPlW3SZYVID1b0gm6N3W hhfyJgX22FREqX31fi9MFbSmNITwfI7yVe6HoGLe8Jf0/hx3RLThe+Bf6IwgIh4zuUd3 lCfVrjkVUxhrAgml2kwJ9pQ7ZCl+kY6p9AH/Vyhd0Njezn5gJbiKYlcF52bRFod5jJ1W 8kAg== X-Gm-Message-State: AOAM530c+E7HPKdeJ8Tk9+YtAKD9XrhTNlqWZ8z1SWkYVynNQgwFN0Ip HnB40I4zq3TCZQHhSI3DGcM= X-Google-Smtp-Source: ABdhPJyF66fUe6GdyzbqyI2ft0d4CPtLrgFQCRfwTaYMRHtFPtOV4cXfoNqkYgK26EEbSG9dWAEqAw== X-Received: by 2002:a17:902:aa42:b0:148:ab2f:d3dd with SMTP id c2-20020a170902aa4200b00148ab2fd3ddmr6139101plr.110.1640001228159; Mon, 20 Dec 2021 03:53:48 -0800 (PST) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id a1sm19876180pfv.99.2021.12.20.03.53.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 03:53:47 -0800 (PST) Date: Mon, 20 Dec 2021 20:53:45 +0900 From: Stafford Horne To: Adhemerval Zanella Cc: GLIBC patches , Openrisc Subject: Re: [PATCH v3 08/13] or1k: Linux Syscall Interface Message-ID: References: <20211210233456.4146479-1-shorne@gmail.com> <20211210233456.4146479-9-shorne@gmail.com> <58c906a6-76b0-e4e1-bc17-5338b10e25f0@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58c906a6-76b0-e4e1-bc17-5338b10e25f0@linaro.org> X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Dec 2021 11:53:51 -0000 On Fri, Dec 17, 2021 at 02:41:20PM -0300, Adhemerval Zanella wrote: > > > On 17/12/2021 12:01, Stafford Horne wrote: > > On Thu, Dec 16, 2021 at 06:17:45PM -0300, Adhemerval Zanella wrote: > >>> diff --git a/sysdeps/unix/sysv/linux/or1k/bits/timesize.h b/sysdeps/unix/sysv/linux/or1k/bits/timesize.h > >>> new file mode 100644 > >>> index 0000000000..3ab388da7f > >>> --- /dev/null > >>> +++ b/sysdeps/unix/sysv/linux/or1k/bits/timesize.h > >>> @@ -0,0 +1,19 @@ > >>> +/* Bit size of the time_t type at glibc build time, OpenRISC version. > >>> + Copyright (C) 2021 Free Software Foundation, Inc. > >>> + This file is part of the GNU C Library. > >>> + > >>> + The GNU C Library is free software; you can redistribute it and/or > >>> + modify it under the terms of the GNU Lesser General Public > >>> + License as published by the Free Software Foundation; either > >>> + version 2.1 of the License, or (at your option) any later version. > >>> + > >>> + The GNU C Library is distributed in the hope that it will be useful, > >>> + but WITHOUT ANY WARRANTY; without even the implied warranty of > >>> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > >>> + Lesser General Public License for more details. > >>> + > >>> + You should have received a copy of the GNU Lesser General Public > >>> + License along with the GNU C Library; if not, see > >>> + . */ > >>> + > >>> +#define __TIMESIZE 64 > >> > >> Ok, although I think we should flip the default to 64 bits make > >> old ports to override to 32. > > > > It makes sense. It might be a bit tricky as currently __TIMESIZE default is > > __WORDSIZE. I see a few old ports which have __WORDSIZE 32 and 64 like sparc. > > I will fix this upstream, it is just a matter to override to 32 for older ports. > > >> > >> Ok, I take that implementing it solely on __or1k_clone is more complex than > >> using a C wrapper. > > > > I am not to clear what you mean here, I take you are asking why we keep > > __or1k_clone in assembly rather than implement __or1k_clone in C too. > > > > There are some stack setup bits in __or1k_clone which require assembly. > > > > I meant otherwise in fact, why not implement clone for or1k purely in assembly. I see, it could be done but I think it's easier to maintain with the va_arg parsing and generic set_errno handling being in C. -Staffford