From: Stafford Horne <shorne@gmail.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: GLIBC patches <libc-alpha@sourceware.org>,
Florian Weimer <fweimer@redhat.com>,
Openrisc <openrisc@lists.librecores.org>
Subject: Re: [PATCH v3 10/13] or1k: ABI lists
Date: Thu, 23 Dec 2021 17:36:49 +0900 [thread overview]
Message-ID: <YcQ1IXV81T8xuFJd@antec> (raw)
In-Reply-To: <1a46b8a6-87dd-b811-fd82-0292ea575935@linaro.org>
On Wed, Dec 22, 2021 at 05:20:10PM -0300, Adhemerval Zanella wrote:
>
>
> On 10/12/2021 20:34, Stafford Horne via Libc-alpha wrote:
>
> > diff --git a/sysdeps/unix/sysv/linux/or1k/ld.abilist b/sysdeps/unix/sysv/linux/or1k/ld.abilist
> > new file mode 100644
> > index 0000000000..c4b85c8a33
> > --- /dev/null
> > +++ b/sysdeps/unix/sysv/linux/or1k/ld.abilist
> > @@ -0,0 +1,5 @@
> > +GLIBC_2.35 __libc_stack_end D 0x4
> > +GLIBC_2.35 __stack_chk_guard D 0x4
> > +GLIBC_2.35 __tls_get_addr F
> > +GLIBC_2.35 _dl_mcount F
> > +GLIBC_2.35 _r_debug D 0x14
>
> You will need to regenerate it to include the rseq symbols:
>
> GLIBC_2.35 __rseq_flags D 0x4
> GLIBC_2.35 __rseq_offset D 0x4
> GLIBC_2.35 __rseq_size D 0x4
OK, I will regenerate, this patch series was generated from before
these symbols were introduced.
> > diff --git a/sysdeps/unix/sysv/linux/or1k/libBrokenLocale.abilist b/sysdeps/unix/sysv/linux/or1k/libBrokenLocale.abilist
> > new file mode 100644
> > index 0000000000..366c393274
> > --- /dev/null
> > +++ b/sysdeps/unix/sysv/linux/or1k/libBrokenLocale.abilist
> > @@ -0,0 +1 @@
> > +GLIBC_2.35 __ctype_get_mb_cur_max F
> > diff --git a/sysdeps/unix/sysv/linux/or1k/libanl.abilist b/sysdeps/unix/sysv/linux/or1k/libanl.abilist
> > new file mode 100644
> > index 0000000000..c6437809db
> > --- /dev/null
> > +++ b/sysdeps/unix/sysv/linux/or1k/libanl.abilist
> > @@ -0,0 +1 @@
> > +GLIBC_2.35 __libanl_version_placeholder F
>
> This does seems right, or1k should not require the placeholder. I think
> we are missing a SHLIB_COMPAT on resolv/libanl-compat.c:
>
> diff --git a/resolv/libanl-compat.c b/resolv/libanl-compat.c
> index 29df76f278..02c18bde90 100644
> --- a/resolv/libanl-compat.c
> +++ b/resolv/libanl-compat.c
> @@ -30,6 +30,8 @@ __libanl_version_placeholder_1 (void)
> {
> }
>
> +# if SHLIB_COMPAT (libanl, GLIBC_2_2_3, GLIBC_2_34)
> compat_symbol (libanl, __libanl_version_placeholder_1,
> __libanl_version_placeholder, GLIBC_2_2_3);
> +# endif
> #endif
I confirm this fixes the issue.
> > diff --git a/sysdeps/unix/sysv/linux/or1k/libutil.abilist b/sysdeps/unix/sysv/linux/or1k/libutil.abilist
> > new file mode 100644
> > index 0000000000..f33b84813b
> > --- /dev/null
> > +++ b/sysdeps/unix/sysv/linux/or1k/libutil.abilist
> > @@ -0,0 +1 @@
> > +GLIBC_2.35 __libutil_version_placeholder F
>
> This also does not seems right, libutil-compat will only built for
> have-GLIBC_2.33, which is not the case.
I think this file is leftover now that libutil is just an libutil.a
update-abi generates nothing.
I have just deleted the file. check-abi seems to work ok.
Note, I aldo delete the other blank abilist files. So:
deleted: sysdeps/unix/sysv/linux/or1k/libanl.abilist
deleted: sysdeps/unix/sysv/linux/or1k/libdl.abilist
deleted: sysdeps/unix/sysv/linux/or1k/libpthread.abilist
deleted: sysdeps/unix/sysv/linux/or1k/librt.abilist
deleted: sysdeps/unix/sysv/linux/or1k/libutil.abilist
-Stafford
next prev parent reply other threads:[~2021-12-23 8:36 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 23:34 [PATCH v3 00/13] Glibc OpenRISC port Stafford Horne
2021-12-10 23:34 ` [PATCH v3 01/13] elf: Add reloc for OpenRISC Stafford Horne
2021-12-14 20:28 ` Adhemerval Zanella
2021-12-10 23:34 ` [PATCH v3 02/13] linux/syscalls: Add or1k_atomic syscall " Stafford Horne
2021-12-14 20:29 ` Adhemerval Zanella
2021-12-10 23:34 ` [PATCH v3 03/13] or1k: ABI Implementation Stafford Horne
2021-12-14 20:53 ` Adhemerval Zanella
2021-12-14 22:43 ` Joseph Myers
2021-12-15 1:15 ` Adhemerval Zanella
2021-12-15 23:33 ` Stafford Horne
2021-12-16 10:30 ` Adhemerval Zanella
2021-12-16 21:28 ` Stafford Horne
2021-12-10 23:34 ` [PATCH v3 04/13] or1k: startup and dynamic linking code Stafford Horne
2021-12-16 10:42 ` Adhemerval Zanella
2021-12-17 23:03 ` Stafford Horne
2021-12-20 19:45 ` Adhemerval Zanella
2021-12-20 21:40 ` Stafford Horne
2021-12-21 11:09 ` Adhemerval Zanella
2021-12-21 11:46 ` Stafford Horne
2021-12-10 23:34 ` [PATCH v3 05/13] or1k: Thread Local Storage support Stafford Horne
2021-12-16 11:35 ` Adhemerval Zanella
2021-12-16 12:37 ` Adhemerval Zanella
2021-12-16 19:26 ` Joseph Myers
2021-12-16 19:33 ` Adhemerval Zanella
2021-12-17 14:23 ` Stafford Horne
2021-12-10 23:34 ` [PATCH v3 06/13] or1k: Atomics and Locking primitives Stafford Horne
2021-12-16 12:52 ` Adhemerval Zanella
2021-12-16 19:43 ` Adhemerval Zanella
2021-12-17 15:03 ` Stafford Horne
2021-12-10 23:34 ` [PATCH v3 07/13] or1k: math soft float support Stafford Horne
2021-12-16 19:48 ` Adhemerval Zanella
2021-12-17 15:02 ` Stafford Horne
2021-12-10 23:34 ` [PATCH v3 08/13] or1k: Linux Syscall Interface Stafford Horne
2021-12-16 21:17 ` Adhemerval Zanella
2021-12-17 15:01 ` Stafford Horne
2021-12-17 17:41 ` Adhemerval Zanella
2021-12-20 11:53 ` Stafford Horne
2021-12-10 23:34 ` [PATCH v3 09/13] or1k: Linux ABI Stafford Horne
2021-12-21 13:41 ` Adhemerval Zanella
2021-12-21 14:54 ` Stafford Horne
2021-12-22 10:54 ` Stafford Horne
2021-12-10 23:34 ` [PATCH v3 10/13] or1k: ABI lists Stafford Horne
2021-12-22 20:20 ` Adhemerval Zanella
2021-12-23 8:36 ` Stafford Horne [this message]
2021-12-10 23:34 ` [PATCH v3 11/13] or1k: Build Infrastructure Stafford Horne
2021-12-22 21:03 ` Adhemerval Zanella
2021-12-23 7:32 ` Stafford Horne
2021-12-10 23:34 ` [PATCH v3 12/13] build-many-glibcs.py: add OpenRISC support Stafford Horne
2021-12-22 21:04 ` Adhemerval Zanella
2021-12-23 7:15 ` Stafford Horne
2021-12-10 23:34 ` [PATCH v3 13/13] Documentation for OpenRISC port Stafford Horne
2021-12-23 12:57 ` Adhemerval Zanella
2021-12-14 20:25 ` [PATCH v3 00/13] Glibc " Adhemerval Zanella
2021-12-15 1:19 ` Adhemerval Zanella
2021-12-15 5:34 ` Stafford Horne
2021-12-15 5:37 ` Stafford Horne
2021-12-23 15:46 ` Stafford Horne
2021-12-23 15:57 ` Andreas Schwab
2021-12-23 21:26 ` Stafford Horne
2021-12-25 7:24 ` Stafford Horne
2021-12-25 22:44 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcQ1IXV81T8xuFJd@antec \
--to=shorne@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=openrisc@lists.librecores.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).