From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 96A603858D35 for ; Thu, 23 Dec 2021 21:26:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 96A603858D35 Received: by mail-pf1-x42d.google.com with SMTP id c2so6256360pfc.1 for ; Thu, 23 Dec 2021 13:26:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HXDOjTIN+3v5iXMAJwjckqsAXorP+FtuEpepV7jIPxw=; b=UfgHGluN/fZw1WZ1bzP7Fp8NS6wfQ+uyIaA7xc1NxVXvxav6yNfkJZ9eHH+rP2M/so dx0PSyBRUpTk5y+Ypiq328hzqz71Bj2kcLP+WhwlnrcAwhVMRn41tfn1AWZc9w3JqSln sflECOi6GUX90S5IubEqYcW2cj5p8jyF0lX++/P4uM9chGVvS0JNIDrxP/JN0OkATwbC acNd2vpaRJ5lKOfxzL6/qsyS0sLQyLnuD8kEzghmW76CN97Sho5uTcE3FGCPLQWNibUj aipJxKVSGp9g9yy8JBDTzACrm18fFZa6GJf184noH8s4aI2mMNoKoW+L6guXKusrz1JP 3KDw== X-Gm-Message-State: AOAM531N4jy0g4iAqLcmsX8q/mwyOddYR9bPQPY/5Xi/W72oUqUjigSU EMnDMtB77IfTCIGIhbPypZ4= X-Google-Smtp-Source: ABdhPJxy7Tg0KN5mSURO97DBFGpHe9fgYN8VZkR+eNBirJ/qW04STaXhA6lTPk/uOdTLJMB4VRzQ2A== X-Received: by 2002:a63:5b4f:: with SMTP id l15mr3591687pgm.369.1640294813374; Thu, 23 Dec 2021 13:26:53 -0800 (PST) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id x2sm5642664pgo.2.2021.12.23.13.26.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Dec 2021 13:26:52 -0800 (PST) Date: Fri, 24 Dec 2021 06:26:50 +0900 From: Stafford Horne To: Andreas Schwab Cc: Stafford Horne via Libc-alpha , Adhemerval Zanella , Openrisc Subject: Re: [PATCH v3 00/13] Glibc OpenRISC port Message-ID: References: <20211210233456.4146479-1-shorne@gmail.com> <87pmpnnwjf.fsf@igel.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87pmpnnwjf.fsf@igel.home> X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Dec 2021 21:26:55 -0000 On Thu, Dec 23, 2021 at 04:57:56PM +0100, Andreas Schwab wrote: > On Dez 24 2021, Stafford Horne via Libc-alpha wrote: > > > It seems the write to the tmp file was failing due the re-open not passing > > O_LARGEFILE. > > open64 implies O_LARGEFILE, so if that is making a difference, then your > open64 is broken. Right, that is what the docs say. This architecuture is 32-bits. And the open64 path is generic. Possibly this bit removing O_LARGEFILE is wrong? In sysdeps/unix/sysv/linux/open64.c: 27 #ifdef __OFF_T_MATCHES_OFF64_T 28 # define EXTRA_OPEN_FLAGS 0 29 #else 30 # define EXTRA_OPEN_FLAGS O_LARGEFILE 31 #endif Otherwise there is something is wrong on linux. It is explicitly checking for the precense of O_LARGEFILE. in fs/read_write.c in generic_write_check_limits: if (!(file->f_flags & O_LARGEFILE)) max_size = MAX_NON_LFS; > -- > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 > "And now for something completely different."