From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by sourceware.org (Postfix) with ESMTPS id 471FA3858C2C for ; Tue, 4 Jan 2022 21:36:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 471FA3858C2C Received: by mail-pj1-x1032.google.com with SMTP id gj24so32392199pjb.0 for ; Tue, 04 Jan 2022 13:36:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OpMKJZqlK45EEXMkRyERYlTAAoGbn4fbcapiGG62py4=; b=mTwozTB+qiw6n4ZuNtCSvnYLcp6RYrdWA4bY9XRBM09NdZtZuvWEpx23TnwuB7ChXJ /e5Mori7KJuSqbl5Gv/3ymlSmaegv3mANl62VtHG7ArKng/tKpWJTKyrfCzGiJ7cTpCd D5gteliYelVRiEH6iz3K5lKH4rVcEqxD3BApvcwnvf33jcGfVm2yp0YQAZueAN1p4Cid mEuYBAYwLct/G6aJDDHATmH5Y5QiXPplWD9z/jJdUjxTI+E1n3jInSSkPHSkPlIxU+EQ RE2ocdliHnymLMKJTBQuANKbeOClXm9oXyRvJ9EPGdR7oFeYqNTr+ssWUhkJmQ5+FeJ2 kMvA== X-Gm-Message-State: AOAM530Radgjvk/qr4wm8H4Pe96NZsjAp4+tShkwqcHBfoKQzqWm1zdI Akcl/7ilI2JR1NhyQFtDozn0eTkHPW8= X-Google-Smtp-Source: ABdhPJwi1liXwaF3Yt29LclaQ1fO52mpuIO50BIfTrDi90OaqYHFFe4e/W1yh3fgrPN48KJ2C+4JHg== X-Received: by 2002:a17:902:c947:b0:149:92d:fc44 with SMTP id i7-20020a170902c94700b00149092dfc44mr50818230pla.139.1641332188281; Tue, 04 Jan 2022 13:36:28 -0800 (PST) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id i11sm42758152pfq.206.2022.01.04.13.36.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jan 2022 13:36:27 -0800 (PST) Date: Wed, 5 Jan 2022 06:36:25 +0900 From: Stafford Horne To: Adhemerval Zanella Cc: GLIBC patches , Openrisc Subject: Re: [PATCH v5 00/13] Glibc OpenRISC port Message-ID: References: <20220104031414.2416928-1-shorne@gmail.com> <3b11ca1a-e0c6-9245-d91a-6d987e9e40fd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3b11ca1a-e0c6-9245-d91a-6d987e9e40fd@linaro.org> X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jan 2022 21:36:31 -0000 On Tue, Jan 04, 2022 at 09:34:47AM -0300, Adhemerval Zanella wrote: > > > On 04/01/2022 00:14, Stafford Horne via Libc-alpha wrote: > > This is the OpenRISC port for glibc that I have been working on. > > > > Changes since v4: > > - Fix suggestion from Joseph Myers > > - Remove libnsl.abilist > > - Fixed suggestions from Adhemerval: > > - Use Elf32_Addr and Elf32_Sym on link.h and sotruss-lib.c. > > - Remove the superflous atomic typedefs on atomic-machine.h. > > - Add the _dl_find_object on libc.abilist. > > - Update wording for the NEWS entry. > > - Other fixes > > - Update date to 2022 > > - Remove uneeded REGSIZE > > - Remove trailing newlines in Makefile > > - Fix space vs tabs indentation in sysdep.h > > > > Changes since v3: > > - Fix suggestion from Paul Eggert > > - Fix typo pore/port > > - Fixed suggestions from Adhemerval: > > - Used ENTRY/END asm macros where missing > > - Remove block in dl-machine.h suggesting LD_PROFILE > > - Remove jmp_buf-macros.h macros and use new default. > > - Remove tcb-offsets.sym file and Makefile reference. > > - Remove tcb-offsets.h include in tls.h. > > - Define lib-audit register layout inline with other architectures. > > - Fix usage of locally defined register in or1k_get_got. Also, fixup > > indentation when using or1k_get_got. > > - Cleanup abilists after rebasing, adding rseq and removing > > empty files. > > - Remove prctl and other unused entries in the linux Makefile. > > - Fix STACK_ALIGN to 4 bytes, from incorrect copy-n-paste 16 bytes. > > - Use default pthreadtypes-arch.h. > > - Mention only soft-float supported in NEWS. > > - Remove sysdeps/unix/sysv/linux/or1k/bits/timesize.h and use new > > default. > > > > Changes since v2: > > - Fixed suggestions from Joseph Myers: > > - Fix comment style, and description on top of each file > > - Make sure macros have parentheses when needed, > > - Bump required kernel down to 5.4.0 and document > > - Regenerate arch-syscall.h > > - Fixed suggestions from Adhemerval: > > - Remove kernel_stat.h > > - Just set MMAP2_PAGE_UNIT to 8K > > - Remove ioctl.c and syscall.c files > > - Update TCB alignment to 32 bytes > > > > Changes since v1: > > - Update api's as suggested by Florian > > - Remove hard float support > > - Updates to get all tests passing > > - Split patch into managable bits similar to recent ARC port > > > > Documentation: > > > > Architecture / ABI docs: > > https://raw.githubusercontent.com/openrisc/doc/master/openrisc-arch-1.3-rev1.pdf > > > > Test Results: > > > > build-many-glibcs.py: > > > > PASS with mainline ang gcc-11. > > > > Full test suite: > > > > This time I ran the test suite with timeout of 300 and with patch for forcing > > O_LARGEFILE in open64 [0]. The test has one failure but it seems like flaky > > test as it passed after the second run. > This is already approved, so I take these tests were done against and slight order > tree (which is fine btw). Sorry, I forgot to update this bit for v5. The patch for open64 is already upstream. > > > > # results in file: /home/shorne/work/gnu-toolchain/log/test--20211226-162029.log > > # test start: 2021-12-26T16:20:29+09:00 > > > > # failures > > FAIL: posix/tst-execveat /* Running second time passes */ > > > > # test finish: 2021-12-29T12:54:08+09:00 > > # test duration: 2 days 20 hours 33 minutes and 39 seconds > > # test for file: tests.sum > > # test wrapper: /home/shorne/work/gnu-toolchain/glibc/scripts/cross-test-ssh.sh --timeoutfactor 300 10.0.0.5 > > > > # summary > > 1 FAIL > > 4148 PASS > > 31 UNSUPPORTED > > 16 XFAIL > > 2 XPASS > > > > posix/tst-execveat.out: > > Timed out: killed the child process > > Termination time: 2021-12-29T01:02:42.433964340 > > Last write to standard output: 2021-12-28T23:22:40.266363000 > > > > tests.sum: https://gist.github.com/stffrdhrn/88c1fce0c54350258f1f5869068d015a > > > > [0] https://sourceware.org/pipermail/libc-alpha/2021-December/134634.html > > > > I approved the missing patch and I think the patches are ok to go in. I am > curious about the posix/tst-execveat issues, but since it does not really > have any arch-specific implementation I think it might be related to the > test environment (it would be good to know exactly what has caused the > failure so we can improve it). It fails with what looks like a deadlock but I cannot reproduce it. When it fails it times our after several minutes, when I run it again it passes right away. The platform I run on loads binaries over NFS. There may be some kind of race condition caused when binaries are loading slowly. I will wait a day or so for comments then push this upstream. If no objections, thanks for all your help reviewing. Note, after pushing up stream I will also publish all of the updates to the glibc wiki. -Stafford