From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 40A1E3858436 for ; Mon, 24 Jan 2022 06:51:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 40A1E3858436 Received: by mail-pl1-x636.google.com with SMTP id t18so14585458plg.9 for ; Sun, 23 Jan 2022 22:51:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=09bMqd2jBLzVlDqTKosok4Aqo4EB1uavLF1DX6P82cs=; b=bV5T+vOELx5mUGnebOrJu5j5b0JUn3YH1JG9ZtvY2g9+8d21nSOVPFMoT7wTd71SGB OpFzBOuaFGx9mAK7THUh5P1YpiV0aPn94OfkX9hPNrXQF1LOe8DZxphXXOQPwcPcpTMD Kt0tQym3FJJDLSlOfGQrAjPCBzLH/6+KA8rMwupYP08HRftq4S7rPv/e421Ut4UMsOyQ Sa/KSG7P+TxWZWURTk6kGnJTcaHYnNhLEJMloKl3J8AG1iOuUv7kit0u1D/fUVnnIo9e 8wpt/h25KrwvI1QYLWyalOCCARIoH1hfgM1HnGyho378IISlwuvVy/PAv6UN0sRLsUhY v87Q== X-Gm-Message-State: AOAM532Zwe/mxHna/vS26GMVtMT3vw2SxCiLNVD4KZRf7DfTk50+gE3O +MAHrUbFKnawzGU1hVqrkhK1bHrWhx8= X-Google-Smtp-Source: ABdhPJxFdHpXNUVBxKcfaLxxXuVwdHf+iRHV2hV761wPquO3eaA1zmmIRSs6jAtCDTV/6At34dY0Ow== X-Received: by 2002:a17:902:9305:b0:14a:db23:eb5d with SMTP id bc5-20020a170902930500b0014adb23eb5dmr13114865plb.73.1643007094423; Sun, 23 Jan 2022 22:51:34 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id ga21sm16556463pjb.2.2022.01.23.22.51.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jan 2022 22:51:33 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id B6DD811404E9; Mon, 24 Jan 2022 17:21:30 +1030 (ACDT) Date: Mon, 24 Jan 2022 17:21:30 +1030 From: Alan Modra To: "H.J. Lu" Cc: GNU C Library , Tulio Magno Quites Machado Filho Subject: Re: [PATCH 3/5] [PowerPC] Relocate stinfo->main Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3032.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jan 2022 06:51:36 -0000 On Sun, Jan 23, 2022 at 08:48:44PM -0800, H.J. Lu wrote: > On Sun, Jan 23, 2022 at 7:51 PM Alan Modra via Libc-alpha > > + void *main = stinfo->main; > > +#if ENABLE_STATIC_PIE && !defined SHARED > > + struct link_map *map = _dl_get_dl_main_map (); > > + if (!map->l_relocated) > > + main = (char *) main + elf_machine_load_address (); > > +#endif > > Can you use __ehdr_start t here, similar to > > https://gitlab.com/x86-glibc/glibc/-/commit/1df93c500d0f81d30d1b7e323153512a8768bb72#ffb950808032d5085fdf882753d7bf8889e6a3d7 That idea hadn't occurred to me. Yes, that likely would have worked too. I used the old traditional way of calculating l_addr, which happens to be quite cheap on powerpc64, but admittedly not so good on powerpc32. -- Alan Modra Australia Development Lab, IBM