From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id 940833858437 for ; Tue, 25 Jan 2022 01:19:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 940833858437 Received: by mail-pj1-x102f.google.com with SMTP id o11so974267pjf.0 for ; Mon, 24 Jan 2022 17:19:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6fJ0nHpUlmtE1Dzue8JPvgQnpOZzJ804kMFi5nMPtqo=; b=Yuk4ccp8gxXaC2tDGLMts/nW7vyaA/XR9dRrWq7O+rqofrS2JC/1U35dWDMMGXLh2I rRWqAwrYUD8jCAYcEHbyFZ9ZvhiObUG8KLVcHSHj0ySkGSrC2ZkWlqhBQyYkG/ocs+gS TD9GPxd5eOfxiEggLFjp/i08Vd7GfDEbB/MJ9nP+fVlUtOVYcAZX/v2IEYhNQOvS4pGP V42hMUmhUJAIDZ6BwZKGOh/cwsyah3f4rrMvICuKNlktIRgEwfIYunvGTehSuh5PX+Vz Rh1l8BS2suGyT2hYyie3SCtfqSzVrPCRwVnflWGnwMjBFXEEGET+c5nTF6deJ21/qNJt CYSw== X-Gm-Message-State: AOAM530iS00fIN9gYr1juCwQ3sE1g26nu/7yJvGzbokJNAeQGnUL2KjZ lPyt5EqNd/jm4VF2KCBzIPlQrCid++I= X-Google-Smtp-Source: ABdhPJxm3WFngo6ui98gxMNszx8NTigBZz1SGXD85dwpdPEBVqb5dNjTz+x4sT+PHRVSr+L+tbJABQ== X-Received: by 2002:a17:902:9887:b0:14a:199:bc51 with SMTP id s7-20020a170902988700b0014a0199bc51mr16743129plp.39.1643073584312; Mon, 24 Jan 2022 17:19:44 -0800 (PST) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id h9sm6128933pfi.54.2022.01.24.17.19.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 17:19:43 -0800 (PST) Date: Tue, 25 Jan 2022 10:19:41 +0900 From: Stafford Horne To: Adhemerval Zanella Cc: Florian Weimer , Openrisc , GLIBC patches Subject: Re: [OpenRISC] [PATCH v5 00/13] Glibc OpenRISC port Message-ID: References: <20220104031414.2416928-1-shorne@gmail.com> <87tudt2rpg.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jan 2022 01:19:47 -0000 On Mon, Jan 24, 2022 at 10:54:58AM -0300, Adhemerval Zanella wrote: > > > On 24/01/2022 10:23, Florian Weimer via Libc-alpha wrote: > > * Stafford Horne: > > > >> This is the OpenRISC port for glibc that I have been working on. > > > > The port does not define PI_STATIC_AND_HIDDEN. Is this really > > necessary, or just an oversight due to the way the port was constructed > > (presumably with MIPS as the template)? > > > > PI_STATIC_AND_HIDDEN means that references to static functions and data > > and symbols with hidden visibility do not need any run-time relocations > > after the final link, with the build flags used by glibc. > > At least the loader with a simple hello world does not fail with qemu with > PI_STATIC_AND_HIDDEN set. > > Staffork, could you confirm it is ok to make or1k use PI_STATIC_AND_HIDDEN? Yes, this was just an oversight and it didn't show up during testing. I think this is OK as described or1k does not need runtime relocations for hidden symbols after the final link. Shall I make the patch to add configure.ac? Or do you have that ready to go already? -Stafford